Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556386 > unrolled thread

Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach()  invocations Zefan Li <lizefan@huawei.com> - 2017-01-11 11:50 +0100
    Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach()  invocations Tejun Heo <tj@kernel.org> - 2017-01-16 01:10 +0100

#1556386 — Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations

On 2016/12/30 6:11, Tejun Heo wrote:
> Hello,
> 
> On the v2 hierarchy, when controllers are enabled and disabled, other
> ->*attach() callbacks of other controllers are called spuriously with
> the same source and destination.  While this isn't critical, it's a
> bit nasty and can lead to temporary double charging on certain
> controllers.  This patchset fixes the issue.
> 
> This patchset contains the following three patches.
> 
>  0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch
>  0002-cgroup-track-migration-context-in-cgroup_mgctx.patch
>  0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch
> 
> 0001-0002 restructures migration context tracking so that extra state
> can be tracked easily.  0003 fixes the spurious ->*attach()
> invocations.
> 
> This patchset is also available in the following git branch.
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach
> 
> diffstat follows.
> 
>  kernel/cgroup/cgroup-internal.h |   69 +++++++++++++++--
>  kernel/cgroup/cgroup-v1.c       |   10 +-
>  kernel/cgroup/cgroup.c          |  161 ++++++++++++++++------------------------
>  3 files changed, 135 insertions(+), 105 deletions(-)
> 

Acked-by: Zefan Li <lizefan@huawei.com>

[toc] | [next] | [standalone]

#1559376

On Wed, Jan 11, 2017 at 06:46:33PM +0800, Zefan Li wrote:
> On 2016/12/30 6:11, Tejun Heo wrote:
> > Hello,
> > 
> > On the v2 hierarchy, when controllers are enabled and disabled, other
> > ->*attach() callbacks of other controllers are called spuriously with
> > the same source and destination.  While this isn't critical, it's a
> > bit nasty and can lead to temporary double charging on certain
> > controllers.  This patchset fixes the issue.
> > 
> > This patchset contains the following three patches.
> > 
> >  0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch
> >  0002-cgroup-track-migration-context-in-cgroup_mgctx.patch
> >  0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch
> > 
> > 0001-0002 restructures migration context tracking so that extra state
> > can be tracked easily.  0003 fixes the spurious ->*attach()
> > invocations.
> > 
> > This patchset is also available in the following git branch.
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach
> > 
> > diffstat follows.
> > 
> >  kernel/cgroup/cgroup-internal.h |   69 +++++++++++++++--
> >  kernel/cgroup/cgroup-v1.c       |   10 +-
> >  kernel/cgroup/cgroup.c          |  161 ++++++++++++++++------------------------
> >  3 files changed, 135 insertions(+), 105 deletions(-)
> > 
> 
> Acked-by: Zefan Li <lizefan@huawei.com>

Applied to cgroup/for-4.11.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web