Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1557165 > unrolled thread
| Started by | Bogdan Purcareata <bogdan.purcareata@gmail.com> |
|---|---|
| First post | 2017-01-12 09:00 +0100 |
| Last post | 2017-01-12 22:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/4] staging: android/ion: Fix line over 80 characters Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 09:00 +0100
Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-12 10:40 +0100
Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-01-12 11:00 +0100
Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 22:50 +0100
| From | Bogdan Purcareata <bogdan.purcareata@gmail.com> |
|---|---|
| Date | 2017-01-12 09:00 +0100 |
| Subject | [PATCH 1/4] staging: android/ion: Fix line over 80 characters |
| Message-ID | <sYIsF-1h1-7@gated-at.bofh.it> |
Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
drivers/staging/android/ion/ion-ioctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c
index 7e7431d..e28fffb 100644
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging/android/ion/ion-ioctl.c
@@ -111,7 +111,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
struct ion_handle *handle;
mutex_lock(&client->lock);
- handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
+ handle = ion_handle_get_by_id_nolock(client,
+ data.handle.handle);
if (IS_ERR(handle)) {
mutex_unlock(&client->lock);
return PTR_ERR(handle);
--
2.7.4
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-01-12 10:40 +0100 |
| Message-ID | <sYK1r-2hi-11@gated-at.bofh.it> |
| In reply to | #1557165 |
On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com> All staging patches need a changelog, no matter how trivial. > --- > drivers/staging/android/ion/ion-ioctl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c > index 7e7431d..e28fffb 100644 > --- a/drivers/staging/android/ion/ion-ioctl.c > +++ b/drivers/staging/android/ion/ion-ioctl.c > @@ -111,7 +111,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > struct ion_handle *handle; > > mutex_lock(&client->lock); > - handle = ion_handle_get_by_id_nolock(client, data.handle.handle); > + handle = ion_handle_get_by_id_nolock(client, > + data.handle.handle); Please run checkpatch.pl over your patches before sending them. :P regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-01-12 11:00 +0100 |
| Message-ID | <sYKkO-2oa-37@gated-at.bofh.it> |
| In reply to | #1557239 |
On Thu, Jan 12, 2017 at 12:32:26PM +0300, Dan Carpenter wrote: > On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: > > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com> > > All staging patches need a changelog, no matter how trivial. s/staging//g :)
[toc] | [prev] | [next] | [standalone]
| From | Bogdan Purcareata <bogdan.purcareata@gmail.com> |
|---|---|
| Date | 2017-01-12 22:50 +0100 |
| Message-ID | <sYVpT-DA-15@gated-at.bofh.it> |
| In reply to | #1557265 |
On Thu, Jan 12, 2017 at 11:56 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, Jan 12, 2017 at 12:32:26PM +0300, Dan Carpenter wrote: >> On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: >> > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com> >> >> All staging patches need a changelog, no matter how trivial. > > s/staging//g :) Will send a v2 with the changes. Thank you! Bogdan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web