Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557549 > unrolled thread

[PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Nicholas Mc Guire <hofrat@osadl.org> - 2017-01-12 17:00 +0100
    Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-12 17:30 +0100
      Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Nicholas Mc Guire <der.herr@hofr.at> - 2017-01-12 17:40 +0100

#1557549 — [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem reported by sparse
drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here
  char *pipetype;
        ^
Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m +
CONFIG_USB_DWC2_VERBOSE=y

Patch is against 4.10-rc3 (localversion-next is next-20170112)

 drivers/usb/dwc2/hcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 911c3b3..9f66777 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -4489,8 +4489,8 @@ static void dwc2_dump_urb_info(struct usb_hcd *hcd, struct urb *urb,
 {
 #ifdef VERBOSE_DEBUG
 	struct dwc2_hsotg *hsotg = dwc2_hcd_to_hsotg(hcd);
-	char *pipetype;
-	char *speed;
+	char *pipetype = NULL;
+	char *speed = NULL;
 
 	dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb);
 	dev_vdbg(hsotg->dev, "  Device address: %d\n",
-- 
2.1.4

[toc] | [next] | [standalone]

#1557574

On Thu, Jan 12, 2017 at 04:54:38PM +0100, Nicholas Mc Guire wrote:
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> Problem reported by sparse
> drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
> ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    __dynamic_dev_dbg(&descriptor, dev, fmt, \
>    ^
> drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here
>   char *pipetype;
>         ^
> Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m +
> CONFIG_USB_DWC2_VERBOSE=y

Put the above in the changelog text please, I can't take patches without
any changelog text :(

[toc] | [prev] | [next] | [standalone]

#1557582

On Thu, Jan 12, 2017 at 05:25:00PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 12, 2017 at 04:54:38PM +0100, Nicholas Mc Guire wrote:
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> > Problem reported by sparse
> > drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
> > ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >    __dynamic_dev_dbg(&descriptor, dev, fmt, \
> >    ^
> > drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here
> >   char *pipetype;
> >         ^
> > Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m +
> > CONFIG_USB_DWC2_VERBOSE=y
> 
> Put the above in the changelog text please, I can't take patches without
> any changelog text :(
>
sorry - simply forgot to put that in - just resent as V2

thx!
hofrat 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web