Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557443 > unrolled thread

[PATCH] ASoC: rt5659: declare rt5659_i2c_driver static

Back to article view | Back to linux.kernel

Contents

  [PATCH] ASoC: rt5659: declare rt5659_i2c_driver static Nicholas Mc Guire <hofrat@osadl.org> - 2017-01-12 14:20 +0100

#1557443 — [PATCH] ASoC: rt5659: declare rt5659_i2c_driver static

Declar rt5659_i2c_driver, which is only being passed to
module_i2c_driver(rt5659_i2c_driver), static.

Fixes: commit d3cb2de2479b ("ASoC: rt5659: add rt5659 codec driver")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem found by sparse:
sound/soc/codecs/rt5659.c:4233:19: warning: symbol 'rt5659_i2c_driver' was not declared. Should it be static?

Patch was compile tested with: x86_64_defconfig + CONFIG_COMPILE_TEST=y
SND_SOC=m + SND_SOC_ALL_CODECS=m (implies SND_SOC_RT5659=m)

Patch is aginast 4.10-rc3 (localversion-next is next-20170112)

 sound/soc/codecs/rt5659.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c
index db54550..90b5cc6 100644
--- a/sound/soc/codecs/rt5659.c
+++ b/sound/soc/codecs/rt5659.c
@@ -4230,7 +4230,7 @@ static struct acpi_device_id rt5659_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, rt5659_acpi_match);
 #endif
 
-struct i2c_driver rt5659_i2c_driver = {
+static struct i2c_driver rt5659_i2c_driver = {
 	.driver = {
 		.name = "rt5659",
 		.owner = THIS_MODULE,
-- 
2.1.4

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web