Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553921 > unrolled thread

Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files

Started byJiri Olsa <jolsa@redhat.com>
First post2017-01-08 20:00 +0100
Last post2017-01-12 14:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
    Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json  files Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 14:40 +0100

#1553921 — Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files

FromJiri Olsa <jolsa@redhat.com>
Date2017-01-08 20:00 +0100
SubjectRe: [PATCH 03/11] perf, tools: Add support for parsing uncore json files
Message-ID<sXqRb-1KB-9@gated-at.bofh.it>
On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:

SNIP

>  /*
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 29c254dd7380..8bffe99d8e3f 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -229,11 +229,13 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias,
>  }
>  
>  static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> -				 char *desc, char *val, char *long_desc,
> -				 char *topic)
> +				 char *desc __maybe_unused, char *val,

no need for 'desc' to be __maybe_unused

jirka

[toc] | [next] | [standalone]


#1557453

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2017-01-12 14:40 +0100
Message-ID<sYNLH-4wW-3@gated-at.bofh.it>
In reply to#1553921
Em Sun, Jan 08, 2017 at 07:58:00PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> >  /*
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 29c254dd7380..8bffe99d8e3f 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -229,11 +229,13 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias,
> >  }
> >  
> >  static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> > -				 char *desc, char *val, char *long_desc,
> > -				 char *topic)
> > +				 char *desc __maybe_unused, char *val,
> 
> no need for 'desc' to be __maybe_unused

I'll check and remove it...

- Arnaldo

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web