Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1555622 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-01-10 16:40 +0100 |
| Last post | 2017-01-10 18:10 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Arnd Bergmann <arnd@arndb.de> - 2017-01-10 16:40 +0100
Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Mark Brown <broonie@kernel.org> - 2017-01-10 17:50 +0100
Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Arnd Bergmann <arnd@arndb.de> - 2017-01-10 17:50 +0100
Re: [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h Mark Brown <broonie@kernel.org> - 2017-01-10 18:10 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-01-10 16:40 +0100 |
| Subject | [PATCH] ASoC: tm2_wm5110: include gpio/consumer.h |
| Message-ID | <sY6GJ-36e-7@gated-at.bofh.it> |
gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that
is not always included implicitly, so we have to include both
gpio.h and gpio/consumer.h here:
sound/soc/samsung/tm2_wm5110.c: In function 'tm2_mic_bias':
sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration of function 'gpiod_set_value_cansleep';did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/samsung/tm2_wm5110.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
index 5cdf7d19b87f..24cc9d63ce87 100644
--- a/sound/soc/samsung/tm2_wm5110.c
+++ b/sound/soc/samsung/tm2_wm5110.c
@@ -12,6 +12,7 @@
#include <linux/clk.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of.h>
#include <sound/pcm_params.h>
--
2.9.0
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-01-10 17:50 +0100 |
| Message-ID | <sY7Mt-3II-3@gated-at.bofh.it> |
| In reply to | #1555622 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Jan 10, 2017 at 04:30:50PM +0100, Arnd Bergmann wrote: > gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that > is not always included implicitly, so we have to include both > gpio.h and gpio/consumer.h here: This doesn't apply against current code, it looks like someone already made the same change.
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-01-10 17:50 +0100 |
| Message-ID | <sY7Mu-3II-41@gated-at.bofh.it> |
| In reply to | #1555689 |
On Tue, Jan 10, 2017 at 5:40 PM, Mark Brown <broonie@kernel.org> wrote:
> This doesn't apply against current code, it looks like someone already
> made the same change.Ok, I was sending out m
y final set of patches that I found build-testing v4.10-rc, which
still needs the change,
and have moved on to linux-next testing now.
In case you have queued up that change for v4.11 but not also v4.10,
maybe move it into the fixes branch.
Arnd
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-01-10 18:10 +0100 |
| Message-ID | <sY85Q-44s-25@gated-at.bofh.it> |
| In reply to | #1555696 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Jan 10, 2017 at 05:48:06PM +0100, Arnd Bergmann wrote: > In case you have queued up that change for v4.11 but not also v4.10, > maybe move it into the fixes branch. There's a merge in there as well.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web