Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553939 > unrolled thread

[PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show()

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-01-08 22:50 +0100
Last post2017-01-10 09:50 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-08 22:50 +0100
    Re: [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() Linus Walleij <linus.walleij@linaro.org> - 2017-01-09 19:40 +0100
    Re: [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-10 09:50 +0100

#1553939 — [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-01-08 22:50 +0100
Subject[PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show()
Message-ID<sXtvH-3AV-9@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 8 Jan 2017 19:48:28 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: Prefer seq_puts to seq_printf

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/mmc/core/mmc_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index 2f838a13a904..848f4f30e343 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -3163,7 +3163,7 @@ static int mtf_testlist_show(struct seq_file *sf, void *data)
 
 	mutex_lock(&mmc_test_lock);
 
-	seq_printf(sf, "0:\tRun all tests\n");
+	seq_puts(sf, "0:\tRun all tests\n");
 	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
 		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);
 
-- 
2.11.0

[toc] | [next] | [standalone]


#1554593

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-01-09 19:40 +0100
Message-ID<sXN1o-7G5-13@gated-at.bofh.it>
In reply to#1553939
On Sun, Jan 8, 2017 at 10:45 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 19:48:28 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Prefer seq_puts to seq_printf
>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]


#1555044

FromShawn Lin <shawn.lin@rock-chips.com>
Date2017-01-10 09:50 +0100
Message-ID<sY0hX-7uT-1@gated-at.bofh.it>
In reply to#1553939
On 2017/1/9 5:45, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 19:48:28 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Prefer seq_puts to seq_printf

it saves some lock time,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 2f838a13a904..848f4f30e343 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3163,7 +3163,7 @@ static int mtf_testlist_show(struct seq_file *sf, void *data)
>
>  	mutex_lock(&mmc_test_lock);
>
> -	seq_printf(sf, "0:\tRun all tests\n");
> +	seq_puts(sf, "0:\tRun all tests\n");
>  	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
>  		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);
>
>


-- 
Best Regards
Shawn Lin

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web