Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553879 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2017-01-08 15:00 +0100 |
| Last post | 2017-01-08 17:30 +0100 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: cpsw: remove dual check from common res usage function Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-01-08 15:00 +0100
Re: [PATCH] net: ethernet: ti: cpsw: remove dual check from common res usage function Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-01-08 17:30 +0100
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2017-01-08 15:00 +0100 |
| Subject | [PATCH] net: ethernet: ti: cpsw: remove dual check from common res usage function |
| Message-ID | <sXmaR-76f-17@gated-at.bofh.it> |
Common res usage is possible only in case an interface is running. In case of not dual emac here can be only one interface, so while ndo_open and switch mode, only one interface can be opened, thus if open is called no any interface is running ... and no common res are used. So remove check on dual emac, it will simplify code/understanding and will match the name it's called. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- Based on linux-next/master drivers/net/ethernet/ti/cpsw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index b203143..91684f1 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1235,9 +1235,6 @@ static int cpsw_common_res_usage_state(struct cpsw_common *cpsw) u32 i; u32 usage_count = 0; - if (!cpsw->data.dual_emac) - return 0; - for (i = 0; i < cpsw->data.slaves; i++) if (cpsw->slaves[i].open_stat) usage_count++; -- 2.7.4
[toc] | [next] | [standalone]
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2017-01-08 17:30 +0100 |
| Subject | Re: [PATCH] net: ethernet: ti: cpsw: remove dual check from common res usage function |
| Message-ID | <sXow2-gY-21@gated-at.bofh.it> |
| In reply to | #1553879 |
Please ignore it, I've included it in new series On Sun, Jan 08, 2017 at 03:56:27PM +0200, Ivan Khoronzhuk wrote: > Common res usage is possible only in case an interface is > running. In case of not dual emac here can be only one interface, > so while ndo_open and switch mode, only one interface can be opened, > thus if open is called no any interface is running ... and no common > res are used. So remove check on dual emac, it will simplify > code/understanding and will match the name it's called. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > > Based on linux-next/master > > drivers/net/ethernet/ti/cpsw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index b203143..91684f1 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -1235,9 +1235,6 @@ static int cpsw_common_res_usage_state(struct cpsw_common *cpsw) > u32 i; > u32 usage_count = 0; > > - if (!cpsw->data.dual_emac) > - return 0; > - > for (i = 0; i < cpsw->data.slaves; i++) > if (cpsw->slaves[i].open_stat) > usage_count++; > -- > 2.7.4 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web