Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553813 > unrolled thread
| Started by | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| First post | 2017-01-08 10:50 +0100 |
| Last post | 2017-01-08 10:50 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent Jonathan Cameron <jic23@kernel.org> - 2017-01-08 10:50 +0100
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-01-08 10:50 +0100 |
| Subject | Re: [PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent |
| Message-ID | <sXigV-4z0-19@gated-at.bofh.it> |
On 04/12/16 02:19, Brian Masney wrote:
> The alignment of the #defines at the top of the file is not consistent.
> This changes all of the defines to use consistent alignment to improve
> the code readability.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Skipped patch 4 for now, but this one still applies fine so applied to the
togreg branch of iio.git.
Will push out as testing later.
> ---
> drivers/staging/iio/light/isl29028.c | 42 ++++++++++++++++++------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e96a8cb..d5b069e 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -27,38 +27,38 @@
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
>
> -#define ISL29028_CONV_TIME_MS 100
> +#define ISL29028_CONV_TIME_MS 100
>
> -#define ISL29028_REG_CONFIGURE 0x01
> +#define ISL29028_REG_CONFIGURE 0x01
>
> -#define ISL29028_CONF_ALS_IR_MODE_ALS 0
> -#define ISL29028_CONF_ALS_IR_MODE_IR BIT(0)
> -#define ISL29028_CONF_ALS_IR_MODE_MASK BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_ALS 0
> +#define ISL29028_CONF_ALS_IR_MODE_IR BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_MASK BIT(0)
>
> -#define ISL29028_CONF_ALS_RANGE_LOW_LUX 0
> +#define ISL29028_CONF_ALS_RANGE_LOW_LUX 0
> #define ISL29028_CONF_ALS_RANGE_HIGH_LUX BIT(1)
> -#define ISL29028_CONF_ALS_RANGE_MASK BIT(1)
> +#define ISL29028_CONF_ALS_RANGE_MASK BIT(1)
>
> -#define ISL29028_CONF_ALS_DIS 0
> -#define ISL29028_CONF_ALS_EN BIT(2)
> -#define ISL29028_CONF_ALS_EN_MASK BIT(2)
> +#define ISL29028_CONF_ALS_DIS 0
> +#define ISL29028_CONF_ALS_EN BIT(2)
> +#define ISL29028_CONF_ALS_EN_MASK BIT(2)
>
> -#define ISL29028_CONF_PROX_SLP_SH 4
> -#define ISL29028_CONF_PROX_SLP_MASK (7 << ISL29028_CONF_PROX_SLP_SH)
> +#define ISL29028_CONF_PROX_SLP_SH 4
> +#define ISL29028_CONF_PROX_SLP_MASK (7 << ISL29028_CONF_PROX_SLP_SH)
>
> -#define ISL29028_CONF_PROX_EN BIT(7)
> -#define ISL29028_CONF_PROX_EN_MASK BIT(7)
> +#define ISL29028_CONF_PROX_EN BIT(7)
> +#define ISL29028_CONF_PROX_EN_MASK BIT(7)
>
> -#define ISL29028_REG_INTERRUPT 0x02
> +#define ISL29028_REG_INTERRUPT 0x02
>
> -#define ISL29028_REG_PROX_DATA 0x08
> -#define ISL29028_REG_ALSIR_L 0x09
> -#define ISL29028_REG_ALSIR_U 0x0A
> +#define ISL29028_REG_PROX_DATA 0x08
> +#define ISL29028_REG_ALSIR_L 0x09
> +#define ISL29028_REG_ALSIR_U 0x0A
>
> -#define ISL29028_REG_TEST1_MODE 0x0E
> -#define ISL29028_REG_TEST2_MODE 0x0F
> +#define ISL29028_REG_TEST1_MODE 0x0E
> +#define ISL29028_REG_TEST2_MODE 0x0F
>
> -#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1)
> +#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1)
>
> enum isl29028_als_ir_mode {
> ISL29028_MODE_NONE = 0,
>
Back to top | Article view | linux.kernel
csiph-web