Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1554896 > unrolled thread

linux-next: build warning after merge of the rtc tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-01-10 04:10 +0100
Last post2017-01-10 12:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build warning after merge of the rtc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-01-10 04:10 +0100
    Re: linux-next: build warning after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-10 12:00 +0100

#1554896 — linux-next: build warning after merge of the rtc tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-01-10 04:10 +0100
Subjectlinux-next: build warning after merge of the rtc tree
Message-ID<sXUYV-4ej-15@gated-at.bofh.it>
Hi Alexandre,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa':
drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return rtc->val_to_freq[index_max].value;
                         ^

Introduced by commit

  61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation")

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1555150

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-01-10 12:00 +0100
Message-ID<sY2jL-he-17@gated-at.bofh.it>
In reply to#1554896
Hi,

On 10/01/2017 at 14:01:00 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa':
> drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return rtc->val_to_freq[index_max].value;
>                          ^
> 
> Introduced by commit
> 
>   61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation")

This is definitively a false positive, is it worth fixing it?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web