Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553763 > unrolled thread
| Started by | "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> |
|---|---|
| First post | 2017-01-08 00:40 +0100 |
| Last post | 2017-01-10 15:00 +0100 |
| Articles | 19 on this page of 39 — 7 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2017-01-08 00:40 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-08 01:10 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-08 01:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-08 01:40 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-08 02:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-08 02:10 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-08 02:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-08 03:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-08 14:10 +0100
RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-09 03:00 +0100
RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-09 03:40 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-09 10:40 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-09 23:20 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-09 23:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 00:20 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-10 00:20 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 00:40 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-10 00:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-10 01:00 +0100
RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-10 01:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-10 02:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 03:30 +0100
RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-10 06:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 07:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-11 10:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-11 11:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-11 11:10 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-11 11:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-10 10:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-11 04:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-11 10:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 01:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-10 00:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-10 01:30 +0100
RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-09 06:30 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Jörg Rödel <joro@8bytes.org> - 2017-01-09 12:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-09 23:50 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Borislav Petkov <bp@alien8.de> - 2017-01-10 00:00 +0100
Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Jörg Rödel <joro@8bytes.org> - 2017-01-10 15:00 +0100
Page 2 of 2 — ← Prev page 1 [2]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2017-01-10 02:30 +0100 |
| Message-ID | <sXTq9-36u-1@gated-at.bofh.it> |
| In reply to | #1554810 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Jan 10, 2017 at 12:52 AM, Borislav Petkov <bp@alien8.de> wrote: > On Tue, Jan 10, 2017 at 12:40:39AM +0100, Borislav Petkov wrote: >> Lemme run it. > > Well, it boots but I get: > > [ 0.291447] ------------[ cut here ]------------ > [ 0.291702] WARNING: CPU: 0 PID: 1 at kernel/rcu/tree.c:3993 rcu_scheduler_starting+0x5c/0x70 > [ 0.292107] Modules linked in: > [ 0.292277] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3+ #21 > [ 0.292540] Hardware name: HP HP EliteBook 745 G3/807E, BIOS N73 Ver. 01.08 01/28/2016 > [ 0.292893] Call Trace: > [ 0.293072] ? dump_stack+0x46/0x63 > [ 0.293285] ? __warn+0xec/0x110 > [ 0.293487] ? rcu_scheduler_starting+0x5c/0x70 > [ 0.293735] ? kernel_init_freeable+0x58/0x19a > [ 0.293976] ? rest_init+0x80/0x80 > [ 0.294153] ? kernel_init+0xa/0x100 > [ 0.294334] ? ret_from_fork+0x22/0x30 > [ 0.294525] ---[ end trace 4c0fe009ed4dc740 ]--- > > TBH, I like Rafael's suggestion in the other mail to stick with fixing > this in ACPI, especially this is an ACPI problem, not RCU. Well, > more or less: RCU could be taught to *not* do schedule_work() if > workqueue_init() hasn't happened yet but that's a tangential. > > So, I'm going to bed. When I wake up, I want to see working fixes! > > :-))) Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv worked, the attached one should work too (please test), but it can be justified in a slightly more convincing way. Namely, the idea is that acpi_os_read/write_memory() should never be used before invoking acpi_os_initialize() and since those are the only places where the list of memory regions is walked under RCU without extra locking, it is safe to skip the RCU synchronization until that happens. Thanks, Rafael
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-10 03:30 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXUmd-3ID-9@gated-at.bofh.it> |
| In reply to | #1554851 |
On Tue, Jan 10, 2017 at 02:27:16AM +0100, Rafael J. Wysocki wrote:
> On Tue, Jan 10, 2017 at 12:52 AM, Borislav Petkov <bp@alien8.de> wrote:
> > On Tue, Jan 10, 2017 at 12:40:39AM +0100, Borislav Petkov wrote:
> >> Lemme run it.
> >
> > Well, it boots but I get:
> >
> > [ 0.291447] ------------[ cut here ]------------
> > [ 0.291702] WARNING: CPU: 0 PID: 1 at kernel/rcu/tree.c:3993 rcu_scheduler_starting+0x5c/0x70
> > [ 0.292107] Modules linked in:
> > [ 0.292277] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3+ #21
> > [ 0.292540] Hardware name: HP HP EliteBook 745 G3/807E, BIOS N73 Ver. 01.08 01/28/2016
> > [ 0.292893] Call Trace:
> > [ 0.293072] ? dump_stack+0x46/0x63
> > [ 0.293285] ? __warn+0xec/0x110
> > [ 0.293487] ? rcu_scheduler_starting+0x5c/0x70
> > [ 0.293735] ? kernel_init_freeable+0x58/0x19a
> > [ 0.293976] ? rest_init+0x80/0x80
> > [ 0.294153] ? kernel_init+0xa/0x100
> > [ 0.294334] ? ret_from_fork+0x22/0x30
> > [ 0.294525] ---[ end trace 4c0fe009ed4dc740 ]---
> >
> > TBH, I like Rafael's suggestion in the other mail to stick with fixing
> > this in ACPI, especially this is an ACPI problem, not RCU. Well,
> > more or less: RCU could be taught to *not* do schedule_work() if
> > workqueue_init() hasn't happened yet but that's a tangential.
> >
> > So, I'm going to bed. When I wake up, I want to see working fixes!
> >
> > :-)))
>
> Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv
> worked, the attached one should work too (please test), but it can be
> justified in a slightly more convincing way.
>
> Namely, the idea is that acpi_os_read/write_memory() should never be
> used before invoking acpi_os_initialize() and since those are the only
> places where the list of memory regions is walked under RCU without
> extra locking, it is safe to skip the RCU synchronization until that
> happens.
>
> Thanks,
> Rafael
Makes sense to me!
It looks like I can make the grace-period-free boot-time window
for CONFIG_PREEMPT=y kernels quite a bit narrower, but it does not
look like something suitable for jamming into 4.10.
Thanx, Paul
> ---
> drivers/acpi/osl.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/osl.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/osl.c
> +++ linux-pm/drivers/acpi/osl.c
> @@ -378,7 +378,9 @@ static void acpi_os_drop_map_ref(struct
> static void acpi_os_map_cleanup(struct acpi_ioremap *map)
> {
> if (!map->refcount) {
> - synchronize_rcu_expedited();
> + if (acpi_os_initialized)
> + synchronize_rcu_expedited();
> +
> acpi_unmap(map->phys, map->virt);
> kfree(map);
> }
> @@ -671,6 +673,8 @@ acpi_os_read_memory(acpi_physical_addres
> bool unmap = false;
> u64 dummy;
>
> + WARN_ON_ONCE(!acpi_os_initialized);
> +
> rcu_read_lock();
> virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> if (!virt_addr) {
> @@ -716,6 +720,8 @@ acpi_os_write_memory(acpi_physical_addre
> unsigned int size = width / 8;
> bool unmap = false;
>
> + WARN_ON_ONCE(!acpi_os_initialized);
> +
> rcu_read_lock();
> virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> if (!virt_addr) {
[toc] | [prev] | [next] | [standalone]
| From | "Zheng, Lv" <lv.zheng@intel.com> |
|---|---|
| Date | 2017-01-10 06:50 +0100 |
| Subject | RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXXtL-5Ph-5@gated-at.bofh.it> |
| In reply to | #1554884 |
Hi, Rafael and Paul
> From: Paul E. McKenney [mailto:paulmck@linux.vnet.ibm.com]
> Subject: Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and
> early_acpi_os_unmap_memory() from Linux kernel
>
> On Tue, Jan 10, 2017 at 02:27:16AM +0100, Rafael J. Wysocki wrote:
> > On Tue, Jan 10, 2017 at 12:52 AM, Borislav Petkov <bp@alien8.de> wrote:
> > > On Tue, Jan 10, 2017 at 12:40:39AM +0100, Borislav Petkov wrote:
> > >> Lemme run it.
> > >
> > > Well, it boots but I get:
> > >
> > > [ 0.291447] ------------[ cut here ]------------
> > > [ 0.291702] WARNING: CPU: 0 PID: 1 at kernel/rcu/tree.c:3993 rcu_scheduler_starting+0x5c/0x70
> > > [ 0.292107] Modules linked in:
> > > [ 0.292277] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3+ #21
> > > [ 0.292540] Hardware name: HP HP EliteBook 745 G3/807E, BIOS N73 Ver. 01.08 01/28/2016
> > > [ 0.292893] Call Trace:
> > > [ 0.293072] ? dump_stack+0x46/0x63
> > > [ 0.293285] ? __warn+0xec/0x110
> > > [ 0.293487] ? rcu_scheduler_starting+0x5c/0x70
> > > [ 0.293735] ? kernel_init_freeable+0x58/0x19a
> > > [ 0.293976] ? rest_init+0x80/0x80
> > > [ 0.294153] ? kernel_init+0xa/0x100
> > > [ 0.294334] ? ret_from_fork+0x22/0x30
> > > [ 0.294525] ---[ end trace 4c0fe009ed4dc740 ]---
> > >
> > > TBH, I like Rafael's suggestion in the other mail to stick with fixing
> > > this in ACPI, especially this is an ACPI problem, not RCU. Well,
> > > more or less: RCU could be taught to *not* do schedule_work() if
> > > workqueue_init() hasn't happened yet but that's a tangential.
> > >
> > > So, I'm going to bed. When I wake up, I want to see working fixes!
> > >
> > > :-)))
> >
> > Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv
> > worked, the attached one should work too (please test), but it can be
> > justified in a slightly more convincing way.
> >
> > Namely, the idea is that acpi_os_read/write_memory() should never be
> > used before invoking acpi_os_initialize() and since those are the only
> > places where the list of memory regions is walked under RCU without
> > extra locking, it is safe to skip the RCU synchronization until that
> > happens.
> >
> > Thanks,
> > Rafael
>
> Makes sense to me!
Also looks good to me.
>
> It looks like I can make the grace-period-free boot-time window
> for CONFIG_PREEMPT=y kernels quite a bit narrower, but it does not
> look like something suitable for jamming into 4.10.
OK, we can have this fixed in ACPI layer first.
Thanks
Lv
>
> Thanx, Paul
>
> > ---
> > drivers/acpi/osl.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > Index: linux-pm/drivers/acpi/osl.c
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/osl.c
> > +++ linux-pm/drivers/acpi/osl.c
> > @@ -378,7 +378,9 @@ static void acpi_os_drop_map_ref(struct
> > static void acpi_os_map_cleanup(struct acpi_ioremap *map)
> > {
> > if (!map->refcount) {
> > - synchronize_rcu_expedited();
> > + if (acpi_os_initialized)
> > + synchronize_rcu_expedited();
> > +
> > acpi_unmap(map->phys, map->virt);
> > kfree(map);
> > }
> > @@ -671,6 +673,8 @@ acpi_os_read_memory(acpi_physical_addres
> > bool unmap = false;
> > u64 dummy;
> >
> > + WARN_ON_ONCE(!acpi_os_initialized);
> > +
> > rcu_read_lock();
> > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > if (!virt_addr) {
> > @@ -716,6 +720,8 @@ acpi_os_write_memory(acpi_physical_addre
> > unsigned int size = width / 8;
> > bool unmap = false;
> >
> > + WARN_ON_ONCE(!acpi_os_initialized);
> > +
> > rcu_read_lock();
> > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > if (!virt_addr) {
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-10 07:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXXDs-5Ss-9@gated-at.bofh.it> |
| In reply to | #1554961 |
On Tue, Jan 10, 2017 at 05:41:45AM +0000, Zheng, Lv wrote:
> Hi, Rafael and Paul
>
> > From: Paul E. McKenney [mailto:paulmck@linux.vnet.ibm.com]
> > Subject: Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and
> > early_acpi_os_unmap_memory() from Linux kernel
> >
> > On Tue, Jan 10, 2017 at 02:27:16AM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Jan 10, 2017 at 12:52 AM, Borislav Petkov <bp@alien8.de> wrote:
> > > > On Tue, Jan 10, 2017 at 12:40:39AM +0100, Borislav Petkov wrote:
> > > >> Lemme run it.
> > > >
> > > > Well, it boots but I get:
> > > >
> > > > [ 0.291447] ------------[ cut here ]------------
> > > > [ 0.291702] WARNING: CPU: 0 PID: 1 at kernel/rcu/tree.c:3993 rcu_scheduler_starting+0x5c/0x70
> > > > [ 0.292107] Modules linked in:
> > > > [ 0.292277] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3+ #21
> > > > [ 0.292540] Hardware name: HP HP EliteBook 745 G3/807E, BIOS N73 Ver. 01.08 01/28/2016
> > > > [ 0.292893] Call Trace:
> > > > [ 0.293072] ? dump_stack+0x46/0x63
> > > > [ 0.293285] ? __warn+0xec/0x110
> > > > [ 0.293487] ? rcu_scheduler_starting+0x5c/0x70
> > > > [ 0.293735] ? kernel_init_freeable+0x58/0x19a
> > > > [ 0.293976] ? rest_init+0x80/0x80
> > > > [ 0.294153] ? kernel_init+0xa/0x100
> > > > [ 0.294334] ? ret_from_fork+0x22/0x30
> > > > [ 0.294525] ---[ end trace 4c0fe009ed4dc740 ]---
> > > >
> > > > TBH, I like Rafael's suggestion in the other mail to stick with fixing
> > > > this in ACPI, especially this is an ACPI problem, not RCU. Well,
> > > > more or less: RCU could be taught to *not* do schedule_work() if
> > > > workqueue_init() hasn't happened yet but that's a tangential.
> > > >
> > > > So, I'm going to bed. When I wake up, I want to see working fixes!
> > > >
> > > > :-)))
> > >
> > > Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv
> > > worked, the attached one should work too (please test), but it can be
> > > justified in a slightly more convincing way.
> > >
> > > Namely, the idea is that acpi_os_read/write_memory() should never be
> > > used before invoking acpi_os_initialize() and since those are the only
> > > places where the list of memory regions is walked under RCU without
> > > extra locking, it is safe to skip the RCU synchronization until that
> > > happens.
> > >
> > > Thanks,
> > > Rafael
> >
> > Makes sense to me!
>
> Also looks good to me.
>
> >
> > It looks like I can make the grace-period-free boot-time window
> > for CONFIG_PREEMPT=y kernels quite a bit narrower, but it does not
> > look like something suitable for jamming into 4.10.
>
> OK, we can have this fixed in ACPI layer first.
Definitely.
I have the RCU changes written in ink on paper and they definitely are
-not- something that goes into 4.10. 4.11 at the earliest, and if no
one asks for it in 4.11, it goes into 4.12. Serious testing needed. ;-)
Thanx, Paul
> Thanks
> Lv
>
> >
> > Thanx, Paul
> >
> > > ---
> > > drivers/acpi/osl.c | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > Index: linux-pm/drivers/acpi/osl.c
> > > ===================================================================
> > > --- linux-pm.orig/drivers/acpi/osl.c
> > > +++ linux-pm/drivers/acpi/osl.c
> > > @@ -378,7 +378,9 @@ static void acpi_os_drop_map_ref(struct
> > > static void acpi_os_map_cleanup(struct acpi_ioremap *map)
> > > {
> > > if (!map->refcount) {
> > > - synchronize_rcu_expedited();
> > > + if (acpi_os_initialized)
> > > + synchronize_rcu_expedited();
> > > +
> > > acpi_unmap(map->phys, map->virt);
> > > kfree(map);
> > > }
> > > @@ -671,6 +673,8 @@ acpi_os_read_memory(acpi_physical_addres
> > > bool unmap = false;
> > > u64 dummy;
> > >
> > > + WARN_ON_ONCE(!acpi_os_initialized);
> > > +
> > > rcu_read_lock();
> > > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > > if (!virt_addr) {
> > > @@ -716,6 +720,8 @@ acpi_os_write_memory(acpi_physical_addre
> > > unsigned int size = width / 8;
> > > bool unmap = false;
> > >
> > > + WARN_ON_ONCE(!acpi_os_initialized);
> > > +
> > > rcu_read_lock();
> > > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > > if (!virt_addr) {
>
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-01-11 10:30 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sYnoe-59d-11@gated-at.bofh.it> |
| In reply to | #1554967 |
On Mon, Jan 09, 2017 at 09:51:29PM -0800, Paul E. McKenney wrote:
> Definitely.
Btw, we have more breakage from RCU expedited using workqueues:
https://bugzilla.kernel.org/show_bug.cgi?id=192111
I've added you to CC but let me have other bug reporters confirm reverting
8b355e3bc140 ("rcu: Drive expedited grace periods from workqueue")
does fix the issue for them too.
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-11 11:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sYnRf-5iP-15@gated-at.bofh.it> |
| In reply to | #1556317 |
On Wed, Jan 11, 2017 at 10:21:06AM +0100, Borislav Petkov wrote:
> On Mon, Jan 09, 2017 at 09:51:29PM -0800, Paul E. McKenney wrote:
> > Definitely.
>
> Btw, we have more breakage from RCU expedited using workqueues:
> https://bugzilla.kernel.org/show_bug.cgi?id=192111
>
> I've added you to CC but let me have other bug reporters confirm reverting
>
> 8b355e3bc140 ("rcu: Drive expedited grace periods from workqueue")
>
> does fix the issue for them too.
Yes, you could make RCU expedited grace periods go back to using the
requesting task, and that would allow expedited grace periods to run early
in the boot process. But that causes problems with signals and the like
unless you revert a few other patches. The bugzilla is interesting --
it looks like ACPI was in some cases doing early-boot grace-period waits
some time back?
I have a limping prototype RCU patch that should avoid this problem.
If all goes well, I will send it out late tomorrow evening, Pacific Time.
Thanx, Paul
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-01-11 11:10 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sYo0V-5B1-5@gated-at.bofh.it> |
| In reply to | #1556349 |
On Wed, Jan 11, 2017 at 01:51:56AM -0800, Paul E. McKenney wrote:
> Yes, you could make RCU expedited grace periods go back to using the
> requesting task, and that would allow expedited grace periods to run early
> in the boot process. But that causes problems with signals and the like
> unless you revert a few other patches. The bugzilla is interesting --
> it looks like ACPI was in some cases doing early-boot grace-period waits
> some time back?
I think this and https://bugzilla.suse.com/show_bug.cgi?id=1017783 is an
example of a bunch of toshiba schlaptops which cause the issue. So it
looks like ACPI is doing something very early on those which tickles the
issue to happen.
But this is ACPI - anything can happen!
> I have a limping prototype RCU patch that should avoid this problem.
>
> If all goes well, I will send it out late tomorrow evening, Pacific Time.
Attach it to the bugzilla too, pls, because the people there trigger the
issue.
I have the respective(?) SUSE bug and I can ask people there to run it
too.
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-11 11:30 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sYokh-5Hu-9@gated-at.bofh.it> |
| In reply to | #1556355 |
On Wed, Jan 11, 2017 at 11:03:23AM +0100, Borislav Petkov wrote: > On Wed, Jan 11, 2017 at 01:51:56AM -0800, Paul E. McKenney wrote: > > Yes, you could make RCU expedited grace periods go back to using the > > requesting task, and that would allow expedited grace periods to run early > > in the boot process. But that causes problems with signals and the like > > unless you revert a few other patches. The bugzilla is interesting -- > > it looks like ACPI was in some cases doing early-boot grace-period waits > > some time back? > > I think this and https://bugzilla.suse.com/show_bug.cgi?id=1017783 is an > example of a bunch of toshiba schlaptops which cause the issue. So it > looks like ACPI is doing something very early on those which tickles the > issue to happen. > > But this is ACPI - anything can happen! ;-) ;-) ;-) > > I have a limping prototype RCU patch that should avoid this problem. > > > > If all goes well, I will send it out late tomorrow evening, Pacific Time. > > Attach it to the bugzilla too, pls, because the people there trigger the > issue. > > I have the respective(?) SUSE bug and I can ask people there to run it > too. That would be very good! Thinking good thoughts for the ongoing tests... Thanx, Paul
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-01-10 10:50 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sY1e1-85W-9@gated-at.bofh.it> |
| In reply to | #1554851 |
On Tue, Jan 10, 2017 at 02:27:16AM +0100, Rafael J. Wysocki wrote:
> Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv
> worked, the attached one should work too (please test), but it can be
> justified in a slightly more convincing way.
No workie:
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 57fb5f4..acb6118 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -378,7 +378,11 @@ static void acpi_os_drop_map_ref(struct acpi_ioremap *map)
static void acpi_os_map_cleanup(struct acpi_ioremap *map)
{
if (!map->refcount) {
- synchronize_rcu_expedited();
+ if (acpi_os_initialized) {
+ pr_err("%s: acpi_os_initialized\n", __func__);
+ synchronize_rcu_expedited();
+ }
+
acpi_unmap(map->phys, map->virt);
kfree(map);
}
The pr_err() gets issued before the box hangs.
Lv's version which set the bool in acpi_os_map_generic_address() did
work though.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2017-01-11 04:50 +0100 |
| Message-ID | <sYi5b-1Ft-1@gated-at.bofh.it> |
| In reply to | #1555095 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Jan 10, 2017 at 10:41 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Jan 10, 2017 at 02:27:16AM +0100, Rafael J. Wysocki wrote:
>> Well, if the https://patchwork.kernel.org/patch/9504277/ patch from Lv
>> worked, the attached one should work too (please test), but it can be
>> justified in a slightly more convincing way.
>
> No workie:
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 57fb5f4..acb6118 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -378,7 +378,11 @@ static void acpi_os_drop_map_ref(struct acpi_ioremap *map)
> static void acpi_os_map_cleanup(struct acpi_ioremap *map)
> {
> if (!map->refcount) {
> - synchronize_rcu_expedited();
> + if (acpi_os_initialized) {
> + pr_err("%s: acpi_os_initialized\n", __func__);
> + synchronize_rcu_expedited();
> + }
> +
> acpi_unmap(map->phys, map->virt);
> kfree(map);
> }
>
> The pr_err() gets issued before the box hangs.
>
> Lv's version which set the bool in acpi_os_map_generic_address() did
> work though.
Well, it would if nothing mapped by acpi_os_map_generic_address() was
in the memory address space, for example, but then it would never use
the RCU synchronization as well (not good).
Basically, we need to find a point during the initialization such that
acpi_os_read/write_memory() is not invoked earlier and set a flag in
there.
Let's try the attached one.
BTW, I'm going to travel to the LCA starting tomorrow, so I guess I
will be a bit unresponsive during the next few days.
Thanks,
Rafael
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-01-11 10:50 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sYnHz-5fJ-9@gated-at.bofh.it> |
| In reply to | #1556191 |
On Wed, Jan 11, 2017 at 04:42:16AM +0100, Rafael J. Wysocki wrote:
> Let's try the attached one.
Works, thanks. Lemme give you the tags :)
Reported-and-tested-by: Borislav Petkov <bp@suse.de>
Fixes: 174cc7187e6f ("ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel")
Link: https://lkml.kernel.org/r/4034dde8-ffc1-18e2-f40c-00cf37471793@intel.com
> BTW, I'm going to travel to the LCA starting tomorrow, so I guess I
> will be a bit unresponsive during the next few days.
Sure, we have time. Have a safe trip!
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-10 01:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXS14-29K-17@gated-at.bofh.it> |
| In reply to | #1554806 |
On Tue, Jan 10, 2017 at 12:40:39AM +0100, Borislav Petkov wrote:
> On Mon, Jan 09, 2017 at 03:32:04PM -0800, Paul E. McKenney wrote:
> > We could move rcu_scheduler_starting() later, as long as there
> > is no chance of preemption or context switch before it is invoked.
> > Would that help in this case, or are we already context switching before
> > acpi_os_map_cleanup() is invoked? (If we are already context switching,
> > short-circuiting synchronize_rcu_expedited() would be a bug.)
>
> Hmm, how about the below?
>
> It would still happen before
>
> /*
> * The boot idle thread must execute schedule()
> * at least once to get things moving:
> */
> init_idle_bootup_task(current);
> schedule_preempt_disabled();
>
> in rest_init() and right after native_smp_prepare_cpus() which is where
> we're splatting.
>
> Lemme run it.
>
> Even if it works, we would have to stress-test this seriously...
Yeah, the call to wait_for_completion() at the beginning of
kernel_init_freeable() makes me extremely nervous. Even if it does
happen to work, this looks like an accident waiting to happen.
Is it possible to instead move the ACPI initialization to follow the
workqueue initialization?
Thanx, Paul
> ---
> diff --git a/init/main.c b/init/main.c
> index b0c9d6facef9..9be221cc87c3 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -385,7 +385,6 @@ static noinline void __ref rest_init(void)
> {
> int pid;
>
> - rcu_scheduler_starting();
> /*
> * We need to spawn init first so that it obtains pid 1, however
> * the init task will end up wanting to create kthreads, which, if
> @@ -1019,6 +1018,8 @@ static noinline void __init kernel_init_freeable(void)
>
> smp_prepare_cpus(setup_max_cpus);
>
> + rcu_scheduler_starting();
> +
> workqueue_init();
>
> do_pre_smp_initcalls();
>
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2017-01-10 00:50 +0100 |
| Message-ID | <sXRRn-26v-11@gated-at.bofh.it> |
| In reply to | #1554800 |
On Tue, Jan 10, 2017 at 12:32 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Tue, Jan 10, 2017 at 12:15:01AM +0100, Borislav Petkov wrote:
>> On Mon, Jan 09, 2017 at 02:18:31PM -0800, Paul E. McKenney wrote:
>> > @@ -690,6 +690,8 @@ void synchronize_rcu_expedited(void)
>> > {
>> > struct rcu_state *rsp = rcu_state_p;
>> >
>> > + if (!rcu_scheduler_active)
>> > + return;
>> > _synchronize_rcu_expedited(rsp, sync_rcu_exp_handler);
>> > }
>> > EXPORT_SYMBOL_GPL(synchronize_rcu_expedited);
>>
>> That doesn't work and it is because of those damn what goes before what
>> boot sequence issues :-\
>>
>> We have:
>>
>> rest_init()
>> |-> rcu_scheduler_starting() ---> that sets rcu_scheduler_active = 1;
>> |-> kernel_thread(kernel_init, NULL, CLONE_FS);
>> |-> kernel_init()
>> |-> kernel_init_freeable()
>> |-> native_smp_prepare_cpus(setup_max_cpus)
>> |-> default_setup_apic_routing
>> |-> enable_IR_x2apic
>> |-> irq_remapping_prepare
>> |-> amd_iommu_prepare
>> |-> iommu_go_to_state
>> |-> acpi_put_table(ivrs_base);
>> |-> acpi_tb_put_table(table_desc);
>> |-> acpi_tb_invalidate_table(table_desc);
>> |-> acpi_tb_release_table(...)
>> |-> acpi_os_unmap_memory
>> |-> acpi_os_unmap_iomem
>> |-> acpi_os_map_cleanup
>> |-> synchronize_rcu_expedited()
>>
>> Now here we have rcu_scheduler_active already set so the test doesn't
>> hit and we hang.
>>
>> So we must do it differently.
>
> Yeah, there is a window just as the scheduler is starting where things don't
> work.
>
> We could move rcu_scheduler_starting() later, as long as there
> is no chance of preemption or context switch before it is invoked.
> Would that help in this case, or are we already context switching before
> acpi_os_map_cleanup() is invoked?
In the particular AMD IOMMU case it doesn't look like we are, but we
do in other cases.
> (If we are already context switching,
> short-circuiting synchronize_rcu_expedited() would be a bug.)
It may be easier to make the caller avoid RCU synchronization
altogether if that's not necessary and the caller should actually be
able to figure out when that's the case.
The patch from Lv at https://patchwork.kernel.org/patch/9504277/ goes
in the right direction IMO, but I'm not yet convinced that this is the
right one.
Thanks,
Rafael
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-10 01:30 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXSu5-2ym-11@gated-at.bofh.it> |
| In reply to | #1554807 |
On Tue, Jan 10, 2017 at 12:42:47AM +0100, Rafael J. Wysocki wrote:
> On Tue, Jan 10, 2017 at 12:32 AM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Tue, Jan 10, 2017 at 12:15:01AM +0100, Borislav Petkov wrote:
> >> On Mon, Jan 09, 2017 at 02:18:31PM -0800, Paul E. McKenney wrote:
> >> > @@ -690,6 +690,8 @@ void synchronize_rcu_expedited(void)
> >> > {
> >> > struct rcu_state *rsp = rcu_state_p;
> >> >
> >> > + if (!rcu_scheduler_active)
> >> > + return;
> >> > _synchronize_rcu_expedited(rsp, sync_rcu_exp_handler);
> >> > }
> >> > EXPORT_SYMBOL_GPL(synchronize_rcu_expedited);
> >>
> >> That doesn't work and it is because of those damn what goes before what
> >> boot sequence issues :-\
> >>
> >> We have:
> >>
> >> rest_init()
> >> |-> rcu_scheduler_starting() ---> that sets rcu_scheduler_active = 1;
> >> |-> kernel_thread(kernel_init, NULL, CLONE_FS);
> >> |-> kernel_init()
> >> |-> kernel_init_freeable()
> >> |-> native_smp_prepare_cpus(setup_max_cpus)
> >> |-> default_setup_apic_routing
> >> |-> enable_IR_x2apic
> >> |-> irq_remapping_prepare
> >> |-> amd_iommu_prepare
> >> |-> iommu_go_to_state
> >> |-> acpi_put_table(ivrs_base);
> >> |-> acpi_tb_put_table(table_desc);
> >> |-> acpi_tb_invalidate_table(table_desc);
> >> |-> acpi_tb_release_table(...)
> >> |-> acpi_os_unmap_memory
> >> |-> acpi_os_unmap_iomem
> >> |-> acpi_os_map_cleanup
> >> |-> synchronize_rcu_expedited()
> >>
> >> Now here we have rcu_scheduler_active already set so the test doesn't
> >> hit and we hang.
> >>
> >> So we must do it differently.
> >
> > Yeah, there is a window just as the scheduler is starting where things don't
> > work.
> >
> > We could move rcu_scheduler_starting() later, as long as there
> > is no chance of preemption or context switch before it is invoked.
> > Would that help in this case, or are we already context switching before
> > acpi_os_map_cleanup() is invoked?
>
> In the particular AMD IOMMU case it doesn't look like we are, but we
> do in other cases.
>
> > (If we are already context switching,
> > short-circuiting synchronize_rcu_expedited() would be a bug.)
>
> It may be easier to make the caller avoid RCU synchronization
> altogether if that's not necessary and the caller should actually be
> able to figure out when that's the case.
>
> The patch from Lv at https://patchwork.kernel.org/patch/9504277/ goes
> in the right direction IMO, but I'm not yet convinced that this is the
> right one.
From the RCU end, I could force expedited grace periods to translate to
normal grace periods during that window of time, and then make sure that
RCU's grace-period kthreads are spawned beforehand. Looking into this...
Thanx, Paul
[toc] | [prev] | [next] | [standalone]
| From | "Zheng, Lv" <lv.zheng@intel.com> |
|---|---|
| Date | 2017-01-09 06:30 +0100 |
| Subject | RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXAGR-8n5-5@gated-at.bofh.it> |
| In reply to | #1554008 |
Hi, Borislav
> From: Zheng, Lv
> Subject: RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and
> early_acpi_os_unmap_memory() from Linux kernel
>
> Hi,
>
> > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Zheng,
> > Lv
> > Subject: RE: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and
> > early_acpi_os_unmap_memory() from Linux kernel
> >
> > Hi,
> >
> > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of
> > Borislav
> > > Petkov
> > > Subject: Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and
> > > early_acpi_os_unmap_memory() from Linux kernel
> > >
> > > On Sun, Jan 08, 2017 at 03:20:20AM +0100, Rafael J. Wysocki wrote:
> > > > drivers/iommu/amd_iommu_init.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Index: linux-pm/drivers/iommu/amd_iommu_init.c
> > > > ===================================================================
> > > > --- linux-pm.orig/drivers/iommu/amd_iommu_init.c
> > > > +++ linux-pm/drivers/iommu/amd_iommu_init.c
> > > > @@ -2230,7 +2230,7 @@ static int __init early_amd_iommu_init(v
> > > > */
> > > > ret = check_ivrs_checksum(ivrs_base);
> > > > if (ret)
> > > > - return ret;
> > > > + goto out;
> > > >
> > > > amd_iommu_target_ivhd_type = get_highest_supported_ivhd_type(ivrs_base);
> > > > DUMP_printk("Using IVHD type %#x\n", amd_iommu_target_ivhd_type);
> > >
> > > Good catch, this one needs to be applied regardless.
> > >
> > > However, it doesn't fix my issue though.
> > >
> > > But I think I have it - I went and applied the well-proven debugging
> > > technique of sprinkling printks around. Here's what I'm seeing:
> > >
> > > early_amd_iommu_init()
> > > |-> acpi_put_table(ivrs_base);
> > > |-> acpi_tb_put_table(table_desc);
> > > |-> acpi_tb_invalidate_table(table_desc);
> > > |-> acpi_tb_release_table(...)
> > > |-> acpi_os_unmap_memory
> > > |-> acpi_os_unmap_iomem
> > > |-> acpi_os_map_cleanup
> > > |-> synchronize_rcu_expedited <-- the kernel/rcu/tree_exp.h version with CONFIG_PREEMPT_RCU=y
> > >
> > > Now that function goes and sends IPIs, i.e., schedule_work()
> > > but this is too early - we haven't even done workqueue_init().
> > > Actually, from looking at the callstack, we do
> > > kernel_init_freeable->native_smp_prepare_cpus() and workqueue_init()
> > > comes next.
> > >
> > > And this makes sense because the splat rIP points to __queue_work() but
> > > we haven't done that yet.
> > >
> > > So that acpi_put_table() is happening too early. Looks like AMD IOMMU
> > > should not put the table but WTH do I know?!
> > >
> > > In any case, commenting out:
> > >
> > > acpi_put_table(ivrs_base);
> > > ivrs_base = NULL;
> > >
> > > and the end of early_amd_iommu_init() makes the box boot again.
> >
> > So please help to comment out these 2 lines (with descriptions and do not delete them).
> > Until acpi_os_unmap_memory() is able to handle such an early case.
>
> IMO, synchronize_rcu_expedited() should be improved:
> If rcu_init() isn't called or there is nothing to synchronize, schedule_work() shouldn't be invoked.
Hmm, I think this problem has its history.
In APEI code, NMI handlers cannot utilize spinlock.
So the developers there used RCU to synchronize NMI handlers before the register region is unmapped.
At that time, there might not be pre-map/post-unmap code prepared in the APEI drivers.
So the APEI developers relied on map/unmap logics implemented in the ACPICA register read/write APIs where the OSL map/unmap is invoked.
That's why the RCU code is in acpi_os_xxx().
If:
1. there is map/unmap/read/write operations available for APEI developers to invoke;
2. RCU synchronization is invoked before invoking the last unmap operation;
3. map/unmap/read/write order is strictly ensured inside of the APEI drivers.
Then we can remove RCU stuffs from acpi_os_xxx.
And the root cause of this issue can be fixed.
I'm not sure if this approach is possible, but can give it a try.
Before that I think all such acpi_put_table() should just be commented out.
Thanks and best regards
Lv
>
> Thanks and best regards
> Lv
>
> >
> > Thanks and best regards
> > Lv
> >
> > >
> > > --
> > > Regards/Gruss,
> > > Boris.
> > >
> > > Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | Jörg Rödel <joro@8bytes.org> |
|---|---|
| Date | 2017-01-09 12:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXFQe-37h-17@gated-at.bofh.it> |
| In reply to | #1553785 |
Hi Rafael,
On Sun, Jan 08, 2017 at 03:20:20AM +0100, Rafael J. Wysocki wrote:
> ---
> drivers/iommu/amd_iommu_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pm/drivers/iommu/amd_iommu_init.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/amd_iommu_init.c
> +++ linux-pm/drivers/iommu/amd_iommu_init.c
> @@ -2230,7 +2230,7 @@ static int __init early_amd_iommu_init(v
> */
> ret = check_ivrs_checksum(ivrs_base);
> if (ret)
> - return ret;
> + goto out;
>
> amd_iommu_target_ivhd_type = get_highest_supported_ivhd_type(ivrs_base);
> DUMP_printk("Using IVHD type %#x\n", amd_iommu_target_ivhd_type);
Yeah, good catch. Can you send me a patch for this and I am going to
send the fix upstream asap.
Thanks,
Joerg
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-01-09 23:50 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXQVj-1xL-5@gated-at.bofh.it> |
| In reply to | #1554218 |
On Monday, January 09, 2017 11:52:26 AM Jörg Rödel wrote:
> Hi Rafael,
>
> On Sun, Jan 08, 2017 at 03:20:20AM +0100, Rafael J. Wysocki wrote:
> > ---
> > drivers/iommu/amd_iommu_init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-pm/drivers/iommu/amd_iommu_init.c
> > ===================================================================
> > --- linux-pm.orig/drivers/iommu/amd_iommu_init.c
> > +++ linux-pm/drivers/iommu/amd_iommu_init.c
> > @@ -2230,7 +2230,7 @@ static int __init early_amd_iommu_init(v
> > */
> > ret = check_ivrs_checksum(ivrs_base);
> > if (ret)
> > - return ret;
> > + goto out;
> >
> > amd_iommu_target_ivhd_type = get_highest_supported_ivhd_type(ivrs_base);
> > DUMP_printk("Using IVHD type %#x\n", amd_iommu_target_ivhd_type);
>
> Yeah, good catch. Can you send me a patch for this and I am going to
> send the fix upstream asap.
Please find appended.
Thanks,
Rafael
---
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Subject: [PATCH] IOMMU / AMD: Fix error code path in early_amd_iommu_init()
Prevent early_amd_iommu_init() from leaking memory mapped via
acpi_get_table() if check_ivrs_checksum() returns an error.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/iommu/amd_iommu_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pm/drivers/iommu/amd_iommu_init.c
===================================================================
--- linux-pm.orig/drivers/iommu/amd_iommu_init.c
+++ linux-pm/drivers/iommu/amd_iommu_init.c
@@ -2230,7 +2230,7 @@ static int __init early_amd_iommu_init(v
*/
ret = check_ivrs_checksum(ivrs_base);
if (ret)
- return ret;
+ goto out;
amd_iommu_target_ivhd_type = get_highest_supported_ivhd_type(ivrs_base);
DUMP_printk("Using IVHD type %#x\n", amd_iommu_target_ivhd_type);
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-01-10 00:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sXR4Z-1Bl-9@gated-at.bofh.it> |
| In reply to | #1554774 |
On Mon, Jan 09, 2017 at 11:41:15PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Subject: [PATCH] IOMMU / AMD: Fix error code path in early_amd_iommu_init()
>
> Prevent early_amd_iommu_init() from leaking memory mapped via
> acpi_get_table() if check_ivrs_checksum() returns an error.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/iommu/amd_iommu_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pm/drivers/iommu/amd_iommu_init.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/amd_iommu_init.c
> +++ linux-pm/drivers/iommu/amd_iommu_init.c
> @@ -2230,7 +2230,7 @@ static int __init early_amd_iommu_init(v
> */
> ret = check_ivrs_checksum(ivrs_base);
> if (ret)
> - return ret;
> + goto out;
>
> amd_iommu_target_ivhd_type = get_highest_supported_ivhd_type(ivrs_base);
> DUMP_printk("Using IVHD type %#x\n", amd_iommu_target_ivhd_type);
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | Jörg Rödel <joro@8bytes.org> |
|---|---|
| Date | 2017-01-10 15:00 +0100 |
| Subject | Re: 174cc7187e6f ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel |
| Message-ID | <sY580-21p-109@gated-at.bofh.it> |
| In reply to | #1554774 |
On Mon, Jan 09, 2017 at 11:41:15PM +0100, Rafael J. Wysocki wrote: > > Please find appended. Applied, thanks.
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web