Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554473 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-01-09 17:40 +0100 |
| Last post | 2017-01-13 18:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] soc: dove: constify reset_control_ops structures Bhumika Goyal <bhumirks@gmail.com> - 2017-01-09 17:40 +0100
Re: [PATCH] soc: dove: constify reset_control_ops structures Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-13 17:40 +0100
Re: [PATCH] soc: dove: constify reset_control_ops structures Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-13 18:00 +0100
Re: [PATCH] soc: dove: constify reset_control_ops structures Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-13 18:00 +0100
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-01-09 17:40 +0100 |
| Subject | [PATCH] soc: dove: constify reset_control_ops structures |
| Message-ID | <sXL9g-6vS-37@gated-at.bofh.it> |
Declare reset_control_ops as const as they are only stored in the ops
field of a reset_controller_dev structure. This field is of type const
struct reset_control_ops *, so reset_control_ops structures having this
property can be declared as const.
Done using Coccinelle:
@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct reset_control_ops i@p={...};
@ok1@
identifier r1.i;
position p;
struct reset_controller_dev x;
@@
x.ops=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct reset_control_ops i;
File size before: drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0f drivers/soc/dove/pmu.o
File size after: drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0f drivers/soc/dove/pmu.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/soc/dove/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index 039374e..95d77ec 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)
return 0;
}
-static struct reset_control_ops pmu_reset_ops = {
+static const struct reset_control_ops pmu_reset_ops = {
.reset = pmu_reset_reset,
.assert = pmu_reset_assert,
.deassert = pmu_reset_deassert,
--
1.9.1
[toc] | [next] | [standalone]
| From | Gregory CLEMENT <gregory.clement@free-electrons.com> |
|---|---|
| Date | 2017-01-13 17:40 +0100 |
| Message-ID | <sZd3s-389-17@gated-at.bofh.it> |
| In reply to | #1554473 |
Hi Sebastian,
On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Declare reset_control_ops as const as they are only stored in the ops
> field of a reset_controller_dev structure. This field is of type const
> struct reset_control_ops *, so reset_control_ops structures having this
> property can be declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@p={...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct reset_controller_dev x;
> @@
> x.ops=&i@p;
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
>
> File size before: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>
> File size after: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>
If you agree with this patch I will apply it on mvebu/soc.
Thanks,
Gregory
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/soc/dove/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index 039374e..95d77ec 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)
> return 0;
> }
>
> -static struct reset_control_ops pmu_reset_ops = {
> +static const struct reset_control_ops pmu_reset_ops = {
> .reset = pmu_reset_reset,
> .assert = pmu_reset_assert,
> .deassert = pmu_reset_deassert,
> --
> 1.9.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Gregory CLEMENT <gregory.clement@free-electrons.com> |
|---|---|
| Date | 2017-01-13 18:00 +0100 |
| Message-ID | <sZdmN-3eM-15@gated-at.bofh.it> |
| In reply to | #1558561 |
Hi Russell King,
On ven., janv. 13 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
>> Hi Sebastian,
>>
>> On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
>>
>> > Declare reset_control_ops as const as they are only stored in the ops
>> > field of a reset_controller_dev structure. This field is of type const
>> > struct reset_control_ops *, so reset_control_ops structures having this
>> > property can be declared as const.
>> > Done using Coccinelle:
>> >
>> > @r1 disable optional_qualifier@
>> > identifier i;
>> > position p;
>> > @@
>> > static struct reset_control_ops i@p={...};
>> >
>> > @ok1@
>> > identifier r1.i;
>> > position p;
>> > struct reset_controller_dev x;
>> > @@
>> > x.ops=&i@p;
>> >
>> > @bad@
>> > position p!={r1.p,ok1.p};
>> > identifier r1.i;
>> > @@
>> > i@p
>> >
>> > @depends on !bad disable optional_qualifier@
>> > identifier r1.i;
>> > @@
>> > +const
>> > struct reset_control_ops i;
>> >
>> > File size before: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>> > File size after: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>>
>> If you agree with this patch I will apply it on mvebu/soc.
>
> You really ought to be asking me...
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
would have redirect me to you :)
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied on mvebu/soc
Thanks,
Gregory
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2017-01-13 18:00 +0100 |
| Message-ID | <sZdmN-3eM-11@gated-at.bofh.it> |
| In reply to | #1558561 |
On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
> Hi Sebastian,
>
> On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
>
> > Declare reset_control_ops as const as they are only stored in the ops
> > field of a reset_controller_dev structure. This field is of type const
> > struct reset_control_ops *, so reset_control_ops structures having this
> > property can be declared as const.
> > Done using Coccinelle:
> >
> > @r1 disable optional_qualifier@
> > identifier i;
> > position p;
> > @@
> > static struct reset_control_ops i@p={...};
> >
> > @ok1@
> > identifier r1.i;
> > position p;
> > struct reset_controller_dev x;
> > @@
> > x.ops=&i@p;
> >
> > @bad@
> > position p!={r1.p,ok1.p};
> > identifier r1.i;
> > @@
> > i@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r1.i;
> > @@
> > +const
> > struct reset_control_ops i;
> >
> > File size before: drivers/soc/dove/pmu.o
> > text data bss dec hex filename
> > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
> >
> > File size after: drivers/soc/dove/pmu.o
> > text data bss dec hex filename
> > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
> >
>
> If you agree with this patch I will apply it on mvebu/soc.
You really ought to be asking me...
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web