Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554329 > unrolled thread
| Started by | Eric Auger <eric.auger@redhat.com> |
|---|---|
| First post | 2017-01-09 14:50 +0100 |
| Last post | 2017-01-10 15:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v7 19/19] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger <eric.auger@redhat.com> - 2017-01-09 14:50 +0100
Re: [PATCH v7 19/19] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Will Deacon <will.deacon@arm.com> - 2017-01-10 15:20 +0100
| From | Eric Auger <eric.auger@redhat.com> |
|---|---|
| Date | 2017-01-09 14:50 +0100 |
| Subject | [PATCH v7 19/19] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore |
| Message-ID | <sXIuK-4Rr-29@gated-at.bofh.it> |
IOMMU_CAP_INTR_REMAP has been advertised in arm-smmu(-v3) although
on ARM this property is not attached to the IOMMU but rather is
implemented in the MSI controller (GICv3 ITS).
Now vfio_iommu_type1 checks MSI remapping capability at MSI controller
level, let's correct this.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
drivers/iommu/arm-smmu-v3.c | 2 --
drivers/iommu/arm-smmu.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 6c4111c..d9cf6cb 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -1375,8 +1375,6 @@ static bool arm_smmu_capable(enum iommu_cap cap)
switch (cap) {
case IOMMU_CAP_CACHE_COHERENCY:
return true;
- case IOMMU_CAP_INTR_REMAP:
- return true; /* MSIs are just memory writes */
case IOMMU_CAP_NOEXEC:
return true;
default:
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index a354572..13d2600 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1374,8 +1374,6 @@ static bool arm_smmu_capable(enum iommu_cap cap)
* requests.
*/
return true;
- case IOMMU_CAP_INTR_REMAP:
- return true; /* MSIs are just memory writes */
case IOMMU_CAP_NOEXEC:
return true;
default:
--
1.9.1
[toc] | [next] | [standalone]
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2017-01-10 15:20 +0100 |
| Subject | Re: [PATCH v7 19/19] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore |
| Message-ID | <sY5rj-2pg-15@gated-at.bofh.it> |
| In reply to | #1554329 |
On Mon, Jan 09, 2017 at 01:46:10PM +0000, Eric Auger wrote: > IOMMU_CAP_INTR_REMAP has been advertised in arm-smmu(-v3) although > on ARM this property is not attached to the IOMMU but rather is > implemented in the MSI controller (GICv3 ITS). > > Now vfio_iommu_type1 checks MSI remapping capability at MSI controller > level, let's correct this. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > --- > drivers/iommu/arm-smmu-v3.c | 2 -- > drivers/iommu/arm-smmu.c | 2 -- > 2 files changed, 4 deletions(-) Dependent on the previous two VFIO patches: Acked-by: Will Deacon <will.deacon@arm.com> Will
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web