Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1554357 > unrolled thread

Re: [PATCH 1/2] printk: drop call_console_drivers() unused param

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] printk: drop call_console_drivers() unused param Petr Mladek <pmladek@suse.com> - 2017-01-09 15:00 +0100

#1554357 — Re: [PATCH 1/2] printk: drop call_console_drivers() unused param

On Tue 2017-01-03 11:22:30, Petr Mladek wrote:
> On Sat 2016-12-24 23:09:01, Sergey Senozhatsky wrote:
> > We do suppress_message_printing() check before we call
> > call_console_drivers() now, so `level' param is not needed
> > anymore.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> >  kernel/printk/printk.c | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> > 
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index e2cdd87e7a63..11a9842a2f47 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -1510,8 +1510,7 @@ SYSCALL_DEFINE3(syslog, int, type, char __user *, buf, int, len)
> >   * log_buf[start] to log_buf[end - 1].
> >   * The console_lock must be held.
> >   */
> > -static void call_console_drivers(int level,
> > -				 const char *ext_text, size_t ext_len,
> > +static void call_console_drivers(const char *ext_text, size_t ext_len,
> >  				 const char *text, size_t len)
> 
> Yup, this patch makes sense on its own. The level parameter is unused
> since the commit cf7754441c563230ed7 ("printk: introduce
> suppress_message_printing()").
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

The patch makes sense on its own. I have pushed it into
the for-4.11 branch, see
https://git.kernel.org/cgit/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.11&id=0e91b77060387275b6762c6688e3bddd1b808e2c

Best Regards,
Petr

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web