Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1552213 > unrolled thread

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

Started byGreg Kroah-Hartman <gregkh@linuxfoundation.org>
First post2017-01-05 19:40 +0100
Last post2017-01-08 12:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] usb: storage: ene_ub6250: remove unused variable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-05 19:40 +0100
    Re: [PATCH] usb: storage: ene_ub6250: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-08 00:30 +0100
      Re: [PATCH] usb: storage: ene_ub6250: remove unused variable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-08 12:40 +0100

#1552213 — Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-01-05 19:40 +0100
SubjectRe: [PATCH] usb: storage: ene_ub6250: remove unused variable
Message-ID<sWl7d-6J7-45@gated-at.bofh.it>
On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> The variable Newblk was only being assigned some value but was never
> used after that.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/usb/storage/ene_ub6250.c | 2 --
>  1 file changed, 2 deletions(-)

from and signed-off-by does not match :(

Same with your other usb patch...

[toc] | [next] | [standalone]


#1553762

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2017-01-08 00:30 +0100
Message-ID<sX8AV-6RI-3@gated-at.bofh.it>
In reply to#1552213
On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
>> The variable Newblk was only being assigned some value but was never
>> used after that.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>>   drivers/usb/storage/ene_ub6250.c | 2 --
>>   1 file changed, 2 deletions(-)
>
> from and signed-off-by does not match :(
>
> Same with your other usb patch...
>

I can add the From: tag in the patch. But this is from the last time we 
had this same conversation.

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html


Regards
Sudip

[toc] | [prev] | [next] | [standalone]


#1553855

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-01-08 12:40 +0100
Message-ID<sXjZn-5Lf-7@gated-at.bofh.it>
In reply to#1553762
On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > > ---
> > >   drivers/usb/storage/ene_ub6250.c | 2 --
> > >   1 file changed, 2 deletions(-)
> > 
> > from and signed-off-by does not match :(
> > 
> > Same with your other usb patch...
> > 
> 
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
> 
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html

I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.

I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web