Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552347 > unrolled thread

[PATCH] selftests: gpio add .gitignore for generated files

Started byShuah Khan <shuahkh@osg.samsung.com>
First post2017-01-05 22:50 +0100
Last post2017-01-05 22:50 +0100
Articles 9 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-05 22:50 +0100
    [PATCH] selftests: x86 protection_keys fix unused variable compile warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-05 22:50 +0100
    [PATCH] tools: gpio add .gitignore for generated files Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-05 22:50 +0100
      Re: [PATCH] tools: gpio add .gitignore for generated files Linus Walleij <linus.walleij@linaro.org> - 2017-01-10 10:30 +0100
        Re: [PATCH] tools: gpio add .gitignore for generated files Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 15:20 +0100
          Re: [PATCH] tools: gpio add .gitignore for generated files Linus Walleij <linus.walleij@linaro.org> - 2017-01-11 16:20 +0100
            Re: [PATCH] tools: gpio add .gitignore for generated files Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-11 17:10 +0100
    [PATCH] selftests: x86 protection_keys remove dead code Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-05 22:50 +0100
    [PATCH] selftests: ipc add missing generated file to .gitignore Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-05 22:50 +0100

#1552347 — [PATCH] selftests: gpio add .gitignore for generated files

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-05 22:50 +0100
Subject[PATCH] selftests: gpio add .gitignore for generated files
Message-ID<sWo53-eL-1@gated-at.bofh.it>
Add .gitignore for generated files

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/gpio/.gitignore | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/gpio/.gitignore

diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
new file mode 100644
index 0000000..7d14f74
--- /dev/null
+++ b/tools/testing/selftests/gpio/.gitignore
@@ -0,0 +1 @@
+gpio-mockup-chardev
-- 
2.7.4

[toc] | [next] | [standalone]

#1552348 — [PATCH] selftests: x86 protection_keys fix unused variable compile warnings

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-05 22:50 +0100
Subject[PATCH] selftests: x86 protection_keys fix unused variable compile warnings
Message-ID<sWo53-eL-7@gated-at.bofh.it>
In reply to#1552347
Fix unused variable compile warnings in protection_keys.c

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/x86/protection_keys.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c
index bdd58c7..70402cd 100644
--- a/tools/testing/selftests/x86/protection_keys.c
+++ b/tools/testing/selftests/x86/protection_keys.c
@@ -812,8 +812,6 @@ void setup_hugetlbfs(void)
 {
 	int err;
 	int fd;
-	int validated_nr_pages;
-	int i;
 	char buf[] = "123";
 
 	if (geteuid() != 0) {
@@ -1133,7 +1131,6 @@ void test_pkey_syscalls_on_non_allocated_pkey(int *ptr, u16 pkey)
 void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
 {
 	int err;
-	int bad_flag = (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE) + 1;
 	int bad_pkey = NR_PKEYS+99;
 
 	/* not enforced when pkey_get() is not a syscall
@@ -1149,8 +1146,6 @@ void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
 /* Assumes that all pkeys other than 'pkey' are unallocated */
 void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
 {
-	unsigned long flags;
-	unsigned long init_val;
 	int err;
 	int allocated_pkeys[NR_PKEYS] = {0};
 	int nr_allocated_pkeys = 0;
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1552351 — [PATCH] tools: gpio add .gitignore for generated files

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-05 22:50 +0100
Subject[PATCH] tools: gpio add .gitignore for generated files
Message-ID<sWo53-eL-25@gated-at.bofh.it>
In reply to#1552347
Add .gitignore for generated files.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/gpio/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/gpio/.gitignore

diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
new file mode 100644
index 0000000..767ad24
--- /dev/null
+++ b/tools/gpio/.gitignore
@@ -0,0 +1,4 @@
+gpio-event-mon
+gpio-hammer
+lsgpio
+include
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1555082 — Re: [PATCH] tools: gpio add .gitignore for generated files

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-01-10 10:30 +0100
SubjectRe: [PATCH] tools: gpio add .gitignore for generated files
Message-ID<sY0UF-7Xs-7@gated-at.bofh.it>
In reply to#1552351
On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:

> Add .gitignore for generated files.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  tools/gpio/.gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 tools/gpio/.gitignore
>
> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
> new file mode 100644
> index 0000000..767ad24
> --- /dev/null
> +++ b/tools/gpio/.gitignore
> @@ -0,0 +1,4 @@
> +gpio-event-mon
> +gpio-hammer
> +lsgpio
> +include

I understand the first three.

But "include"?
How did you produce that?

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1555432 — Re: [PATCH] tools: gpio add .gitignore for generated files

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-10 15:20 +0100
SubjectRe: [PATCH] tools: gpio add .gitignore for generated files
Message-ID<sY5rj-2pg-7@gated-at.bofh.it>
In reply to#1555082
On 01/10/2017 02:29 AM, Linus Walleij wrote:
> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> 
>> Add .gitignore for generated files.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  tools/gpio/.gitignore | 4 ++++
>>  1 file changed, 4 insertions(+)
>>  create mode 100644 tools/gpio/.gitignore
>>
>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>> new file mode 100644
>> index 0000000..767ad24
>> --- /dev/null
>> +++ b/tools/gpio/.gitignore
>> @@ -0,0 +1,4 @@
>> +gpio-event-mon
>> +gpio-hammer
>> +lsgpio
>> +include
> 
> I understand the first three.
> 
> But "include"?
> How did you produce that?
> 
> Yours,
> Linus Walleij
> 

I saw this after building selftests. gpio selftests Makefile installs
headres. "make kselftest" should reproduce the problem. This following
does an header install from tools/testing/selftests/gpio/Makefile

../../../../usr/include/linux/gpio.h:
        make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1556614 — Re: [PATCH] tools: gpio add .gitignore for generated files

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-01-11 16:20 +0100
SubjectRe: [PATCH] tools: gpio add .gitignore for generated files
Message-ID<sYsQX-8vl-45@gated-at.bofh.it>
In reply to#1555432
On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>
>>> Add .gitignore for generated files.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>>  tools/gpio/.gitignore | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>  create mode 100644 tools/gpio/.gitignore
>>>
>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>> new file mode 100644
>>> index 0000000..767ad24
>>> --- /dev/null
>>> +++ b/tools/gpio/.gitignore
>>> @@ -0,0 +1,4 @@
>>> +gpio-event-mon
>>> +gpio-hammer
>>> +lsgpio
>>> +include
>>
>> I understand the first three.
>>
>> But "include"?
>> How did you produce that?
>>
>> Yours,
>> Linus Walleij
>>
>
> I saw this after building selftests. gpio selftests Makefile installs
> headres. "make kselftest" should reproduce the problem. This following
> does an header install from tools/testing/selftests/gpio/Makefile
>
> ../../../../usr/include/linux/gpio.h:
>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

That seems like a bug.

I applied the patch removing the ignore line for include,
I think we should see this until we figured out what we do wrong.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1556670 — Re: [PATCH] tools: gpio add .gitignore for generated files

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-11 17:10 +0100
SubjectRe: [PATCH] tools: gpio add .gitignore for generated files
Message-ID<sYtDk-BT-23@gated-at.bofh.it>
In reply to#1556614
On 01/11/2017 08:19 AM, Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>>
>>>> Add .gitignore for generated files.
>>>>
>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>> ---
>>>>  tools/gpio/.gitignore | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>  create mode 100644 tools/gpio/.gitignore
>>>>
>>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>>> new file mode 100644
>>>> index 0000000..767ad24
>>>> --- /dev/null
>>>> +++ b/tools/gpio/.gitignore
>>>> @@ -0,0 +1,4 @@
>>>> +gpio-event-mon
>>>> +gpio-hammer
>>>> +lsgpio
>>>> +include
>>>
>>> I understand the first three.
>>>
>>> But "include"?
>>> How did you produce that?
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>> I saw this after building selftests. gpio selftests Makefile installs
>> headres. "make kselftest" should reproduce the problem. This following
>> does an header install from tools/testing/selftests/gpio/Makefile
>>
>> ../../../../usr/include/linux/gpio.h:
>>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
> 
> That seems like a bug.
> 
> I applied the patch removing the ignore line for include,
> I think we should see this until we figured out what we do wrong.
> 
> Yours,
> Linus Walleij
> 


Sounds good.

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1552353 — [PATCH] selftests: x86 protection_keys remove dead code

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-05 22:50 +0100
Subject[PATCH] selftests: x86 protection_keys remove dead code
Message-ID<sWo53-eL-21@gated-at.bofh.it>
In reply to#1552347
Remove commented out calls to pkey_get().

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/x86/protection_keys.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c
index 70402cd..46f53ec 100644
--- a/tools/testing/selftests/x86/protection_keys.c
+++ b/tools/testing/selftests/x86/protection_keys.c
@@ -1114,11 +1114,6 @@ void test_pkey_syscalls_on_non_allocated_pkey(int *ptr, u16 pkey)
 		err = sys_pkey_free(i);
 		pkey_assert(err);
 
-		/* not enforced when pkey_get() is not a syscall
-		err = pkey_get(i, 0);
-		pkey_assert(err < 0);
-		*/
-
 		err = sys_pkey_free(i);
 		pkey_assert(err);
 
@@ -1133,11 +1128,6 @@ void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
 	int err;
 	int bad_pkey = NR_PKEYS+99;
 
-	/* not enforced when pkey_get() is not a syscall
-	err = pkey_get(bad_pkey, bad_flag);
-	pkey_assert(err < 0);
-	*/
-
 	/* pass a known-invalid pkey in: */
 	err = sys_mprotect_pkey(ptr, PAGE_SIZE, PROT_READ, bad_pkey);
 	pkey_assert(err);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1552354 — [PATCH] selftests: ipc add missing generated file to .gitignore

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-01-05 22:50 +0100
Subject[PATCH] selftests: ipc add missing generated file to .gitignore
Message-ID<sWo53-eL-13@gated-at.bofh.it>
In reply to#1552347
Add missing generated file msgque to .gitignore

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/ipc/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/ipc/.gitignore b/tools/testing/selftests/ipc/.gitignore
index 84b66a3..9af04c9 100644
--- a/tools/testing/selftests/ipc/.gitignore
+++ b/tools/testing/selftests/ipc/.gitignore
@@ -1 +1,2 @@
 msgque_test
+msgque
-- 
2.7.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web