Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552201 > unrolled thread

Re: [PATCH net-next] net: make ndo_get_stats64 a void function

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH net-next] net: make ndo_get_stats64 a void function David Miller <davem@davemloft.net> - 2017-01-05 19:30 +0100

#1552201 — Re: [PATCH net-next] net: make ndo_get_stats64 a void function

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu,  5 Jan 2017 09:31:36 -0800

> The network device operation for reading statistics is only called
> in one place, and it ignores the return value. Having a structure
> return value is potentially confusing because some future driver could
> incorrectly assume that the return value was used.
> 
> Fix all drivers with ndo_get_stats64 to have a void function.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

You missed at least one new warning, please do a fresh allmodconfig build
and watch the logs.

drivers/net/ethernet/broadcom/bnx2.c: In function ‘bnx2_get_stats64’:
drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: ‘return’ with a value, in function returning void

Thanks.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web