Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552056 > unrolled thread

[PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current state is too deep

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current state is too deep Alex Shi <alex.shi@linaro.org> - 2017-01-05 16:40 +0100
    Re: [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current  state is too deep Rik van Riel <riel@redhat.com> - 2017-01-05 16:50 +0100
      Re: [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current  state is too deep Arjan van de Ven <arjan@linux.intel.com> - 2017-01-05 17:00 +0100

#1552056 — [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current state is too deep

The obsolete commit 71abbbf85 want to introduce a dynamic cstates,
but it was removed for long time. Just left the nonsense deeper cstate
checking.

Since all target_residency and exit_latency are going longer in deeper
idle state, no needs to waste some cpu cycle on useless seeking.

Signed-off-by: Alex Shi <alex.shi@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
---
 drivers/cpuidle/governors/menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index d9b5b93..07e36bb 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -357,9 +357,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
 		if (s->disabled || su->disable)
 			continue;
 		if (s->target_residency > data->predicted_us)
-			continue;
+			break;
 		if (s->exit_latency > latency_req)
-			continue;
+			break;
 
 		data->last_state_idx = i;
 	}
-- 
2.8.1.101.g72d917a

[toc] | [next] | [standalone]

#1552072 — Re: [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current state is too deep

On Thu, 2017-01-05 at 23:29 +0800, Alex Shi wrote:
> The obsolete commit 71abbbf85 want to introduce a dynamic cstates,
> but it was removed for long time. Just left the nonsense deeper
> cstate
> checking.
> 
> Since all target_residency and exit_latency are going longer in
> deeper
> idle state, no needs to waste some cpu cycle on useless seeking.

Makes me wonder if it would be worth documenting the
requirement that c-states be listed in increasing
order?

Acked-by: Rik van Riel <riel@redhat.com>

[toc] | [prev] | [next] | [standalone]

#1552073 — Re: [PATCH 1/3] cpuidle/menu: stop seeking deeper idle if current state is too deep

On 1/5/2017 7:43 AM, Rik van Riel wrote:
> On Thu, 2017-01-05 at 23:29 +0800, Alex Shi wrote:
>> The obsolete commit 71abbbf85 want to introduce a dynamic cstates,
>> but it was removed for long time. Just left the nonsense deeper
>> cstate
>> checking.
>>
>> Since all target_residency and exit_latency are going longer in
>> deeper
>> idle state, no needs to waste some cpu cycle on useless seeking.
>
> Makes me wonder if it would be worth documenting the
> requirement that c-states be listed in increasing
> order?

or better, a boot time quick check...

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web