Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551857 > unrolled thread

[PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-01-05 11:30 +0100
    Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function Andrzej Hajda <a.hajda@samsung.com> - 2017-01-05 13:20 +0100
    Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function Inki Dae <inki.dae@samsung.com> - 2017-01-11 06:40 +0100

#1551857 — [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

The OF graph is not necessary because the panel is a child of
dsi. therefore, the parse_dt function of dsi does not need to
check the remote_node connected to the panel. and the whole
parse_dt function should be refactored later.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_mic.c | 25 +++----------------------
 1 file changed, 3 insertions(+), 22 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index fed1a94..cf9361a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -269,28 +269,9 @@ static int parse_dt(struct exynos_mic *mic)
 		}
 		nodes[j++] = remote_node;
 
-		switch (i) {
-		case ENDPOINT_DECON_NODE:
-			/* decon node */
-			if (of_get_child_by_name(remote_node,
-						"i80-if-timings"))
-				mic->i80_mode = 1;
-
-			break;
-		case ENDPOINT_DSI_NODE:
-			/* panel node */
-			remote_node = get_remote_node(remote_node, 1);
-			if (!remote_node) {
-				ret = -EPIPE;
-				goto exit;
-			}
-			nodes[j++] = remote_node;
-
-			break;
-		default:
-			DRM_ERROR("mic: Unknown endpoint from MIC");
-			break;
-		}
+		if (i == ENDPOINT_DECON_NODE &&
+			of_get_child_by_name(remote_node, "i80-if-timings"))
+			mic->i80_mode = 1;
 	}
 
 exit:
-- 
1.9.1

[toc] | [next] | [standalone]

#1551942

On 05.01.2017 11:20, Hoegeun Kwon wrote:
> The OF graph is not necessary because the panel is a child of
> dsi. therefore, the parse_dt function of dsi does not need to
> check the remote_node connected to the panel. and the whole
> parse_dt function should be refactored later.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej

[toc] | [prev] | [next] | [standalone]

#1556213

Applied.

Thanks.

2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글:
> The OF graph is not necessary because the panel is a child of
> dsi. therefore, the parse_dt function of dsi does not need to
> check the remote_node connected to the panel. and the whole
> parse_dt function should be refactored later.
> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 25 +++----------------------
>  1 file changed, 3 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index fed1a94..cf9361a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -269,28 +269,9 @@ static int parse_dt(struct exynos_mic *mic)
>  		}
>  		nodes[j++] = remote_node;
>  
> -		switch (i) {
> -		case ENDPOINT_DECON_NODE:
> -			/* decon node */
> -			if (of_get_child_by_name(remote_node,
> -						"i80-if-timings"))
> -				mic->i80_mode = 1;
> -
> -			break;
> -		case ENDPOINT_DSI_NODE:
> -			/* panel node */
> -			remote_node = get_remote_node(remote_node, 1);
> -			if (!remote_node) {
> -				ret = -EPIPE;
> -				goto exit;
> -			}
> -			nodes[j++] = remote_node;
> -
> -			break;
> -		default:
> -			DRM_ERROR("mic: Unknown endpoint from MIC");
> -			break;
> -		}
> +		if (i == ENDPOINT_DECON_NODE &&
> +			of_get_child_by_name(remote_node, "i80-if-timings"))
> +			mic->i80_mode = 1;
>  	}
>  
>  exit:
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web