Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1551710 > unrolled thread
| Started by | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| First post | 2017-01-05 09:00 +0100 |
| Last post | 2017-01-11 05:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static Tomas Winkler <tomas.winkler@intel.com> - 2017-01-05 09:00 +0100
Re: [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static Subhash Jadavani <subhashj@codeaurora.org> - 2017-01-11 02:00 +0100
Re: [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-11 05:10 +0100
| From | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| Date | 2017-01-05 09:00 +0100 |
| Subject | [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static |
| Message-ID | <sWb7Q-8fR-9@gated-at.bofh.it> |
Fix the following compilation warning:
drivers/scsi/ufs/ufshcd.c:2076:5: warning: no previous prototype for
‘ufshcd_query_descriptor_retry’ [-Wmissing-prototypes]
Also do not export the function, it should not be used out of ufs
context.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/scsi/ufs/ufshcd.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 20e5e5fb048c..be3c2900b6bb 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2073,9 +2073,11 @@ static int __ufshcd_query_descriptor(struct ufs_hba *hba,
* The buf_len parameter will contain, on return, the length parameter
* received on the response.
*/
-int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
- enum query_opcode opcode, enum desc_idn idn, u8 index,
- u8 selector, u8 *desc_buf, int *buf_len)
+static int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
+ enum query_opcode opcode,
+ enum desc_idn idn, u8 index,
+ u8 selector,
+ u8 *desc_buf, int *buf_len)
{
int err;
int retries;
@@ -2089,7 +2091,6 @@ int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
return err;
}
-EXPORT_SYMBOL(ufshcd_query_descriptor_retry);
/**
* ufshcd_read_desc_param - read the specified descriptor parameter
--
2.7.4
[toc] | [next] | [standalone]
| From | Subhash Jadavani <subhashj@codeaurora.org> |
|---|---|
| Date | 2017-01-11 02:00 +0100 |
| Subject | Re: [scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static |
| Message-ID | <sYfqG-8og-7@gated-at.bofh.it> |
| In reply to | #1551710 |
On 2017-01-05 00:45, Tomas Winkler wrote:
> Fix the following compilation warning:
>
> drivers/scsi/ufs/ufshcd.c:2076:5: warning: no previous prototype for
> ‘ufshcd_query_descriptor_retry’ [-Wmissing-prototypes]
>
> Also do not export the function, it should not be used out of ufs
> context.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 20e5e5fb048c..be3c2900b6bb 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -2073,9 +2073,11 @@ static int __ufshcd_query_descriptor(struct
> ufs_hba *hba,
> * The buf_len parameter will contain, on return, the length parameter
> * received on the response.
> */
> -int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
> - enum query_opcode opcode, enum desc_idn idn, u8 index,
> - u8 selector, u8 *desc_buf, int *buf_len)
> +static int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
> + enum query_opcode opcode,
> + enum desc_idn idn, u8 index,
> + u8 selector,
> + u8 *desc_buf, int *buf_len)
> {
> int err;
> int retries;
> @@ -2089,7 +2091,6 @@ int ufshcd_query_descriptor_retry(struct ufs_hba
> *hba,
>
> return err;
> }
> -EXPORT_SYMBOL(ufshcd_query_descriptor_retry);
>
> /**
> * ufshcd_read_desc_param - read the specified descriptor parameter
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2017-01-11 05:10 +0100 |
| Message-ID | <sYiox-20K-9@gated-at.bofh.it> |
| In reply to | #1551710 |
>>>>> "Tomas" == Tomas Winkler <tomas.winkler@intel.com> writes: Tomas> Fix the following compilation warning: Tomas> drivers/scsi/ufs/ufshcd.c:2076:5: warning: no previous prototype Tomas> for ‘ufshcd_query_descriptor_retry’ [-Wmissing-prototypes] Tomas> Also do not export the function, it should not be used out of ufs Tomas> context. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web