Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553578 > unrolled thread
| Started by | Derek Robson <robsonde@gmail.com> |
|---|---|
| First post | 2017-01-07 04:50 +0100 |
| Last post | 2017-01-09 21:20 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions Derek Robson <robsonde@gmail.com> - 2017-01-07 04:50 +0100
[PATCH 1/2] Staging: unisys: visorbus: style fix, using octal file permissions Derek Robson <robsonde@gmail.com> - 2017-01-07 04:50 +0100
RE: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions "Kershner, David A" <David.Kershner@unisys.com> - 2017-01-07 06:00 +0100
Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions Greg KH <gregkh@linuxfoundation.org> - 2017-01-07 08:50 +0100
Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-09 21:20 +0100
| From | Derek Robson <robsonde@gmail.com> |
|---|---|
| Date | 2017-01-07 04:50 +0100 |
| Subject | [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions |
| Message-ID | <sWQb0-3hd-3@gated-at.bofh.it> |
Two files change in style fix, changes are octal file permissions. Derek Robson (2): Staging: unisys: visorbus: style fix, using octal file permissions Staging: unisys: visorbus: style fix, using octal file permissions drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++--- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.11.0
[toc] | [next] | [standalone]
| From | Derek Robson <robsonde@gmail.com> |
|---|---|
| Date | 2017-01-07 04:50 +0100 |
| Subject | [PATCH 1/2] Staging: unisys: visorbus: style fix, using octal file permissions |
| Message-ID | <sWQb0-3hd-5@gated-at.bofh.it> |
| In reply to | #1553578 |
Changed file permissions to octal style.
Found with checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3457ef338e1e..28ca291a4053 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
goto err_hdr_info;
}
dev->debugfs_client_bus_info =
- debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("client_bus_info", 0440,
dev->debugfs_dir, dev,
&client_bus_info_debugfs_fops);
if (!dev->debugfs_client_bus_info) {
@@ -1337,10 +1337,10 @@ visorbus_exit(void)
debugfs_remove_recursive(visorbus_debugfs_dir);
}
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
MODULE_PARM_DESC(visorbus_forcematch,
"1 to force a successful dev <--> drv match");
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
MODULE_PARM_DESC(visorbus_forcenomatch,
"1 to force an UNsuccessful dev <--> drv match");
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | "Kershner, David A" <David.Kershner@unisys.com> |
|---|---|
| Date | 2017-01-07 06:00 +0100 |
| Subject | RE: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions |
| Message-ID | <sWRgJ-3UF-5@gated-at.bofh.it> |
| In reply to | #1553578 |
> -----Original Message----- > From: Derek Robson [mailto:robsonde@gmail.com] > Sent: Friday, January 6, 2017 10:48 PM > To: Kershner, David A <David.Kershner@unisys.com>; > gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com> > Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>; > devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Derek Robson > <robsonde@gmail.com> > Subject: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file > permissions > > Two files change in style fix, changes are octal file permissions. > Series looks fine to me and runs on top of the s-Par firmware. Acked-by: David Kershner <david.kershner@unisys.com> > Derek Robson (2): > Staging: unisys: visorbus: style fix, using octal file permissions > Staging: unisys: visorbus: style fix, using octal file permissions > > drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++--- > drivers/staging/unisys/visorbus/visorchipset.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > -- > 2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-01-07 08:50 +0100 |
| Subject | Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions |
| Message-ID | <sWTVf-5GK-1@gated-at.bofh.it> |
| In reply to | #1553578 |
On Sat, Jan 07, 2017 at 04:48:01PM +1300, Derek Robson wrote: > Two files change in style fix, changes are octal file permissions. > > Derek Robson (2): > Staging: unisys: visorbus: style fix, using octal file permissions > Staging: unisys: visorbus: style fix, using octal file permissions You can't send different patches that do different things with identical subject lines, as that doesn't make sense, right? Please resend making these subject unique, and add David's ack to them as well on the resend. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-01-09 21:20 +0100 |
| Subject | Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions |
| Message-ID | <sXOA9-gv-5@gated-at.bofh.it> |
| In reply to | #1553578 |
On Sat, Jan 7, 2017 at 5:48 AM, Derek Robson <robsonde@gmail.com> wrote: > Two files change in style fix, changes are octal file permissions. Does it make any sense? Or did I miss something? -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web