Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1553034 > unrolled thread

[net-next][PATCH] RDS: validate the requested traces user input against max supported

Back to article view | Back to linux.kernel

Contents

  [net-next][PATCH] RDS: validate the requested traces user input against max supported Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-01-06 19:50 +0100
    Re: [net-next][PATCH] RDS: validate the requested traces user  input against max supported David Miller <davem@davemloft.net> - 2017-01-07 04:20 +0100

#1553034 — [net-next][PATCH] RDS: validate the requested traces user input against max supported

Larger than supported value can lead to array read/write overflow.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
 net/rds/af_rds.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c
index fd821740..b405f77 100644
--- a/net/rds/af_rds.c
+++ b/net/rds/af_rds.c
@@ -310,6 +310,9 @@ static int rds_recv_track_latency(struct rds_sock *rs, char __user *optval,
 	if (copy_from_user(&trace, optval, sizeof(trace)))
 		return -EFAULT;
 
+	if (trace.rx_traces > RDS_MSG_RX_DGRAM_TRACE_MAX)
+		return -EFAULT;
+
 	rs->rs_rx_traces = trace.rx_traces;
 	for (i = 0; i < rs->rs_rx_traces; i++) {
 		if (trace.rx_trace_pos[i] > RDS_MSG_RX_DGRAM_TRACE_MAX) {
-- 
1.9.1

[toc] | [next] | [standalone]

#1553569 — Re: [net-next][PATCH] RDS: validate the requested traces user input against max supported

From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Fri,  6 Jan 2017 10:44:15 -0800

> Larger than supported value can lead to array read/write overflow.
> 
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web