Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549882 > unrolled thread

[PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-03 16:30 +0100
    Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in  nand_micron.c Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-04 18:20 +0100
      Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in  nand_micron.c Marek Vasut <marek.vasut@gmail.com> - 2017-01-04 18:30 +0100
        Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in  nand_micron.c Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-04 19:20 +0100
          Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in  nand_micron.c Marek Vasut <marek.vasut@gmail.com> - 2017-01-04 22:30 +0100
    Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in  nand_micron.c Marek Vasut <marek.vasut@gmail.com> - 2017-01-04 20:30 +0100

#1549882 — [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

Move Micron specific initialization logic into nand_micron.c. This is
part of the "separate vendor specific code from core" cleanup process.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/mtd/nand/Makefile      |  1 +
 drivers/mtd/nand/nand_base.c   | 32 +---------------
 drivers/mtd/nand/nand_ids.c    |  3 +-
 drivers/mtd/nand/nand_micron.c | 83 ++++++++++++++++++++++++++++++++++++++++++
 include/linux/mtd/nand.h       | 20 ----------
 5 files changed, 88 insertions(+), 51 deletions(-)
 create mode 100644 drivers/mtd/nand/nand_micron.c

diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
index 7c059822f479..11d743155810 100644
--- a/drivers/mtd/nand/Makefile
+++ b/drivers/mtd/nand/Makefile
@@ -62,5 +62,6 @@ obj-$(CONFIG_MTD_NAND_MTK)		+= mtk_nand.o mtk_ecc.o
 
 nand-objs := nand_base.o nand_bbt.o nand_timings.o nand_ids.o
 nand-objs += nand_hynix.o
+nand-objs += nand_micron.o
 nand-objs += nand_samsung.o
 nand-objs += nand_toshiba.o
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index cd09124d071b..ebeaf2aadad9 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3500,30 +3500,6 @@ static int nand_flash_detect_ext_param_page(struct nand_chip *chip,
 	return ret;
 }
 
-static int nand_setup_read_retry_micron(struct mtd_info *mtd, int retry_mode)
-{
-	struct nand_chip *chip = mtd_to_nand(mtd);
-	uint8_t feature[ONFI_SUBFEATURE_PARAM_LEN] = {retry_mode};
-
-	return chip->onfi_set_features(mtd, chip, ONFI_FEATURE_ADDR_READ_RETRY,
-			feature);
-}
-
-/*
- * Configure chip properties from Micron vendor-specific ONFI table
- */
-static void nand_onfi_detect_micron(struct nand_chip *chip,
-		struct nand_onfi_params *p)
-{
-	struct nand_onfi_vendor_micron *micron = (void *)p->vendor;
-
-	if (le16_to_cpu(p->vendor_revision) < 1)
-		return;
-
-	chip->read_retries = micron->read_retry_options;
-	chip->setup_read_retry = nand_setup_read_retry_micron;
-}
-
 /*
  * Check if the NAND chip is ONFI compliant, returns 1 if it is, 0 otherwise.
  */
@@ -3620,9 +3596,6 @@ static int nand_flash_detect_onfi(struct nand_chip *chip)
 		pr_warn("Could not retrieve ONFI ECC requirements\n");
 	}
 
-	if (p->jedec_id == NAND_MFR_MICRON)
-		nand_onfi_detect_micron(chip, p);
-
 	return 1;
 }
 
@@ -3859,9 +3832,8 @@ static void nand_decode_bbm_options(struct nand_chip *chip)
 	 * Micron devices with 2KiB pages and on SLC Samsung, Hynix, Toshiba,
 	 * AMD/Spansion, and Macronix.  All others scan only the first page.
 	 */
-	if ((nand_is_slc(chip) &&
-	     (maf_id == NAND_MFR_AMD || maf_id == NAND_MFR_MACRONIX)) ||
-	    (mtd->writesize == 2048 && maf_id == NAND_MFR_MICRON))
+	if (nand_is_slc(chip) &&
+	    (maf_id == NAND_MFR_AMD || maf_id == NAND_MFR_MACRONIX))
 		chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;
 }
 
diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index b27e1823bf1d..8e420f0925f8 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -172,6 +172,7 @@ struct nand_flash_dev nand_flash_ids[] = {
 extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops;
 extern const struct nand_manufacturer_ops samsung_nand_manuf_ops;
 extern const struct nand_manufacturer_ops hynix_nand_manuf_ops;
+extern const struct nand_manufacturer_ops micron_nand_manuf_ops;
 
 struct nand_manufacturers nand_manuf_ids[] = {
 	{NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops},
@@ -182,7 +183,7 @@ struct nand_manufacturers nand_manuf_ids[] = {
 	{NAND_MFR_RENESAS, "Renesas"},
 	{NAND_MFR_STMICRO, "ST Micro"},
 	{NAND_MFR_HYNIX, "Hynix", &hynix_nand_manuf_ops},
-	{NAND_MFR_MICRON, "Micron"},
+	{NAND_MFR_MICRON, "Micron", &micron_nand_manuf_ops},
 	{NAND_MFR_AMD, "AMD/Spansion"},
 	{NAND_MFR_MACRONIX, "Macronix"},
 	{NAND_MFR_EON, "Eon"},
diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
new file mode 100644
index 000000000000..ddb9adf12c21
--- /dev/null
+++ b/drivers/mtd/nand/nand_micron.c
@@ -0,0 +1,83 @@
+/*
+ * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mtd/nand.h>
+
+struct nand_onfi_vendor_micron {
+	u8 two_plane_read;
+	u8 read_cache;
+	u8 read_unique_id;
+	u8 dq_imped;
+	u8 dq_imped_num_settings;
+	u8 dq_imped_feat_addr;
+	u8 rb_pulldown_strength;
+	u8 rb_pulldown_strength_feat_addr;
+	u8 rb_pulldown_strength_num_settings;
+	u8 otp_mode;
+	u8 otp_page_start;
+	u8 otp_data_prot_addr;
+	u8 otp_num_pages;
+	u8 otp_feat_addr;
+	u8 read_retry_options;
+	u8 reserved[72];
+	u8 param_revision;
+} __packed;
+
+static int micron_nand_setup_read_retry(struct mtd_info *mtd, int retry_mode)
+{
+	struct nand_chip *chip = mtd_to_nand(mtd);
+	u8 feature[ONFI_SUBFEATURE_PARAM_LEN] = {retry_mode};
+
+	return chip->onfi_set_features(mtd, chip, ONFI_FEATURE_ADDR_READ_RETRY,
+				       feature);
+}
+
+/*
+ * Configure chip properties from Micron vendor-specific ONFI table
+ */
+static int micron_nand_onfi_init(struct nand_chip *chip)
+{
+	struct nand_onfi_params *p = &chip->onfi_params;
+	struct nand_onfi_vendor_micron *micron = (void *)p->vendor;
+
+	if (!chip->onfi_version)
+		return 0;
+
+	if (le16_to_cpu(p->vendor_revision) < 1)
+		return 0;
+
+	chip->read_retries = micron->read_retry_options;
+	chip->setup_read_retry = micron_nand_setup_read_retry;
+
+	return 0;
+}
+
+static int micron_nand_init(struct nand_chip *chip)
+{
+	struct mtd_info *mtd = nand_to_mtd(chip);
+	int ret;
+
+	ret = micron_nand_onfi_init(chip);
+	if (ret)
+		return ret;
+
+	if (mtd->writesize == 2048)
+		chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;
+
+	return 0;
+}
+
+const struct nand_manufacturer_ops micron_nand_manuf_ops = {
+	.init = micron_nand_init,
+};
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index efba76951b7c..2a9655e304d7 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -366,26 +366,6 @@ struct onfi_ext_param_page {
 	 */
 } __packed;
 
-struct nand_onfi_vendor_micron {
-	u8 two_plane_read;
-	u8 read_cache;
-	u8 read_unique_id;
-	u8 dq_imped;
-	u8 dq_imped_num_settings;
-	u8 dq_imped_feat_addr;
-	u8 rb_pulldown_strength;
-	u8 rb_pulldown_strength_feat_addr;
-	u8 rb_pulldown_strength_num_settings;
-	u8 otp_mode;
-	u8 otp_page_start;
-	u8 otp_data_prot_addr;
-	u8 otp_num_pages;
-	u8 otp_feat_addr;
-	u8 read_retry_options;
-	u8 reserved[72];
-	u8 param_revision;
-} __packed;
-
 struct jedec_ecc_info {
 	u8 ecc_bits;
 	u8 codeword_size;
-- 
2.7.4

[toc] | [next] | [standalone]

#1550997 — Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

On Wed, 4 Jan 2017 16:15:46 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 01/03/2017 02:01 PM, Boris Brezillon wrote:
> > Move Micron specific initialization logic into nand_micron.c. This is
> > part of the "separate vendor specific code from core" cleanup process.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>  
> 
> [...]
> 
> > diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
> > new file mode 100644
> > index 000000000000..ddb9adf12c21
> > --- /dev/null
> > +++ b/drivers/mtd/nand/nand_micron.c
> > @@ -0,0 +1,83 @@
> > +/*
> > + * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>  
> 
> 2013-2017 ?

2017, indeed.

> 
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <linux/mtd/nand.h>
> > +
> > +struct nand_onfi_vendor_micron {
> > +	u8 two_plane_read;
> > +	u8 read_cache;
> > +	u8 read_unique_id;
> > +	u8 dq_imped;
> > +	u8 dq_imped_num_settings;
> > +	u8 dq_imped_feat_addr;
> > +	u8 rb_pulldown_strength;
> > +	u8 rb_pulldown_strength_feat_addr;
> > +	u8 rb_pulldown_strength_num_settings;
> > +	u8 otp_mode;
> > +	u8 otp_page_start;
> > +	u8 otp_data_prot_addr;
> > +	u8 otp_num_pages;
> > +	u8 otp_feat_addr;
> > +	u8 read_retry_options;
> > +	u8 reserved[72];
> > +	u8 param_revision;
> > +} __packed;  
> 
> Is this __packed really needed?
> 

I'm just copying an existing structure. And yes, it's probably unneeded
since all fields are u8, and the struct size in a multiple of 8 bytes,
but it shouldn't hurt either. 

[toc] | [prev] | [next] | [standalone]

#1550999 — Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

On 01/04/2017 06:13 PM, Boris Brezillon wrote:
> On Wed, 4 Jan 2017 16:15:46 +0100
> Marek Vasut <marek.vasut@gmail.com> wrote:
> 
>> On 01/03/2017 02:01 PM, Boris Brezillon wrote:
>>> Move Micron specific initialization logic into nand_micron.c. This is
>>> part of the "separate vendor specific code from core" cleanup process.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>  
>>
>> [...]
>>
>>> diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
>>> new file mode 100644
>>> index 000000000000..ddb9adf12c21
>>> --- /dev/null
>>> +++ b/drivers/mtd/nand/nand_micron.c
>>> @@ -0,0 +1,83 @@
>>> +/*
>>> + * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>  
>>
>> 2013-2017 ?
> 
> 2017, indeed.
> 
>>
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +
>>> +#include <linux/mtd/nand.h>
>>> +
>>> +struct nand_onfi_vendor_micron {
>>> +	u8 two_plane_read;
>>> +	u8 read_cache;
>>> +	u8 read_unique_id;
>>> +	u8 dq_imped;
>>> +	u8 dq_imped_num_settings;
>>> +	u8 dq_imped_feat_addr;
>>> +	u8 rb_pulldown_strength;
>>> +	u8 rb_pulldown_strength_feat_addr;
>>> +	u8 rb_pulldown_strength_num_settings;
>>> +	u8 otp_mode;
>>> +	u8 otp_page_start;
>>> +	u8 otp_data_prot_addr;
>>> +	u8 otp_num_pages;
>>> +	u8 otp_feat_addr;
>>> +	u8 read_retry_options;
>>> +	u8 reserved[72];
>>> +	u8 param_revision;
>>> +} __packed;  
>>
>> Is this __packed really needed?
>>
> 
> I'm just copying an existing structure. And yes, it's probably unneeded
> since all fields are u8, and the struct size in a multiple of 8 bytes,
> but it shouldn't hurt either. 
> 
Could you send a patch to drop it, please ? :)

-- 
Best regards,
Marek Vasut

[toc] | [prev] | [next] | [standalone]

#1551065 — Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

On Wed, 4 Jan 2017 18:22:31 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 01/04/2017 06:13 PM, Boris Brezillon wrote:
> > On Wed, 4 Jan 2017 16:15:46 +0100
> > Marek Vasut <marek.vasut@gmail.com> wrote:
> >   
> >> On 01/03/2017 02:01 PM, Boris Brezillon wrote:  
> >>> Move Micron specific initialization logic into nand_micron.c. This is
> >>> part of the "separate vendor specific code from core" cleanup process.
> >>>
> >>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>    
> >>
> >> [...]
> >>  
> >>> diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
> >>> new file mode 100644
> >>> index 000000000000..ddb9adf12c21
> >>> --- /dev/null
> >>> +++ b/drivers/mtd/nand/nand_micron.c
> >>> @@ -0,0 +1,83 @@
> >>> +/*
> >>> + * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>    
> >>
> >> 2013-2017 ?  
> > 
> > 2017, indeed.
> >   
> >>  
> >>> + * This program is free software; you can redistribute it and/or modify
> >>> + * it under the terms of the GNU General Public License as published by
> >>> + * the Free Software Foundation; either version 2 of the License, or
> >>> + * (at your option) any later version.
> >>> + *
> >>> + * This program is distributed in the hope that it will be useful,
> >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >>> + * GNU General Public License for more details.
> >>> + */
> >>> +
> >>> +#include <linux/mtd/nand.h>
> >>> +
> >>> +struct nand_onfi_vendor_micron {
> >>> +	u8 two_plane_read;
> >>> +	u8 read_cache;
> >>> +	u8 read_unique_id;
> >>> +	u8 dq_imped;
> >>> +	u8 dq_imped_num_settings;
> >>> +	u8 dq_imped_feat_addr;
> >>> +	u8 rb_pulldown_strength;
> >>> +	u8 rb_pulldown_strength_feat_addr;
> >>> +	u8 rb_pulldown_strength_num_settings;
> >>> +	u8 otp_mode;
> >>> +	u8 otp_page_start;
> >>> +	u8 otp_data_prot_addr;
> >>> +	u8 otp_num_pages;
> >>> +	u8 otp_feat_addr;
> >>> +	u8 read_retry_options;
> >>> +	u8 reserved[72];
> >>> +	u8 param_revision;
> >>> +} __packed;    
> >>
> >> Is this __packed really needed?
> >>  
> > 
> > I'm just copying an existing structure. And yes, it's probably unneeded
> > since all fields are u8, and the struct size in a multiple of 8 bytes,
> > but it shouldn't hurt either. 
> >   
> Could you send a patch to drop it, please ? :)
> 

Is there a strong reason to drop this attribute? All ONFI related
structs are using it to make sure the layout is not changed by the
compiler, and be able to cast a buffer container the ONFI param page
content to one of the nand_onfi_xxx struct.

Yes, this is currently not needed (at least for this struct), but I'd
prefer to keep nand_onfi_xxx definitions consistent if you don't mind,
unless you see a good reason to avoid using this __packed attribute.

[toc] | [prev] | [next] | [standalone]

#1551401 — Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

On 01/04/2017 06:58 PM, Boris Brezillon wrote:
> On Wed, 4 Jan 2017 18:22:31 +0100
> Marek Vasut <marek.vasut@gmail.com> wrote:
> 
>> On 01/04/2017 06:13 PM, Boris Brezillon wrote:
>>> On Wed, 4 Jan 2017 16:15:46 +0100
>>> Marek Vasut <marek.vasut@gmail.com> wrote:
>>>   
>>>> On 01/03/2017 02:01 PM, Boris Brezillon wrote:  
>>>>> Move Micron specific initialization logic into nand_micron.c. This is
>>>>> part of the "separate vendor specific code from core" cleanup process.
>>>>>
>>>>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>    
>>>>
>>>> [...]
>>>>  
>>>>> diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
>>>>> new file mode 100644
>>>>> index 000000000000..ddb9adf12c21
>>>>> --- /dev/null
>>>>> +++ b/drivers/mtd/nand/nand_micron.c
>>>>> @@ -0,0 +1,83 @@
>>>>> +/*
>>>>> + * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>    
>>>>
>>>> 2013-2017 ?  
>>>
>>> 2017, indeed.
>>>   
>>>>  
>>>>> + * This program is free software; you can redistribute it and/or modify
>>>>> + * it under the terms of the GNU General Public License as published by
>>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>>> + * (at your option) any later version.
>>>>> + *
>>>>> + * This program is distributed in the hope that it will be useful,
>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>> + * GNU General Public License for more details.
>>>>> + */
>>>>> +
>>>>> +#include <linux/mtd/nand.h>
>>>>> +
>>>>> +struct nand_onfi_vendor_micron {
>>>>> +	u8 two_plane_read;
>>>>> +	u8 read_cache;
>>>>> +	u8 read_unique_id;
>>>>> +	u8 dq_imped;
>>>>> +	u8 dq_imped_num_settings;
>>>>> +	u8 dq_imped_feat_addr;
>>>>> +	u8 rb_pulldown_strength;
>>>>> +	u8 rb_pulldown_strength_feat_addr;
>>>>> +	u8 rb_pulldown_strength_num_settings;
>>>>> +	u8 otp_mode;
>>>>> +	u8 otp_page_start;
>>>>> +	u8 otp_data_prot_addr;
>>>>> +	u8 otp_num_pages;
>>>>> +	u8 otp_feat_addr;
>>>>> +	u8 read_retry_options;
>>>>> +	u8 reserved[72];
>>>>> +	u8 param_revision;
>>>>> +} __packed;    
>>>>
>>>> Is this __packed really needed?
>>>>  
>>>
>>> I'm just copying an existing structure. And yes, it's probably unneeded
>>> since all fields are u8, and the struct size in a multiple of 8 bytes,
>>> but it shouldn't hurt either. 
>>>   
>> Could you send a patch to drop it, please ? :)
>>
> 
> Is there a strong reason to drop this attribute? All ONFI related
> structs are using it to make sure the layout is not changed by the
> compiler, and be able to cast a buffer container the ONFI param page
> content to one of the nand_onfi_xxx struct.
> 
> Yes, this is currently not needed (at least for this struct), but I'd
> prefer to keep nand_onfi_xxx definitions consistent if you don't mind,
> unless you see a good reason to avoid using this __packed attribute.

OK, fine. No, there's no strong reason to remove it.

-- 
Best regards,
Marek Vasut

[toc] | [prev] | [next] | [standalone]

#1551126 — Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c

On 01/03/2017 02:01 PM, Boris Brezillon wrote:
> Move Micron specific initialization logic into nand_micron.c. This is
> part of the "separate vendor specific code from core" cleanup process.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

[...]

> diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c
> new file mode 100644
> index 000000000000..ddb9adf12c21
> --- /dev/null
> +++ b/drivers/mtd/nand/nand_micron.c
> @@ -0,0 +1,83 @@
> +/*
> + * Copyright (C) 2013 Boris Brezillon <boris.brezillon@free-electrons.com>

2013-2017 ?

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/mtd/nand.h>
> +
> +struct nand_onfi_vendor_micron {
> +	u8 two_plane_read;
> +	u8 read_cache;
> +	u8 read_unique_id;
> +	u8 dq_imped;
> +	u8 dq_imped_num_settings;
> +	u8 dq_imped_feat_addr;
> +	u8 rb_pulldown_strength;
> +	u8 rb_pulldown_strength_feat_addr;
> +	u8 rb_pulldown_strength_num_settings;
> +	u8 otp_mode;
> +	u8 otp_page_start;
> +	u8 otp_data_prot_addr;
> +	u8 otp_num_pages;
> +	u8 otp_feat_addr;
> +	u8 read_retry_options;
> +	u8 reserved[72];
> +	u8 param_revision;
> +} __packed;

Is this __packed really needed?

-- 
Best regards,
Marek Vasut

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web