Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540276 > unrolled thread

[PATCH v4 0/5] thermal: fixes the rockchip thermal

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 0/5] thermal: fixes the rockchip thermal Caesar Wang <wxt@rock-chips.com> - 2016-12-12 12:10 +0100
    [PATCH v4 1/5] thermal: rockchip: improve conversion error messages Caesar Wang <wxt@rock-chips.com> - 2016-12-12 12:10 +0100
    Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal ayaka <ayaka@soulik.info> - 2016-12-30 17:20 +0100
      Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal Caesar Wang <wxt@rock-chips.com> - 2017-01-02 14:20 +0100
        Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal Randy Li <randy.li@rock-chips.com> - 2017-01-03 01:00 +0100
          Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal Caesar Wang <sasukewxt@163.com> - 2017-01-03 02:10 +0100
            Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal Randy Li <randy.li@rock-chips.com> - 2017-01-03 02:20 +0100
              Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal ayaka <ayaka@soulik.info> - 2017-01-03 17:40 +0100

#1540276 — [PATCH v4 0/5] thermal: fixes the rockchip thermal

There are five patches posted for upstream.
89267b5 thermal: rockchip: improve conversion error messages
a0b5649 thermal: rockchip: don't pass table structs by value
bceed92 thermal: rockchip: fixes invalid temperature case
30be6d0 thermal: rockchip: optimize the conversion table
35636e9 thermal: rockchip: handle the set_trips without the trip points.
--

History version:
V1:
https://lkml.org/lkml/2016/11/22/250
V2:
https://lkml.org/lkml/2016/11/23/348
V3:
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1281432.html
---

Brain posted the below patches for upstream.
89267b5 thermal: rockchip: improve conversion error messages
a0b5649 thermal: rockchip: don't pass table structs by value
That make sense to improve efficiency

Caesar post the below patches for upstream.
bceed92 thermal: rockchip: fixes invalid temperature case
30be6d0 thermal: rockchip: optimize the conversion table
35636e9 thermal: rockchip: handle the set_trips without the trip points.
That will fixes some issues in special cases.
--

Anyway, this series patches should can improve the rockchip thermal driver.


Changes in v4:
- As Eduardo and Brian commnets on
  https://patchwork.kernel.org/patch/9449301
- Print a better name.
- As Eduardo commented on https://patchwork.kernel.org/patch/9449313/
- remove the Brain's review for previous version, since the new version
  update something.

Changes in v3:
- fix trivial thing for error message nd return value.
- change the commit.
- Fixes something as Brian comments on

Changes in v2:
- As Brian commnets that restructure this to pass error codes back to the
  upper layers.
- Improve the commit message.
- improve the commit as Brian commnets on https://patchwork.kernel.org/patch/9440985
- Fixes something as Brian comments on
  https://patchwork.kernel.org/patch/9440989.

Changes in v1:
- The original Brian posted on https://patchwork.kernel.org/patch/9437686
  Note: it'd probably be even nicer to know which sensor this was, but we've
  kinda abstracted that one away by this point...
- The original Brian posted on https://patchwork.kernel.org/patch/9437687

Brian Norris (2):
  thermal: rockchip: improve conversion error messages
  thermal: rockchip: don't pass table structs by value

Caesar Wang (3):
  thermal: rockchip: fixes invalid temperature case
  thermal: rockchip: optimize the conversion table
  thermal: rockchip: handle set_trips without the trip points

 drivers/thermal/rockchip_thermal.c | 153 ++++++++++++++++++++++++-------------
 1 file changed, 100 insertions(+), 53 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1540277 — [PATCH v4 1/5] thermal: rockchip: improve conversion error messages

From: Brian Norris <briannorris@chromium.org>

These error messages don't give much information about what went wrong.
It would be nice, for one, to see what invalid temperature was being
requested when conversion fails. It's also good to return an error when
we can't handle a conversion properly.

While we're at it, fix the grammar too.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

Changes in v4:
- As Eduardo and Brian commnets on
  https://patchwork.kernel.org/patch/9449301

Changes in v3: None
Changes in v2: None
Changes in v1:
- The original Brian posted on https://patchwork.kernel.org/patch/9437686
  Note: it'd probably be even nicer to know which sensor this was, but we've
  kinda abstracted that one away by this point...

 drivers/thermal/rockchip_thermal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index b811b0f..3bbc97c 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table,
 	}
 
 exit:
-	pr_err("Invalid the conversion, error=%d\n", error);
+	pr_err("%s: invalid temperature, temp=%d error=%d\n",
+	       __func__, temp, error);
 	return error;
 }
 
@@ -475,7 +476,8 @@ static int rk_tsadcv2_code_to_temp(struct chip_tsadc_table table, u32 code,
 		}
 		break;
 	default:
-		pr_err("Invalid the conversion table\n");
+		pr_err("%s: unknown table mode: %d\n", __func__, table.mode);
+		return -EINVAL;
 	}
 
 	/*
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1548653

BTW, Caesar have you ever met this at RK3288 at booting time?
[    8.430582] thermal thermal_zone1: critical temperature reached(125 
C),shutting down
[    8.439038] thermal thermal_zone2: critical temperature reached(125 
C),shutting down
[    8.456344] thermal thermal_zone1: critical temperature reached(125 
C),shutting down
[    8.465298] thermal thermal_zone2: critical temperature reached(125 
C),shutting down

On 12/12/2016 07:05 PM, Caesar Wang wrote:
> There are five patches posted for upstream.
> 89267b5 thermal: rockchip: improve conversion error messages
> a0b5649 thermal: rockchip: don't pass table structs by value
> bceed92 thermal: rockchip: fixes invalid temperature case
> 30be6d0 thermal: rockchip: optimize the conversion table
> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
> --
>
> History version:
> V1:
> https://lkml.org/lkml/2016/11/22/250
> V2:
> https://lkml.org/lkml/2016/11/23/348
> V3:
> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1281432.html
> ---
>
> Brain posted the below patches for upstream.
> 89267b5 thermal: rockchip: improve conversion error messages
> a0b5649 thermal: rockchip: don't pass table structs by value
> That make sense to improve efficiency
>
> Caesar post the below patches for upstream.
> bceed92 thermal: rockchip: fixes invalid temperature case
> 30be6d0 thermal: rockchip: optimize the conversion table
> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
> That will fixes some issues in special cases.
> --
>
> Anyway, this series patches should can improve the rockchip thermal driver.
>
>
> Changes in v4:
> - As Eduardo and Brian commnets on
>    https://patchwork.kernel.org/patch/9449301
> - Print a better name.
> - As Eduardo commented on https://patchwork.kernel.org/patch/9449313/
> - remove the Brain's review for previous version, since the new version
>    update something.
>
> Changes in v3:
> - fix trivial thing for error message nd return value.
> - change the commit.
> - Fixes something as Brian comments on
>
> Changes in v2:
> - As Brian commnets that restructure this to pass error codes back to the
>    upper layers.
> - Improve the commit message.
> - improve the commit as Brian commnets on https://patchwork.kernel.org/patch/9440985
> - Fixes something as Brian comments on
>    https://patchwork.kernel.org/patch/9440989.
>
> Changes in v1:
> - The original Brian posted on https://patchwork.kernel.org/patch/9437686
>    Note: it'd probably be even nicer to know which sensor this was, but we've
>    kinda abstracted that one away by this point...
> - The original Brian posted on https://patchwork.kernel.org/patch/9437687
>
> Brian Norris (2):
>    thermal: rockchip: improve conversion error messages
>    thermal: rockchip: don't pass table structs by value
>
> Caesar Wang (3):
>    thermal: rockchip: fixes invalid temperature case
>    thermal: rockchip: optimize the conversion table
>    thermal: rockchip: handle set_trips without the trip points
>
>   drivers/thermal/rockchip_thermal.c | 153 ++++++++++++++++++++++++-------------
>   1 file changed, 100 insertions(+), 53 deletions(-)
>

[toc] | [prev] | [next] | [standalone]

#1549170

在 2016年12月31日 00:11, ayaka 写道:
>
> BTW, Caesar have you ever met this at RK3288 at booting time?
> [    8.430582] thermal thermal_zone1: critical temperature reached(125 
> C),shutting down
> [    8.439038] thermal thermal_zone2: critical temperature reached(125 
> C),shutting down
> [    8.456344] thermal thermal_zone1: critical temperature reached(125 
> C),shutting down
> [    8.465298] thermal thermal_zone2: critical temperature reached(125 
> C),shutting down

125C? the thermal zone isn't the upstream kernel, what's the kernel 
version?
Anyway, look like,  the TSHUT issue. Do you have the below patches for 
your linux kernel?
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html


-Caesar

>
> On 12/12/2016 07:05 PM, Caesar Wang wrote:
>> There are five patches posted for upstream.
>> 89267b5 thermal: rockchip: improve conversion error messages
>> a0b5649 thermal: rockchip: don't pass table structs by value
>> bceed92 thermal: rockchip: fixes invalid temperature case
>> 30be6d0 thermal: rockchip: optimize the conversion table
>> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
>> -- 
>>
>> History version:
>> V1:
>> https://lkml.org/lkml/2016/11/22/250
>> V2:
>> https://lkml.org/lkml/2016/11/23/348
>> V3:
>> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1281432.html
>> ---
>>
>> Brain posted the below patches for upstream.
>> 89267b5 thermal: rockchip: improve conversion error messages
>> a0b5649 thermal: rockchip: don't pass table structs by value
>> That make sense to improve efficiency
>>
>> Caesar post the below patches for upstream.
>> bceed92 thermal: rockchip: fixes invalid temperature case
>> 30be6d0 thermal: rockchip: optimize the conversion table
>> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
>> That will fixes some issues in special cases.
>> -- 
>>
>> Anyway, this series patches should can improve the rockchip thermal 
>> driver.
>>
>>
>> Changes in v4:
>> - As Eduardo and Brian commnets on
>>    https://patchwork.kernel.org/patch/9449301
>> - Print a better name.
>> - As Eduardo commented on https://patchwork.kernel.org/patch/9449313/
>> - remove the Brain's review for previous version, since the new version
>>    update something.
>>
>> Changes in v3:
>> - fix trivial thing for error message nd return value.
>> - change the commit.
>> - Fixes something as Brian comments on
>>
>> Changes in v2:
>> - As Brian commnets that restructure this to pass error codes back to 
>> the
>>    upper layers.
>> - Improve the commit message.
>> - improve the commit as Brian commnets on 
>> https://patchwork.kernel.org/patch/9440985
>> - Fixes something as Brian comments on
>>    https://patchwork.kernel.org/patch/9440989.
>>
>> Changes in v1:
>> - The original Brian posted on 
>> https://patchwork.kernel.org/patch/9437686
>>    Note: it'd probably be even nicer to know which sensor this was, 
>> but we've
>>    kinda abstracted that one away by this point...
>> - The original Brian posted on 
>> https://patchwork.kernel.org/patch/9437687
>>
>> Brian Norris (2):
>>    thermal: rockchip: improve conversion error messages
>>    thermal: rockchip: don't pass table structs by value
>>
>> Caesar Wang (3):
>>    thermal: rockchip: fixes invalid temperature case
>>    thermal: rockchip: optimize the conversion table
>>    thermal: rockchip: handle set_trips without the trip points
>>
>>   drivers/thermal/rockchip_thermal.c | 153 
>> ++++++++++++++++++++++++-------------
>>   1 file changed, 100 insertions(+), 53 deletions(-)
>>
>
>
>
>

[toc] | [prev] | [next] | [standalone]

#1549463

On 01/02/2017 09:16 PM, Caesar Wang wrote:
> 在 2016年12月31日 00:11, ayaka 写道:
>>
>> BTW, Caesar have you ever met this at RK3288 at booting time?
>> [    8.430582] thermal thermal_zone1: critical temperature 
>> reached(125 C),shutting down
>> [    8.439038] thermal thermal_zone2: critical temperature 
>> reached(125 C),shutting down
>> [    8.456344] thermal thermal_zone1: critical temperature 
>> reached(125 C),shutting down
>> [    8.465298] thermal thermal_zone2: critical temperature 
>> reached(125 C),shutting down
>
> 125C? the thermal zone isn't the upstream kernel, what's the kernel 
> version?
They have been merged into the linux-next.
> Anyway, look like,  the TSHUT issue. Do you have the below patches for 
> your linux kernel?
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html 
>
No, could you resubmit those patches ?
>
>
> -Caesar
>
>>
>> On 12/12/2016 07:05 PM, Caesar Wang wrote:
>>> There are five patches posted for upstream.
>>> 89267b5 thermal: rockchip: improve conversion error messages
>>> a0b5649 thermal: rockchip: don't pass table structs by value
>>> bceed92 thermal: rockchip: fixes invalid temperature case
>>> 30be6d0 thermal: rockchip: optimize the conversion table
>>> 35636e9 thermal: rockchip: handle the set_trips without the trip 
>>> points.
>>> -- 
>>>
>>> History version:
>>> V1:
>>> https://lkml.org/lkml/2016/11/22/250
>>> V2:
>>> https://lkml.org/lkml/2016/11/23/348
>>> V3:
>>> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1281432.html 
>>>
>>> ---
>>>
>>> Brain posted the below patches for upstream.
>>> 89267b5 thermal: rockchip: improve conversion error messages
>>> a0b5649 thermal: rockchip: don't pass table structs by value
>>> That make sense to improve efficiency
>>>
>>> Caesar post the below patches for upstream.
>>> bceed92 thermal: rockchip: fixes invalid temperature case
>>> 30be6d0 thermal: rockchip: optimize the conversion table
>>> 35636e9 thermal: rockchip: handle the set_trips without the trip 
>>> points.
>>> That will fixes some issues in special cases.
>>> -- 
>>>
>>> Anyway, this series patches should can improve the rockchip thermal 
>>> driver.
>>>
>>>
>>> Changes in v4:
>>> - As Eduardo and Brian commnets on
>>>    https://patchwork.kernel.org/patch/9449301
>>> - Print a better name.
>>> - As Eduardo commented on https://patchwork.kernel.org/patch/9449313/
>>> - remove the Brain's review for previous version, since the new version
>>>    update something.
>>>
>>> Changes in v3:
>>> - fix trivial thing for error message nd return value.
>>> - change the commit.
>>> - Fixes something as Brian comments on
>>>
>>> Changes in v2:
>>> - As Brian commnets that restructure this to pass error codes back 
>>> to the
>>>    upper layers.
>>> - Improve the commit message.
>>> - improve the commit as Brian commnets on 
>>> https://patchwork.kernel.org/patch/9440985
>>> - Fixes something as Brian comments on
>>>    https://patchwork.kernel.org/patch/9440989.
>>>
>>> Changes in v1:
>>> - The original Brian posted on 
>>> https://patchwork.kernel.org/patch/9437686
>>>    Note: it'd probably be even nicer to know which sensor this was, 
>>> but we've
>>>    kinda abstracted that one away by this point...
>>> - The original Brian posted on 
>>> https://patchwork.kernel.org/patch/9437687
>>>
>>> Brian Norris (2):
>>>    thermal: rockchip: improve conversion error messages
>>>    thermal: rockchip: don't pass table structs by value
>>>
>>> Caesar Wang (3):
>>>    thermal: rockchip: fixes invalid temperature case
>>>    thermal: rockchip: optimize the conversion table
>>>    thermal: rockchip: handle set_trips without the trip points
>>>
>>>   drivers/thermal/rockchip_thermal.c | 153 
>>> ++++++++++++++++++++++++-------------
>>>   1 file changed, 100 insertions(+), 53 deletions(-)
>>>
>>
>>
>>
>>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

[toc] | [prev] | [next] | [standalone]

#1549483

在 2017年01月03日 07:57, Randy Li 写道:
>
> On 01/02/2017 09:16 PM, Caesar Wang wrote:
>> 在 2016年12月31日 00:11, ayaka 写道:
>>>
>>> BTW, Caesar have you ever met this at RK3288 at booting time?
>>> [    8.430582] thermal thermal_zone1: critical temperature 
>>> reached(125 C),shutting down
>>> [    8.439038] thermal thermal_zone2: critical temperature 
>>> reached(125 C),shutting down
>>> [    8.456344] thermal thermal_zone1: critical temperature 
>>> reached(125 C),shutting down
>>> [    8.465298] thermal thermal_zone2: critical temperature 
>>> reached(125 C),shutting down
>>
>> 125C? the thermal zone isn't the upstream kernel, what's the kernel 
>> version?
> They have been merged into the linux-next.

Really?
I saw the 90 degree is the critical temperature on rk3288 dts .
kernel$ vi arch/arm/boot/dts/rk3288.dtsi
             cpu_crit: cpu_crit {
                     temperature = <90000>; /* millicelsius */
                     hysteresis = <2000>; /* millicelsius */
                     type = "critical";
                 };

>> Anyway, look like,  the TSHUT issue. Do you have the below patches 
>> for your linux kernel?
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html 
>>
> No, could you resubmit those patches ?

These patches had merged for upstream.

-Caesar

[toc] | [prev] | [next] | [standalone]

#1549484

On 01/03/2017 09:02 AM, Caesar Wang wrote:
>
> 在 2017年01月03日 07:57, Randy Li 写道:
>>
>> On 01/02/2017 09:16 PM, Caesar Wang wrote:
>>> 在 2016年12月31日 00:11, ayaka 写道:
>>>>
>>>> BTW, Caesar have you ever met this at RK3288 at booting time?
>>>> [    8.430582] thermal thermal_zone1: critical temperature
>>>> reached(125 C),shutting down
>>>> [    8.439038] thermal thermal_zone2: critical temperature
>>>> reached(125 C),shutting down
>>>> [    8.456344] thermal thermal_zone1: critical temperature
>>>> reached(125 C),shutting down
>>>> [    8.465298] thermal thermal_zone2: critical temperature
>>>> reached(125 C),shutting down
>>>
>>> 125C? the thermal zone isn't the upstream kernel, what's the kernel
>>> version?
>> They have been merged into the linux-next.
>
> Really?
> I saw the 90 degree is the critical temperature on rk3288 dts .
Yes I do.
> kernel$ vi arch/arm/boot/dts/rk3288.dtsi
>             cpu_crit: cpu_crit {
>                     temperature = <90000>; /* millicelsius */
>                     hysteresis = <2000>; /* millicelsius */
>                     type = "critical";
>                 };
>
>>> Anyway, look like,  the TSHUT issue. Do you have the below patches
>>> for your linux kernel?
>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html
>>>
>> No, could you resubmit those patches ?
>
> These patches had merged for upstream.
Sorry, it is my fault, I mistake that commit. Those patches are merged 
in next-20161224. I would bring a board for you later.
>
> -Caesar
>
>

-- 
Randy Li
The third produce department
===========================================================================
This email message, including any attachments, is for the sole
use of the intended recipient(s) and may contain confidential and
privileged information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient, please
contact the sender by reply e-mail and destroy all copies of the original
message. [Fuzhou Rockchip Electronics, INC. China mainland]
===========================================================================

[toc] | [prev] | [next] | [standalone]

#1549935

On 01/03/2017 09:13 AM, Randy Li wrote:
>
>
> On 01/03/2017 09:02 AM, Caesar Wang wrote:
>>
>> 在 2017年01月03日 07:57, Randy Li 写道:
>>>
>>> On 01/02/2017 09:16 PM, Caesar Wang wrote:
>>>> 在 2016年12月31日 00:11, ayaka 写道:
>>>>>
>>>>> BTW, Caesar have you ever met this at RK3288 at booting time?
>>>>> [    8.430582] thermal thermal_zone1: critical temperature
>>>>> reached(125 C),shutting down
>>>>> [    8.439038] thermal thermal_zone2: critical temperature
>>>>> reached(125 C),shutting down
>>>>> [    8.456344] thermal thermal_zone1: critical temperature
>>>>> reached(125 C),shutting down
>>>>> [    8.465298] thermal thermal_zone2: critical temperature
>>>>> reached(125 C),shutting down
>>>>
>>>> 125C? the thermal zone isn't the upstream kernel, what's the kernel
>>>> version?
>>> They have been merged into the linux-next.
>>
>> Really?
>> I saw the 90 degree is the critical temperature on rk3288 dts .
> Yes I do.
>> kernel$ vi arch/arm/boot/dts/rk3288.dtsi
>>             cpu_crit: cpu_crit {
>>                     temperature = <90000>; /* millicelsius */
>>                     hysteresis = <2000>; /* millicelsius */
>>                     type = "critical";
>>                 };
>>
>>>> Anyway, look like,  the TSHUT issue. Do you have the below patches
>>>> for your linux kernel?
>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html 
>>>>
>>>>
>>> No, could you resubmit those patches ?
>>
>> These patches had merged for upstream.
> Sorry, it is my fault, I mistake that commit. Those patches are merged 
> in next-20161224. I would bring a board for you later.
I check the schematic, the otp interrupt is not used at firefly reload 
nor connected to the control of PMIC.
I also check power supply, the power is PD_PERI domain comes from 
VD_LOGIC which is always on all the platform.
It more likely the tsadc doesn't report correctly temperature value?
>>
>> -Caesar
>>
>>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web