Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544764 > unrolled thread

[PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

Back to article view | Back to linux.kernel

Contents

  [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-12-19 21:50 +0100
    Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-02 23:20 +0100
      Re: [PATCH] PM / docs: Drop confusing kernel-doc references from  infrastructure.rst Jonathan Corbet <corbet@lwn.net> - 2017-01-02 23:50 +0100
        Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-02 23:50 +0100

#1544764 — [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The references to drivers/base/power/main.c and
drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst
are confusing.  They both cause descriptions of functions that are
not relevant to device drivers at all to be generated and none of
them is sufficient to cover the API in a meaningful way.

Drop them for now.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 Documentation/driver-api/infrastructure.rst |   15 ---------------
 1 file changed, 15 deletions(-)

Index: linux-pm/Documentation/driver-api/infrastructure.rst
===================================================================
--- linux-pm.orig/Documentation/driver-api/infrastructure.rst
+++ linux-pm/Documentation/driver-api/infrastructure.rst
@@ -55,21 +55,6 @@ Device Drivers DMA Management
 .. kernel-doc:: drivers/base/dma-mapping.c
    :export:
 
-Device Drivers Power Management
--------------------------------
-
-.. kernel-doc:: drivers/base/power/main.c
-   :export:
-
-Device Drivers ACPI Support
----------------------------
-
-.. kernel-doc:: drivers/acpi/scan.c
-   :export:
-
-.. kernel-doc:: drivers/acpi/scan.c
-   :internal:
-
 Device drivers PnP support
 --------------------------
 

[toc] | [next] | [standalone]

#1549419

On Monday, December 19, 2016 09:36:39 PM Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The references to drivers/base/power/main.c and
> drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst
> are confusing.  They both cause descriptions of functions that are
> not relevant to device drivers at all to be generated and none of
> them is sufficient to cover the API in a meaningful way.
> 
> Drop them for now.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

I'd like this to go into 4.10.

Are there any objections here?

> ---
>  Documentation/driver-api/infrastructure.rst |   15 ---------------
>  1 file changed, 15 deletions(-)
> 
> Index: linux-pm/Documentation/driver-api/infrastructure.rst
> ===================================================================
> --- linux-pm.orig/Documentation/driver-api/infrastructure.rst
> +++ linux-pm/Documentation/driver-api/infrastructure.rst
> @@ -55,21 +55,6 @@ Device Drivers DMA Management
>  .. kernel-doc:: drivers/base/dma-mapping.c
>     :export:
>  
> -Device Drivers Power Management
> --------------------------------
> -
> -.. kernel-doc:: drivers/base/power/main.c
> -   :export:
> -
> -Device Drivers ACPI Support
> ----------------------------
> -
> -.. kernel-doc:: drivers/acpi/scan.c
> -   :export:
> -
> -.. kernel-doc:: drivers/acpi/scan.c
> -   :internal:
> -
>  Device drivers PnP support
>  --------------------------
>  
> 
> --

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1549426 — Re: [PATCH] PM / docs: Drop confusing kernel-doc references from infrastructure.rst

On Mon, 02 Jan 2017 23:05:31 +0100
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:

> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > The references to drivers/base/power/main.c and
> > drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst
> > are confusing.  They both cause descriptions of functions that are
> > not relevant to device drivers at all to be generated and none of
> > them is sufficient to cover the API in a meaningful way.
> > 
> > Drop them for now.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>  
> 
> I'd like this to go into 4.10.
> 
> Are there any objections here?

None here.  Sorry, somehow I failed to see this when I was putting
together the fixes to send a few days ago.  If you want to include it in
a batch of yours, feel free to do so with my ack; otherwise I can ship it
Linusward in a bit.

Thanks,

jon

[toc] | [prev] | [next] | [standalone]

#1549427

On Monday, January 02, 2017 03:39:20 PM Jonathan Corbet wrote:
> On Mon, 02 Jan 2017 23:05:31 +0100
> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> 
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > 
> > > The references to drivers/base/power/main.c and
> > > drivers/acpi/scan.c from Documentation/driver-api/infrastructure.rst
> > > are confusing.  They both cause descriptions of functions that are
> > > not relevant to device drivers at all to be generated and none of
> > > them is sufficient to cover the API in a meaningful way.
> > > 
> > > Drop them for now.
> > > 
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>  
> > 
> > I'd like this to go into 4.10.
> > 
> > Are there any objections here?
> 
> None here.  Sorry, somehow I failed to see this when I was putting
> together the fixes to send a few days ago.  If you want to include it in
> a batch of yours, feel free to do so with my ack; otherwise I can ship it
> Linusward in a bit.

Thanks!

I'll be sending a PM pull request in a couple of days, so I'll include this one.

Cheers,
Rafael

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web