Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1544212 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2016-12-18 23:30 +0100 |
| Last post | 2017-01-02 10:50 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] USB: cypress_m8: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-12-18 23:30 +0100
Re: [PATCH] USB: cypress_m8: remove unused variable Johan Hovold <johan@kernel.org> - 2016-12-19 12:10 +0100
Re: [PATCH] USB: cypress_m8: remove unused variable Johan Hovold <johan@kernel.org> - 2017-01-02 10:50 +0100
Re: [PATCH] USB: cypress_m8: remove unused variable Johan Hovold <johan@kernel.org> - 2017-01-02 10:50 +0100
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2016-12-18 23:30 +0100 |
| Subject | [PATCH] USB: cypress_m8: remove unused variable |
| Message-ID | <sPS7T-7KN-19@gated-at.bofh.it> |
The variable havedata was only being set but never used afterwards. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- drivers/usb/serial/cypress_m8.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c index bbeeb2b..90110de 100644 --- a/drivers/usb/serial/cypress_m8.c +++ b/drivers/usb/serial/cypress_m8.c @@ -1069,7 +1069,6 @@ static void cypress_read_int_callback(struct urb *urb) unsigned char *data = urb->transfer_buffer; unsigned long flags; char tty_flag = TTY_NORMAL; - int havedata = 0; int bytes = 0; int result; int i = 0; @@ -1118,16 +1117,12 @@ static void cypress_read_int_callback(struct urb *urb) priv->current_status = data[0] & 0xF8; bytes = data[1] + 2; i = 2; - if (bytes > 2) - havedata = 1; break; case packet_format_2: /* This is for the CY7C63743... */ priv->current_status = data[0] & 0xF8; bytes = (data[0] & 0x07) + 1; i = 1; - if (bytes > 1) - havedata = 1; break; } spin_unlock_irqrestore(&priv->lock, flags); -- 1.9.1
[toc] | [next] | [standalone]
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2016-12-19 12:10 +0100 |
| Message-ID | <sQ3Zn-6VK-11@gated-at.bofh.it> |
| In reply to | #1544212 |
On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote: > The variable havedata was only being set but never used afterwards. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Thanks, I'll queue this up for 4.11. Johan
[toc] | [prev] | [next] | [standalone]
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2017-01-02 10:50 +0100 |
| Message-ID | <sV7pD-4Sp-7@gated-at.bofh.it> |
| In reply to | #1544463 |
On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote: > On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote: > > The variable havedata was only being set but never used afterwards. > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > Thanks, I'll queue this up for 4.11. Now applied, thanks. Johan
[toc] | [prev] | [next] | [standalone]
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2017-01-02 10:50 +0100 |
| Message-ID | <sV7pE-4Sp-19@gated-at.bofh.it> |
| In reply to | #1549076 |
On Mon, Jan 02, 2017 at 10:41:03AM +0100, Johan Hovold wrote: > On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote: > > On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote: > > > The variable havedata was only being set but never used afterwards. > > > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > > > Thanks, I'll queue this up for 4.11. > > Now applied, thanks. Oh, wait. Please resend this one and make sure your From (author) address matches your Signed-off-by tag. Thanks, Johan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web