Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543273 > unrolled thread

[PATCH] gpio: mxs: remove __init annotation

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpio: mxs: remove __init annotation Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:10 +0100
    Re: [PATCH] gpio: mxs: remove __init annotation Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 09:10 +0100

#1543273 — [PATCH] gpio: mxs: remove __init annotation

Building with an old toolchain, I ran into this warning:

WARNING: vmlinux.o(.text+0x63eef0): Section mismatch in reference from the function mxs_gpio_probe() to the function .init.text:mxs_gpio_init_gc()

Clearly the annotation is wrong, since the function is called from the
non-init probe, so let's remove it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/gpio-mxs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index 1e8fde8cb803..2292742eac8f 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -205,7 +205,7 @@ static int mxs_gpio_set_wake_irq(struct irq_data *d, unsigned int enable)
 	return 0;
 }
 
-static int __init mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
+static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
 {
 	struct irq_chip_generic *gc;
 	struct irq_chip_type *ct;
-- 
2.9.0

[toc] | [next] | [standalone]

#1548488

On Fri, Dec 16, 2016 at 10:08 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> Building with an old toolchain, I ran into this warning:
>
> WARNING: vmlinux.o(.text+0x63eef0): Section mismatch in reference from the function mxs_gpio_probe() to the function .init.text:mxs_gpio_init_gc()
>
> Clearly the annotation is wrong, since the function is called from the
> non-init probe, so let's remove it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied for fixes.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web