Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1545059 > unrolled thread

[PATCH 0/3] gpio: mockup: bug fixes and tweaks

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] gpio: mockup: bug fixes and tweaks Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-12-20 12:30 +0100
    [PATCH 1/3] gpio: mockup: make pins_name_start static Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-12-20 12:30 +0100
      Re: [PATCH 1/3] gpio: mockup: make pins_name_start static Linus Walleij <linus.walleij@linaro.org> - 2016-12-28 14:20 +0100

#1545059 — [PATCH 0/3] gpio: mockup: bug fixes and tweaks

While trying to use the gpio-mockup driver for testing purposes I
noticed there's an issue with the gpiochip's label. It turned out
the label pointer points to invalid memory area. This series fixes
it and adds some minor changes in other places too.

Bartosz Golaszewski (3):
  gpio: mockup: make pins_name_start static
  gpio: mockup: dynamically allocate memory for chip name
  gpio: mockup: coding style fixes

 drivers/gpio/gpio-mockup.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

-- 
2.9.3

[toc] | [next] | [standalone]

#1545060 — [PATCH 1/3] gpio: mockup: make pins_name_start static

This variable is not used outside this module. Make it static.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpio-mockup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 1ef85b0..af0c1e8 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -43,7 +43,7 @@ static int gpio_mockup_ranges[MAX_GC << 1];
 static int gpio_mockup_params_nr;
 module_param_array(gpio_mockup_ranges, int, &gpio_mockup_params_nr, 0400);
 
-const char pins_name_start = 'A';
+static const char pins_name_start = 'A';
 
 static int mockup_gpio_get(struct gpio_chip *gc, unsigned int offset)
 {
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1547952 — Re: [PATCH 1/3] gpio: mockup: make pins_name_start static

On Tue, Dec 20, 2016 at 12:28 PM, Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:

> This variable is not used outside this module. Make it static.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web