Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1547928 > unrolled thread

[PATCH v2 0/3] PM / devfreq: Fix the bug and add reviewer for devfreq support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 0/3] PM / devfreq: Fix the bug and add reviewer for devfreq  support Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-28 13:00 +0100
    [PATCH v2 2/3] PM / devfreq: Fix the bug of devfreq_add_device when  governor is NULL Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-28 13:00 +0100
    Re: [PATCH v2 0/3] PM / devfreq: Fix the bug and add reviewer for  devfreq support Chanwoo Choi <cwchoi00@gmail.com> - 2017-01-03 13:00 +0100

#1547928 — [PATCH v2 0/3] PM / devfreq: Fix the bug and add reviewer for devfreq support

This patches fix the bug of devfreq_add_device() when governor name is wrong
and the wrong return value of probe() function for exynos_bus.c driver.

And I've been helping reviewing and tesing the devfreq support patches
for the couple of years. Also, I'm going to contribute the improvement
for devfreq subsystem. It would be easier for me for review if I'm cc'ed
for patches. So, patch1 adds myself as a reviewer for devfreq support.

Changes from v1:
(https://lkml.org/lkml/2016/12/15/122)
- Rebase these patches on v4.10-rc1.

Chanwoo Choi (3):
  MAINTAINERS: Add myself as reviewer for DEVFREQ subsystem support
  PM / devfreq: Fix the bug of devfreq_add_device when governor is NULL
  PM / devfreq: exynos-bus: Fix the wrong return value

 MAINTAINERS                  |  1 +
 drivers/devfreq/devfreq.c    | 15 ++++++++++-----
 drivers/devfreq/exynos-bus.c |  2 +-
 3 files changed, 12 insertions(+), 6 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1547932 — [PATCH v2 2/3] PM / devfreq: Fix the bug of devfreq_add_device when governor is NULL

This patch fixes the bug of devfreq_add_device(). The devfreq device must
have the default governor. If find_devfreq_governor() returns error,
devfreq_add_device() fail to add the devfreq instance.

Fixes: 1b5c1be2c88e ("PM / devfreq: map devfreq drivers to governor using name")
Cc: stable@vger.kernel.org
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/devfreq/devfreq.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a324801d6a66..47206a21bb90 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -593,11 +593,16 @@ struct devfreq *devfreq_add_device(struct device *dev,
 	list_add(&devfreq->node, &devfreq_list);
 
 	governor = find_devfreq_governor(devfreq->governor_name);
-	if (!IS_ERR(governor))
-		devfreq->governor = governor;
-	if (devfreq->governor)
-		err = devfreq->governor->event_handler(devfreq,
-					DEVFREQ_GOV_START, NULL);
+	if (IS_ERR(governor)) {
+		dev_err(dev, "%s: Unable to find governor for the device\n",
+			__func__);
+		err = PTR_ERR(governor);
+		goto err_init;
+	}
+
+	devfreq->governor = governor;
+	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
+						NULL);
 	if (err) {
 		dev_err(dev, "%s: Unable to start governor for the device\n",
 			__func__);
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1549724 — Re: [PATCH v2 0/3] PM / devfreq: Fix the bug and add reviewer for devfreq support

Dear Myungjoo,

Thanks for your review for patch1.
But, patch2/3 is not yet reviewed. Could you please review these patches?

2016-12-28 20:52 GMT+09:00 Chanwoo Choi <cw00.choi@samsung.com>:
> This patches fix the bug of devfreq_add_device() when governor name is wrong
> and the wrong return value of probe() function for exynos_bus.c driver.
>
> And I've been helping reviewing and tesing the devfreq support patches
> for the couple of years. Also, I'm going to contribute the improvement
> for devfreq subsystem. It would be easier for me for review if I'm cc'ed
> for patches. So, patch1 adds myself as a reviewer for devfreq support.
>
> Changes from v1:
> (https://lkml.org/lkml/2016/12/15/122)
> - Rebase these patches on v4.10-rc1.
>
> Chanwoo Choi (3):
>   MAINTAINERS: Add myself as reviewer for DEVFREQ subsystem support
>   PM / devfreq: Fix the bug of devfreq_add_device when governor is NULL
>   PM / devfreq: exynos-bus: Fix the wrong return value
>
>  MAINTAINERS                  |  1 +
>  drivers/devfreq/devfreq.c    | 15 ++++++++++-----
>  drivers/devfreq/exynos-bus.c |  2 +-
>  3 files changed, 12 insertions(+), 6 deletions(-)
>
> --
> 1.9.1
>



-- 
Best Regards,
Chanwoo Choi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web