Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1547257 > unrolled thread
| Started by | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| First post | 2016-12-26 06:30 +0100 |
| Last post | 2016-12-28 00:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-26 06:30 +0100
Re: [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-27 17:20 +0100
Re: [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-28 00:00 +0100
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-12-26 06:30 +0100 |
| Subject | [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe |
| Message-ID | <sSw1b-ou-15@gated-at.bofh.it> |
To use the generic PHY framework, adds the pcie_phy node.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 64226d5..2a15f18 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -805,6 +805,11 @@
reg = <0x145f0000 0x1038>;
};
+ syscon_fsys: syscon@156f0000 {
+ compatible = "syscon";
+ reg = <0x156f0000 0x1044>;
+ };
+
gsc_0: video-scaler@13C00000 {
compatible = "samsung,exynos5433-gsc";
reg = <0x13c00000 0x1000>;
@@ -1443,6 +1448,15 @@
status = "disabled";
};
};
+
+ pcie_phy: pcie-phy@15680000 {
+ #phy-cells = <0>;
+ compatible = "samsung,exynos5433-pcie-phy";
+ reg = <0x15680000 0x1000>;
+ samsung,pmureg-phandle = <&pmu_system_controller>;
+ samsung,fsys-sysreg = <&syscon_fsys>;
+ status = "okay";
+ };
};
timer: timer {
--
2.10.2
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-12-27 17:20 +0100 |
| Subject | Re: [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe |
| Message-ID | <sT2DM-4jR-33@gated-at.bofh.it> |
| In reply to | #1547257 |
On Mon, Dec 26, 2016 at 02:20:26PM +0900, Jaehoon Chung wrote:
> To use the generic PHY framework, adds the pcie_phy node.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 64226d5..2a15f18 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -805,6 +805,11 @@
> reg = <0x145f0000 0x1038>;
> };
>
> + syscon_fsys: syscon@156f0000 {
> + compatible = "syscon";
> + reg = <0x156f0000 0x1044>;
> + };
> +
> gsc_0: video-scaler@13C00000 {
> compatible = "samsung,exynos5433-gsc";
> reg = <0x13c00000 0x1000>;
> @@ -1443,6 +1448,15 @@
> status = "disabled";
> };
> };
> +
> + pcie_phy: pcie-phy@15680000 {
> + #phy-cells = <0>;
> + compatible = "samsung,exynos5433-pcie-phy";
Mostly we use the convention of compatible being first property.
> + reg = <0x15680000 0x1000>;
> + samsung,pmureg-phandle = <&pmu_system_controller>;
> + samsung,fsys-sysreg = <&syscon_fsys>;
> + status = "okay";
Why do you need to put status=okay here?
Best regards,
Krzysztof
> + };
> };
>
> timer: timer {
> --
> 2.10.2
>
[toc] | [prev] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-12-28 00:00 +0100 |
| Subject | Re: [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe |
| Message-ID | <sT8SS-8ai-1@gated-at.bofh.it> |
| In reply to | #1547672 |
On 12/28/2016 01:11 AM, Krzysztof Kozlowski wrote:
> On Mon, Dec 26, 2016 at 02:20:26PM +0900, Jaehoon Chung wrote:
>> To use the generic PHY framework, adds the pcie_phy node.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> index 64226d5..2a15f18 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>> @@ -805,6 +805,11 @@
>> reg = <0x145f0000 0x1038>;
>> };
>>
>> + syscon_fsys: syscon@156f0000 {
>> + compatible = "syscon";
>> + reg = <0x156f0000 0x1044>;
>> + };
>> +
>> gsc_0: video-scaler@13C00000 {
>> compatible = "samsung,exynos5433-gsc";
>> reg = <0x13c00000 0x1000>;
>> @@ -1443,6 +1448,15 @@
>> status = "disabled";
>> };
>> };
>> +
>> + pcie_phy: pcie-phy@15680000 {
>> + #phy-cells = <0>;
>> + compatible = "samsung,exynos5433-pcie-phy";
>
> Mostly we use the convention of compatible being first property.
>
>> + reg = <0x15680000 0x1000>;
>> + samsung,pmureg-phandle = <&pmu_system_controller>;
>> + samsung,fsys-sysreg = <&syscon_fsys>;
>> + status = "okay";
>
> Why do you need to put status=okay here?
Not need. Will remove.
Best Regards,
Jaehoon Chung
>
> Best regards,
> Krzysztof
>
>> + };
>> };
>>
>> timer: timer {
>> --
>> 2.10.2
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web