Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1547197 > unrolled thread
| Started by | Scott Matheina <scott@matheina.com> |
|---|---|
| First post | 2016-12-25 21:10 +0100 |
| Last post | 2016-12-25 21:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina <scott@matheina.com> - 2016-12-25 21:10 +0100
Re: [PATCHv4 2/8] Fixed variables not being consistently lower case kbuild test robot <lkp@intel.com> - 2016-12-25 21:30 +0100
| From | Scott Matheina <scott@matheina.com> |
|---|---|
| Date | 2016-12-25 21:10 +0100 |
| Subject | [PATCHv4 2/8] Fixed variables not being consistently lower case |
| Message-ID | <sSnhf-22f-9@gated-at.bofh.it> |
Across the file, variables were sometimes upper case, some times
lower case, this fix addresses a few of the instances with this
inconsistency.
Signed-off-by: Scott Matheina <scott@matheina.com>
---
drivers/staging/iio/addac/adt7316.c | 48 ++++++++++++++++++-------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 08413a8..13d9ed2 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -1755,55 +1755,55 @@ static irqreturn_t adt7316_event_handler(int irq, void *private)
time = iio_get_time_ns(indio_dev);
if (stat1 & BIT(0))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_RISING),
+ iio_unmod_event_code(iio_temp, 0,
+ iio_ev_type_thresh,
+ iio_ev_dir_rising),
time);
if (stat1 & BIT(1))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_FALLING),
+ iio_unmod_event_code(iio_temp, 0,
+ iio_ev_type_thresh,
+ iio_ev_dir_falling),
time);
if (stat1 & BIT(2))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_RISING),
+ iio_unmod_event_code(iio_temp, 1,
+ iio_ev_type_thresh,
+ iio_ev_dir_rising),
time);
if (stat1 & BIT(3))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_FALLING),
+ iio_unmod_event_code(iio_temp, 1,
+ iio_ev_type_thresh,
+ iio_ev_dir_falling),
time);
if (stat1 & BIT(5))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 1,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_EITHER),
+ iio_unmod_event_code(iio_voltage, 1,
+ iio_ev_type_thresh,
+ iio_ev_dir_either),
time);
if (stat1 & BIT(6))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 2,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_EITHER),
+ iio_unmod_event_code(iio_voltage, 2,
+ iio_ev_type_thresh,
+ iio_ev_dir_either),
time);
if (stat1 & BIT(7))
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 3,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_EITHER),
+ iio_unmod_event_code(iio_voltage, 3,
+ iio_ev_type_thresh,
+ iio_ev_dir_either),
time);
}
ret = chip->bus.read(chip->bus.client, ADT7316_INT_STAT2, &stat2);
if (!ret) {
if (stat2 & ADT7316_INT_MASK2_VDD)
iio_push_event(indio_dev,
- IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE,
+ iio_unmod_event_code(iio_voltage,
0,
- IIO_EV_TYPE_THRESH,
- IIO_EV_DIR_RISING),
+ iio_ev_type_thresh,
+ iio_ev_dir_rising),
iio_get_time_ns(indio_dev));
}
--
2.7.4
[toc] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2016-12-25 21:30 +0100 |
| Message-ID | <sSnAB-2cx-5@gated-at.bofh.it> |
| In reply to | #1547197 |
[Multipart message — attachments visible in raw view] — view raw
Hi Scott,
[auto build test ERROR on iio/togreg]
[also build test ERROR on v4.9 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio-addac/20161226-041021
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-randconfig-x001-201652 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/staging/iio/addac/adt7316.c: In function 'adt7316_event_handler':
>> drivers/staging/iio/addac/adt7316.c:1758:12: error: implicit declaration of function 'iio_unmod_event_code' [-Werror=implicit-function-declaration]
iio_unmod_event_code(iio_temp, 0,
^~~~~~~~~~~~~~~~~~~~
>> drivers/staging/iio/addac/adt7316.c:1758:33: error: 'iio_temp' undeclared (first use in this function)
iio_unmod_event_code(iio_temp, 0,
^~~~~~~~
drivers/staging/iio/addac/adt7316.c:1758:33: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/iio/addac/adt7316.c:1759:12: error: 'iio_ev_type_thresh' undeclared (first use in this function)
iio_ev_type_thresh,
^~~~~~~~~~~~~~~~~~
>> drivers/staging/iio/addac/adt7316.c:1760:12: error: 'iio_ev_dir_rising' undeclared (first use in this function)
iio_ev_dir_rising),
^~~~~~~~~~~~~~~~~
>> drivers/staging/iio/addac/adt7316.c:1766:12: error: 'iio_ev_dir_falling' undeclared (first use in this function)
iio_ev_dir_falling),
^~~~~~~~~~~~~~~~~~
>> drivers/staging/iio/addac/adt7316.c:1782:33: error: 'iio_voltage' undeclared (first use in this function)
iio_unmod_event_code(iio_voltage, 1,
^~~~~~~~~~~
>> drivers/staging/iio/addac/adt7316.c:1784:12: error: 'iio_ev_dir_either' undeclared (first use in this function)
iio_ev_dir_either),
^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/iio_unmod_event_code +1758 drivers/staging/iio/addac/adt7316.c
1752 if ((chip->id & ID_FAMILY_MASK) != ID_ADT75XX)
1753 stat1 &= 0x1F;
1754
1755 time = iio_get_time_ns(indio_dev);
1756 if (stat1 & BIT(0))
1757 iio_push_event(indio_dev,
> 1758 iio_unmod_event_code(iio_temp, 0,
> 1759 iio_ev_type_thresh,
> 1760 iio_ev_dir_rising),
1761 time);
1762 if (stat1 & BIT(1))
1763 iio_push_event(indio_dev,
1764 iio_unmod_event_code(iio_temp, 0,
1765 iio_ev_type_thresh,
> 1766 iio_ev_dir_falling),
1767 time);
1768 if (stat1 & BIT(2))
1769 iio_push_event(indio_dev,
1770 iio_unmod_event_code(iio_temp, 1,
1771 iio_ev_type_thresh,
1772 iio_ev_dir_rising),
1773 time);
1774 if (stat1 & BIT(3))
1775 iio_push_event(indio_dev,
1776 iio_unmod_event_code(iio_temp, 1,
1777 iio_ev_type_thresh,
1778 iio_ev_dir_falling),
1779 time);
1780 if (stat1 & BIT(5))
1781 iio_push_event(indio_dev,
> 1782 iio_unmod_event_code(iio_voltage, 1,
1783 iio_ev_type_thresh,
> 1784 iio_ev_dir_either),
1785 time);
1786 if (stat1 & BIT(6))
1787 iio_push_event(indio_dev,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web