Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1547577 > unrolled thread
| Started by | "Kweh, Hock Leong" <hock.leong.kweh@intel.com> |
|---|---|
| First post | 2016-12-27 13:10 +0100 |
| Last post | 2016-12-27 18:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-27 13:10 +0100
Re: [PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register Joao Pinto <Joao.Pinto@synopsys.com> - 2016-12-27 13:20 +0100
Re: [PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register David Miller <davem@davemloft.net> - 2016-12-27 18:40 +0100
| From | "Kweh, Hock Leong" <hock.leong.kweh@intel.com> |
|---|---|
| Date | 2016-12-27 13:10 +0100 |
| Subject | [PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register |
| Message-ID | <sSYJP-1QE-5@gated-at.bofh.it> |
From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> Fixing the gmac4 mdio write access to use MII_GMAC4_WRITE only instead of OR together with MII_WRITE. Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index fda01f7..b0344c2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -116,7 +116,7 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg, unsigned int mii_address = priv->hw->mii.addr; unsigned int mii_data = priv->hw->mii.data; - u32 value = MII_WRITE | MII_BUSY; + u32 value = MII_BUSY; value |= (phyaddr << priv->hw->mii.addr_shift) & priv->hw->mii.addr_mask; @@ -126,6 +126,8 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg, & priv->hw->mii.clk_csr_mask; if (priv->plat->has_gmac4) value |= MII_GMAC4_WRITE; + else + value |= MII_WRITE; /* Wait until any existing MII operation is complete */ if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Joao Pinto <Joao.Pinto@synopsys.com> |
|---|---|
| Date | 2016-12-27 13:20 +0100 |
| Subject | Re: [PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register |
| Message-ID | <sSYTv-1VT-1@gated-at.bofh.it> |
| In reply to | #1547577 |
Às 8:07 PM de 12/27/2016, Kweh, Hock Leong escreveu: > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> > > Fixing the gmac4 mdio write access to use MII_GMAC4_WRITE only instead of > OR together with MII_WRITE. > > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index fda01f7..b0344c2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -116,7 +116,7 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg, > unsigned int mii_address = priv->hw->mii.addr; > unsigned int mii_data = priv->hw->mii.data; > > - u32 value = MII_WRITE | MII_BUSY; > + u32 value = MII_BUSY; > > value |= (phyaddr << priv->hw->mii.addr_shift) > & priv->hw->mii.addr_mask; > @@ -126,6 +126,8 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg, > & priv->hw->mii.clk_csr_mask; > if (priv->plat->has_gmac4) > value |= MII_GMAC4_WRITE; > + else > + value |= MII_WRITE; > > /* Wait until any existing MII operation is complete */ > if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) > Acked-By: Joao Pinto <jpinto@synopsys.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-12-27 18:40 +0100 |
| Subject | Re: [PATCH] net: stmmac: fix incorrect bit set in gmac4 mdio addr register |
| Message-ID | <sT3Tc-53g-19@gated-at.bofh.it> |
| In reply to | #1547577 |
From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> Date: Wed, 28 Dec 2016 04:07:41 +0800 > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> > > Fixing the gmac4 mdio write access to use MII_GMAC4_WRITE only instead of > OR together with MII_WRITE. > > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web