Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1546652 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-12-23 01:00 +0100 |
| Last post | 2016-12-23 06:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc Colin King <colin.king@canonical.com> - 2016-12-23 01:00 +0100
Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc John Crispin <john@phrozen.org> - 2016-12-23 06:40 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-12-23 01:00 +0100 |
| Subject | [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc |
| Message-ID | <sRlrb-7DS-7@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com> ralink_soc sould be assigned to RT3883_SOC, replace incorrect comparision with assignment. Signed-off-by: Colin Ian King <colin.king@canonical.com> --- arch/mips/ralink/rt3883.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c index 141c597..f869052 100644 --- a/arch/mips/ralink/rt3883.c +++ b/arch/mips/ralink/rt3883.c @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info) rt2880_pinmux_data = rt3883_pinmux_data; - ralink_soc == RT3883_SOC; + ralink_soc = RT3883_SOC; } -- 2.10.2
[toc] | [next] | [standalone]
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2016-12-23 06:40 +0100 |
| Message-ID | <sRqKd-2KX-1@gated-at.bofh.it> |
| In reply to | #1546652 |
On 23/12/2016 00:52, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > ralink_soc sould be assigned to RT3883_SOC, replace incorrect > comparision with assignment. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: John Crispin <john@phrozen.org> i thought i had sent this fix upstream ages ago. luckily this bug never caused any error as none of the code checking ralink_soc checks for rt3883. its used for the rt3x5x family. John > --- > arch/mips/ralink/rt3883.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c > index 141c597..f869052 100644 > --- a/arch/mips/ralink/rt3883.c > +++ b/arch/mips/ralink/rt3883.c > @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info) > > rt2880_pinmux_data = rt3883_pinmux_data; > > - ralink_soc == RT3883_SOC; > + ralink_soc = RT3883_SOC; > } > his
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web