Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1546750 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-12-23 05:50 +0100 |
| Last post | 2016-12-24 07:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-12-23 05:50 +0100
Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing Jiri Olsa <jolsa@redhat.com> - 2016-12-23 12:10 +0100
Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-12-24 07:30 +0100
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-12-23 05:50 +0100 |
| Subject | [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing |
| Message-ID | <sRpXP-2a2-1@gated-at.bofh.it> |
The top-level Makefile defines:
CPP = $(CC) -E
So, $(CC) -E can be replaced with $(CPP) and this makes more sense
for pre-processing.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
tools/build/Makefile.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 99c0ccd..4a0ec5c 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -65,7 +65,7 @@ quiet_cmd_cxx_o_c = CXX $@
cmd_cxx_o_c = $(CXX) $(cxx_flags) -c -o $@ $<
quiet_cmd_cpp_i_c = CPP $@
- cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $<
+ cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $<
quiet_cmd_cc_s_c = AS $@
cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $<
--
2.7.4
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2016-12-23 12:10 +0100 |
| Subject | Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing |
| Message-ID | <sRvTz-674-23@gated-at.bofh.it> |
| In reply to | #1546750 |
On Fri, Dec 23, 2016 at 01:46:42PM +0900, Masahiro Yamada wrote: > The top-level Makefile defines: > > CPP = $(CC) -E hum, so that'd work for running from top level, but I guess it fails for compiling from other places..? like tools/perf jirka > > So, $(CC) -E can be replaced with $(CPP) and this makes more sense > for pre-processing. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > tools/build/Makefile.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build > index 99c0ccd..4a0ec5c 100644 > --- a/tools/build/Makefile.build > +++ b/tools/build/Makefile.build > @@ -65,7 +65,7 @@ quiet_cmd_cxx_o_c = CXX $@ > cmd_cxx_o_c = $(CXX) $(cxx_flags) -c -o $@ $< > > quiet_cmd_cpp_i_c = CPP $@ > - cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $< > + cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $< > > quiet_cmd_cc_s_c = AS $@ > cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $< > -- > 2.7.4 >
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-12-24 07:30 +0100 |
| Message-ID | <sRO09-3a6-5@gated-at.bofh.it> |
| In reply to | #1546823 |
Hi Jiri, 2016-12-23 19:59 GMT+09:00 Jiri Olsa <jolsa@redhat.com>: > On Fri, Dec 23, 2016 at 01:46:42PM +0900, Masahiro Yamada wrote: >> The top-level Makefile defines: >> >> CPP = $(CC) -E > > hum, so that'd work for running from top level, but I guess > it fails for compiling from other places..? like tools/perf I thought users are supposed to build tools from the top-level, but seems it is not necessarily true according to your statement. I am not quite sure how CC, AS, etc. are set-up, then. Perhaps, relying on Make-builtin variables? $ make --print-data-base | grep CPP showed me the default of CPP is CPP = $(CC) -E I guess you are more familiar to the tools-build area, so I follow your decision. -- Best Regards Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web