Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1546052 > unrolled thread

[PATCH 0/4] vfio-mdev: Clean namespace and better define ABI

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Alex Williamson <alex.williamson@redhat.com> - 2016-12-22 00:40 +0100
    [PATCH 1/4] vfio-mdev: Remove an unused structure element Alex Williamson <alex.williamson@redhat.com> - 2016-12-22 00:40 +0100
    Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Jike Song <jike.song@intel.com> - 2016-12-22 03:20 +0100
      Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI Alex Williamson <alex.williamson@redhat.com> - 2016-12-22 03:40 +0100

#1546052 — [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI

Cleanup the namespace a bit by prefixing structures with mdev_ and
also more concretely define the mdev interface.  Structs with comments
defining which fields are private vs public tempts poor behavior,
especially for an interface where we expect out of tree vendor drivers.
Thanks,

Alex

---

Alex Williamson (4):
      vfio-mdev: Remove an unused structure element
      vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
      vfio-mdev: Make mdev_parent private
      vfio-mdev: Make mdev_device private and abstract interfaces


 drivers/gpu/drm/i915/gvt/kvmgt.c |   22 +++++++------
 drivers/vfio/mdev/mdev_core.c    |   64 ++++++++++++++++++++++++++++++--------
 drivers/vfio/mdev/mdev_private.h |   28 +++++++++++++++--
 drivers/vfio/mdev/mdev_sysfs.c   |    8 ++---
 drivers/vfio/mdev/vfio_mdev.c    |   12 ++++---
 include/linux/mdev.h             |   54 +++++++-------------------------
 samples/vfio-mdev/mtty.c         |   28 +++++++++--------
 7 files changed, 123 insertions(+), 93 deletions(-)

[toc] | [next] | [standalone]

#1546057 — [PATCH 1/4] vfio-mdev: Remove an unused structure element

From: Alex Williamson <alwillia@nuc.home>

Cc: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 include/linux/mdev.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/mdev.h b/include/linux/mdev.h
index ec819e9..c3dbf0e 100644
--- a/include/linux/mdev.h
+++ b/include/linux/mdev.h
@@ -35,7 +35,6 @@ struct mdev_device {
 
 	/* internal */
 	struct kref		ref;
-	struct list_head	next;
 	struct kobject		*type_kobj;
 };
 

[toc] | [prev] | [next] | [standalone]

#1546132

On 12/22/2016 07:27 AM, Alex Williamson wrote:
> Cleanup the namespace a bit by prefixing structures with mdev_ and
> also more concretely define the mdev interface.  Structs with comments
> defining which fields are private vs public tempts poor behavior,
> especially for an interface where we expect out of tree vendor drivers.

Personally I like this series :)

Side notes: 1) There is also Documentation to be updated; 2) your mail
address in Author field is @nuc.home?

--
Thanks,
Jike

> 
> ---
> 
> Alex Williamson (4):
>       vfio-mdev: Remove an unused structure element
>       vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
>       vfio-mdev: Make mdev_parent private
>       vfio-mdev: Make mdev_device private and abstract interfaces
> 
> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |   22 +++++++------
>  drivers/vfio/mdev/mdev_core.c    |   64 ++++++++++++++++++++++++++++++--------
>  drivers/vfio/mdev/mdev_private.h |   28 +++++++++++++++--
>  drivers/vfio/mdev/mdev_sysfs.c   |    8 ++---
>  drivers/vfio/mdev/vfio_mdev.c    |   12 ++++---
>  include/linux/mdev.h             |   54 +++++++-------------------------
>  samples/vfio-mdev/mtty.c         |   28 +++++++++--------
>  7 files changed, 123 insertions(+), 93 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

[toc] | [prev] | [next] | [standalone]

#1546135

On Thu, 22 Dec 2016 10:11:00 +0800
Jike Song <jike.song@intel.com> wrote:

> On 12/22/2016 07:27 AM, Alex Williamson wrote:
> > Cleanup the namespace a bit by prefixing structures with mdev_ and
> > also more concretely define the mdev interface.  Structs with comments
> > defining which fields are private vs public tempts poor behavior,
> > especially for an interface where we expect out of tree vendor drivers.  
> 
> Personally I like this series :)
> 
> Side notes: 1) There is also Documentation to be updated; 2) your mail
> address in Author field is @nuc.home?

Thank you on both points, clearly I wrote these on something other than
my usual system.  Thanks,

Alex

> > 
> > ---
> > 
> > Alex Williamson (4):
> >       vfio-mdev: Remove an unused structure element
> >       vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
> >       vfio-mdev: Make mdev_parent private
> >       vfio-mdev: Make mdev_device private and abstract interfaces
> > 
> > 
> >  drivers/gpu/drm/i915/gvt/kvmgt.c |   22 +++++++------
> >  drivers/vfio/mdev/mdev_core.c    |   64 ++++++++++++++++++++++++++++++--------
> >  drivers/vfio/mdev/mdev_private.h |   28 +++++++++++++++--
> >  drivers/vfio/mdev/mdev_sysfs.c   |    8 ++---
> >  drivers/vfio/mdev/vfio_mdev.c    |   12 ++++---
> >  include/linux/mdev.h             |   54 +++++++-------------------------
> >  samples/vfio-mdev/mtty.c         |   28 +++++++++--------
> >  7 files changed, 123 insertions(+), 93 deletions(-)
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> >   

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web