Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1545390 > unrolled thread

[PATCH] checkpatch: stop worrying about include/asm/

Back to article view | Back to linux.kernel

Contents

  [PATCH] checkpatch: stop worrying about include/asm/ Paul Bolle <pebolle@tiscali.nl> - 2016-12-20 20:20 +0100
    Re: [PATCH] checkpatch: stop worrying about include/asm/ Joe Perches <joe@perches.com> - 2016-12-20 21:00 +0100

#1545390 — [PATCH] checkpatch: stop worrying about include/asm/

include/asm/ got removed in v1.1.45. Two decades later it's about time
to stop worrying whether patches still touch it.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Lightly tested.

 scripts/checkpatch.pl | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1c4348..4975f251ba80 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2333,11 +2333,6 @@ sub process {
 				WARN("PATCH_PREFIX",
 				     "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
 			}
-
-			if ($realfile =~ m@^include/asm/@) {
-				ERROR("MODIFIED_INCLUDE_ASM",
-				      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
-			}
 			$found_file = 1;
 		}
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1545449

On Tue, 2016-12-20 at 20:09 +0100, Paul Bolle wrote:
> include/asm/ got removed in v1.1.45. Two decades later it's about time
> to stop worrying whether patches still touch it.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Lightly tested.
> 
>  scripts/checkpatch.pl | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1c4348..4975f251ba80 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2333,11 +2333,6 @@ sub process {
>  				WARN("PATCH_PREFIX",
>  				     "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
>  			}
> -
> -			if ($realfile =~ m@^include/asm/@) {
> -				ERROR("MODIFIED_INCLUDE_ASM",
> -				      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
> -			}
>  			$found_file = 1;
>  		}

I wonder what Andy really intended with commit

It seems wrong.

commit c1ab33269a84d6056d2ffc728d8bbaa26377d3e3
Author: Andy Whitcroft <apw@shadowen.org>
Date:   Wed Oct 15 22:02:20 2008 -0700

    checkpatch: include/asm checks should be anchored
    
    It is possible to have other include/asm paths within the tree which are
    not subject to the do not edit checks.  Ignore those.
    
    Signed-off-by: Andy Whitcroft <apw@shadowen.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 482768cd5790..0e5af8ed107e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1134,7 +1134,7 @@ sub process {
                        $realfile = $1;
                        $realfile =~ s@^[^/]*/@@;
 
-                       if ($realfile =~ m@include/asm/@) {
+                       if ($realfile =~ m@^include/asm/@) {
                                ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
                        }

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web