Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544967 > unrolled thread

[PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit Andrew Jeffery <andrew@aj.id.au> - 2016-12-20 08:40 +0100
    Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the  System Control Unit Joel Stanley <joel@jms.id.au> - 2016-12-20 09:00 +0100
    Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the  System Control Unit Rob Herring <robh@kernel.org> - 2016-12-22 22:10 +0100
    Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the  System Control Unit Linus Walleij <linus.walleij@linaro.org> - 2016-12-27 23:20 +0100

#1544967 — [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit

Reference the SoC-specific compatible string in the examples as
required.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt
index 2ad18c4ea55c..b2efb73337c6 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt
@@ -11,9 +11,14 @@ Required properties:
 		"aspeed,ast2500-pinctrl"
 		"aspeed,g5-pinctrl"
 
-The pin controller node should be a child of a syscon node with the required
+The pin controller node should be the child of a syscon node with the required
 property:
-- compatible: "syscon", "simple-mfd"
+
+- compatible : 		Should be one of the following:
+			"aspeed,ast2400-scu", "syscon", "simple-mfd"
+			"aspeed,g4-scu", "syscon", "simple-mfd"
+			"aspeed,ast2500-scu", "syscon", "simple-mfd"
+			"aspeed,g5-scu", "syscon", "simple-mfd"
 
 Refer to the the bindings described in
 Documentation/devicetree/bindings/mfd/syscon.txt
@@ -50,7 +55,7 @@ TIMER7 TIMER8 VGABIOSROM
 Examples:
 
 syscon: scu@1e6e2000 {
-	compatible = "syscon", "simple-mfd";
+	compatible = "aspeed,ast2400-scu", "syscon", "simple-mfd";
 	reg = <0x1e6e2000 0x1a8>;
 
 	pinctrl: pinctrl {
-- 
2.9.3

[toc] | [next] | [standalone]

#1544971 — Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit

On Tue, Dec 20, 2016 at 6:05 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Reference the SoC-specific compatible string in the examples as
> required.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Acked-by: Joel Stanley <joel@jms.id.au>


> ---
>  Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

[toc] | [prev] | [next] | [standalone]

#1546592 — Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit

On Tue, Dec 20, 2016 at 06:05:47PM +1030, Andrew Jeffery wrote:
> Reference the SoC-specific compatible string in the examples as
> required.
> 
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>  Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1547767 — Re: [PATCH v4 1/5] pinctrl: aspeed: dt: Fix compatibles for the System Control Unit

On Tue, Dec 20, 2016 at 8:35 AM, Andrew Jeffery <andrew@aj.id.au> wrote:

> Reference the SoC-specific compatible string in the examples as
> required.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Patch applied with the ACKs.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web