Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1544344 > unrolled thread
| Started by | Cao jin <caoj.fnst@cn.fujitsu.com> |
|---|---|
| First post | 2016-12-19 08:20 +0100 |
| Last post | 2016-12-19 16:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] genwqe: drop .link_reset() Cao jin <caoj.fnst@cn.fujitsu.com> - 2016-12-19 08:20 +0100
Re: [PATCH] genwqe: drop .link_reset() Bjorn Helgaas <helgaas@kernel.org> - 2016-12-19 16:10 +0100
| From | Cao jin <caoj.fnst@cn.fujitsu.com> |
|---|---|
| Date | 2016-12-19 08:20 +0100 |
| Subject | [PATCH] genwqe: drop .link_reset() |
| Message-ID | <sQ0oN-4FY-3@gated-at.bofh.it> |
In AER recovery, pci_error_handlers.link_reset() is never called,
drop it now.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
drivers/misc/genwqe/card_base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a85023..4fd21e86ad56 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -1336,7 +1336,6 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
static struct pci_error_handlers genwqe_err_handler = {
.error_detected = genwqe_err_error_detected,
.mmio_enabled = genwqe_err_result_none,
- .link_reset = genwqe_err_result_none,
.slot_reset = genwqe_err_slot_reset,
.resume = genwqe_err_resume,
};
--
2.1.0
[toc] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-12-19 16:10 +0100 |
| Message-ID | <sQ7JF-16N-77@gated-at.bofh.it> |
| In reply to | #1544344 |
[+cc linux-pci, Linas]
On Mon, Dec 19, 2016 at 03:23:56PM +0800, Cao jin wrote:
> In AER recovery, pci_error_handlers.link_reset() is never called,
> drop it now.
I think it's true that .link_reset() is never called. If that's the
case, why not remove it completely, i.e., remove it from struct
pci_error_handlers and from all the other drivers that supply it?
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> drivers/misc/genwqe/card_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a85023..4fd21e86ad56 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -1336,7 +1336,6 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
> static struct pci_error_handlers genwqe_err_handler = {
> .error_detected = genwqe_err_error_detected,
> .mmio_enabled = genwqe_err_result_none,
> - .link_reset = genwqe_err_result_none,
> .slot_reset = genwqe_err_slot_reset,
> .resume = genwqe_err_resume,
> };
> --
> 2.1.0
>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web