Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1542640 > unrolled thread

[PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2016-12-15 12:10 +0100
Last post2016-12-17 17:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-12-15 12:10 +0100
    Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to  include/linux/miscdevice.h Greg KH <gregkh@linuxfoundation.org> - 2016-12-15 13:00 +0100
    Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to  include/linux/miscdevice.h David Miller <davem@davemloft.net> - 2016-12-17 17:20 +0100

#1542640 — [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2016-12-15 12:10 +0100
Subject[PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h
Message-ID<sOC5c-52L-5@gated-at.bofh.it>
This patch move the define for IRNET_MINOR to include/linux/miscdevice.h
It is better that all minor number definitions are in the same place.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 include/linux/miscdevice.h | 1 +
 net/irda/irnet/irnet_ppp.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index 18b2e3b..5ea0a65 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -37,6 +37,7 @@
 #define HWRNG_MINOR		183
 #define MICROCODE_MINOR		184
 #define KEYPAD_MINOR		185
+#define IRNET_MINOR		187
 #define D7S_MINOR		193
 #define VFIO_MINOR		196
 #define TUN_MINOR		200
diff --git a/net/irda/irnet/irnet_ppp.h b/net/irda/irnet/irnet_ppp.h
index 693ebc0..18fcead 100644
--- a/net/irda/irnet/irnet_ppp.h
+++ b/net/irda/irnet/irnet_ppp.h
@@ -21,7 +21,6 @@
 
 /* /dev/irnet file constants */
 #define IRNET_MAJOR	10	/* Misc range */
-#define IRNET_MINOR	187	/* Official allocation */
 
 /* IrNET control channel stuff */
 #define IRNET_MAX_COMMAND	256	/* Max length of a command line */
-- 
2.10.2

[toc] | [next] | [standalone]


#1542667 — Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-12-15 13:00 +0100
SubjectRe: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h
Message-ID<sOCRF-5ig-25@gated-at.bofh.it>
In reply to#1542640
On Thu, Dec 15, 2016 at 11:42:48AM +0100, Corentin Labbe wrote:
> This patch move the define for IRNET_MINOR to include/linux/miscdevice.h
> It is better that all minor number definitions are in the same place.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  include/linux/miscdevice.h | 1 +
>  net/irda/irnet/irnet_ppp.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index 18b2e3b..5ea0a65 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -37,6 +37,7 @@
>  #define HWRNG_MINOR		183
>  #define MICROCODE_MINOR		184
>  #define KEYPAD_MINOR		185
> +#define IRNET_MINOR		187
>  #define D7S_MINOR		193
>  #define VFIO_MINOR		196
>  #define TUN_MINOR		200
> diff --git a/net/irda/irnet/irnet_ppp.h b/net/irda/irnet/irnet_ppp.h
> index 693ebc0..18fcead 100644
> --- a/net/irda/irnet/irnet_ppp.h
> +++ b/net/irda/irnet/irnet_ppp.h
> @@ -21,7 +21,6 @@
>  
>  /* /dev/irnet file constants */
>  #define IRNET_MAJOR	10	/* Misc range */
> -#define IRNET_MINOR	187	/* Official allocation */
>  
>  /* IrNET control channel stuff */
>  #define IRNET_MAX_COMMAND	256	/* Max length of a command line */
> -- 
> 2.10.2

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

[toc] | [prev] | [next] | [standalone]


#1544000 — Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

FromDavid Miller <davem@davemloft.net>
Date2016-12-17 17:20 +0100
SubjectRe: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h
Message-ID<sPpSi-3tm-7@gated-at.bofh.it>
In reply to#1542640
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Thu, 15 Dec 2016 11:42:48 +0100

> This patch move the define for IRNET_MINOR to include/linux/miscdevice.h
> It is better that all minor number definitions are in the same place.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web