Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1541979 > unrolled thread
| Started by | Sebastian Reichel <sre@kernel.org> |
|---|---|
| First post | 2016-12-14 16:20 +0100 |
| Last post | 2016-12-19 23:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio Sebastian Reichel <sre@kernel.org> - 2016-12-14 16:20 +0100
Re: [PATCH v3] power: supply: bq24735-charger: optionally poll the ac-detect gpio Sebastian Reichel <sre@kernel.org> - 2016-12-17 16:10 +0100
Re: [PATCH v3] power: supply: bq24735-charger: optionally poll the ac-detect gpio Rob Herring <robh@kernel.org> - 2016-12-19 23:20 +0100
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-12-14 16:20 +0100 |
| Subject | Re: [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio |
| Message-ID | <sOjvz-82q-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Wed, Dec 14, 2016 at 12:56:44AM +0100, Peter Rosin wrote:
> If the ac-detect gpio does not support interrupts, provide a fallback
> to poll the gpio at a configurable interval.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>
> [...]
>
> + } else if (charger->status_gpio) {
> + ret = of_property_read_u32(client->dev.of_node,
> + "poll-interval",
> + &charger->poll_interval);
Please use device_property_read_u32() instead.
> [...]
-- Sebastian
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-12-17 16:10 +0100 |
| Subject | Re: [PATCH v3] power: supply: bq24735-charger: optionally poll the ac-detect gpio |
| Message-ID | <sPoMy-2MF-9@gated-at.bofh.it> |
| In reply to | #1541979 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Thu, Dec 15, 2016 at 10:28:46AM +0100, Peter Rosin wrote: > If the ac-detect gpio does not support interrupts, provide a fallback > to poll the gpio at a configurable interval. > > Signed-off-by: Peter Rosin <peda@axentia.se> Thanks for your patch. We are currently in the merge window and your patch will appear in linux-next once 4.10-rc1 has been tagged by Linus Torvalds. Until then I queued it into this branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next-next -- Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-19 23:20 +0100 |
| Subject | Re: [PATCH v3] power: supply: bq24735-charger: optionally poll the ac-detect gpio |
| Message-ID | <sQerL-5iK-13@gated-at.bofh.it> |
| In reply to | #1541979 |
On Thu, Dec 15, 2016 at 10:28:46AM +0100, Peter Rosin wrote: > If the ac-detect gpio does not support interrupts, provide a fallback > to poll the gpio at a configurable interval. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > > v2 -> v3 changes: > - use device_property_read_u32 instead of of_property_read_u32 > > v1 -> v2 changes: > - use poll-interval instead of ti,poll-interval-ms in the bindings > > Cheers, > peda > > .../bindings/power/supply/ti,bq24735.txt | 2 + Acked-by: Rob Herring <robh@kernel.org> > drivers/power/supply/bq24735-charger.c | 49 +++++++++++++++++++--- > 2 files changed, 46 insertions(+), 5 deletions(-)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web