Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1543868 > unrolled thread

[PATCH] net: use designated initializers

Started byKees Cook <keescook@chromium.org>
First post2016-12-17 02:00 +0100
Last post2016-12-17 22:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: use designated initializers Kees Cook <keescook@chromium.org> - 2016-12-17 02:00 +0100
    Re: [PATCH] net: use designated initializers David Miller <davem@davemloft.net> - 2016-12-17 18:00 +0100
      Re: [PATCH] net: use designated initializers Kees Cook <keescook@chromium.org> - 2016-12-17 22:40 +0100

#1543868 — [PATCH] net: use designated initializers

FromKees Cook <keescook@chromium.org>
Date2016-12-17 02:00 +0100
Subject[PATCH] net: use designated initializers
Message-ID<sPbw2-2nR-5@gated-at.bofh.it>
Prepare to mark sensitive kernel structures for randomization by making
sure they're using designated initializers. These were identified during
allyesconfig builds of x86, arm, and arm64, with most initializer fixes
extracted from grsecurity.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 net/decnet/dn_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index b2c26b081134..41f803e35da3 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -201,7 +201,7 @@ static struct dn_dev_sysctl_table {
 		.extra1 = &min_t3,
 		.extra2 = &max_t3
 	},
-	{0}
+	{ }
 	},
 };
 
-- 
2.7.4


-- 
Kees Cook
Nexus Security

[toc] | [next] | [standalone]


#1544016

FromDavid Miller <davem@davemloft.net>
Date2016-12-17 18:00 +0100
Message-ID<sPquZ-3GN-23@gated-at.bofh.it>
In reply to#1543868
From: Kees Cook <keescook@chromium.org>
Date: Fri, 16 Dec 2016 16:58:58 -0800

> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied, although "decnet: " would have been a much better
subsystem prefix.

[toc] | [prev] | [next] | [standalone]


#1544044

FromKees Cook <keescook@chromium.org>
Date2016-12-17 22:40 +0100
Message-ID<sPuRY-6Fr-21@gated-at.bofh.it>
In reply to#1544016
On Sat, Dec 17, 2016 at 8:57 AM, David Miller <davem@davemloft.net> wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Fri, 16 Dec 2016 16:58:58 -0800
>
>> Prepare to mark sensitive kernel structures for randomization by making
>> sure they're using designated initializers. These were identified during
>> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
>> extracted from grsecurity.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Applied, although "decnet: " would have been a much better
> subsystem prefix.

Thanks! Yeah, I had corrected that in my tree already in case there
was a v2 needed. I was working off an auto-splitting script that I
taught to guess at prefixes by looking at commit logs. It didn't work
very well. ;) We need another field in MAINTAINERS. :)

-Kees

-- 
Kees Cook
Nexus Security

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web