Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1543900 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2016-12-17 02:10 +0100 |
| Last post | 2016-12-28 16:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: use designated initializers Kees Cook <keescook@chromium.org> - 2016-12-17 02:10 +0100
Re: [PATCH] ALSA: use designated initializers Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-12-17 11:20 +0100
Re: [PATCH] ALSA: use designated initializers Takashi Iwai <tiwai@suse.de> - 2016-12-28 16:10 +0100
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-12-17 02:10 +0100 |
| Subject | [PATCH] ALSA: use designated initializers |
| Message-ID | <sPbFF-2GI-87@gated-at.bofh.it> |
Prepare to mark sensitive kernel structures for randomization by making
sure they're using designated initializers. These were identified during
allyesconfig builds of x86, arm, and arm64, with most initializer fixes
extracted from grsecurity.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
sound/synth/emux/emux_seq.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
index a0209204ae48..55579f6b8cb2 100644
--- a/sound/synth/emux/emux_seq.c
+++ b/sound/synth/emux/emux_seq.c
@@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
* MIDI emulation operators
*/
static struct snd_midi_op emux_ops = {
- snd_emux_note_on,
- snd_emux_note_off,
- snd_emux_key_press,
- snd_emux_terminate_note,
- snd_emux_control,
- snd_emux_nrpn,
- snd_emux_sysex,
+ .note_on = snd_emux_note_on,
+ .note_off = snd_emux_note_off,
+ .key_press = snd_emux_key_press,
+ .note_terminate = snd_emux_terminate_note,
+ .control = snd_emux_control,
+ .nrpn = snd_emux_nrpn,
+ .sysex = snd_emux_sysex,
};
--
2.7.4
--
Kees Cook
Nexus Security
[toc] | [next] | [standalone]
| From | Takashi Sakamoto <o-takashi@sakamocchi.jp> |
|---|---|
| Date | 2016-12-17 11:20 +0100 |
| Message-ID | <sPkfU-8jO-3@gated-at.bofh.it> |
| In reply to | #1543900 |
On Dec 17 2016 09:59, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> sound/synth/emux/emux_seq.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
> index a0209204ae48..55579f6b8cb2 100644
> --- a/sound/synth/emux/emux_seq.c
> +++ b/sound/synth/emux/emux_seq.c
> @@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
> * MIDI emulation operators
> */
> static struct snd_midi_op emux_ops = {
> - snd_emux_note_on,
> - snd_emux_note_off,
> - snd_emux_key_press,
> - snd_emux_terminate_note,
> - snd_emux_control,
> - snd_emux_nrpn,
> - snd_emux_sysex,
> + .note_on = snd_emux_note_on,
> + .note_off = snd_emux_note_off,
> + .key_press = snd_emux_key_press,
> + .note_terminate = snd_emux_terminate_note,
> + .control = snd_emux_control,
> + .nrpn = snd_emux_nrpn,
> + .sysex = snd_emux_sysex,
> };
Regards
Takashi Sakamoto
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2016-12-28 16:10 +0100 |
| Message-ID | <sTo1z-1uh-11@gated-at.bofh.it> |
| In reply to | #1543900 |
On Sat, 17 Dec 2016 01:59:44 +0100,
Kees Cook wrote:
>
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied, thanks.
Takashi
> ---
> sound/synth/emux/emux_seq.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
> index a0209204ae48..55579f6b8cb2 100644
> --- a/sound/synth/emux/emux_seq.c
> +++ b/sound/synth/emux/emux_seq.c
> @@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
> * MIDI emulation operators
> */
> static struct snd_midi_op emux_ops = {
> - snd_emux_note_on,
> - snd_emux_note_off,
> - snd_emux_key_press,
> - snd_emux_terminate_note,
> - snd_emux_control,
> - snd_emux_nrpn,
> - snd_emux_sysex,
> + .note_on = snd_emux_note_on,
> + .note_off = snd_emux_note_off,
> + .key_press = snd_emux_key_press,
> + .note_terminate = snd_emux_terminate_note,
> + .control = snd_emux_control,
> + .nrpn = snd_emux_nrpn,
> + .sysex = snd_emux_sysex,
> };
>
>
> --
> 2.7.4
>
>
> --
> Kees Cook
> Nexus Security
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web