Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544111 > unrolled thread

[PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings Devendra Sharma <devendra.sharma9091@gmail.com> - 2016-12-18 10:40 +0100
    Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings Joe Perches <joe@perches.com> - 2016-12-18 10:50 +0100
    Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings Greg KH <gregkh@linuxfoundation.org> - 2016-12-18 11:10 +0100

#1544111 — [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings

From: devendra sharma <devendra.sharma9091@gmail.com>

Signed-off-by Devendra Sharma <devendra.sharma9091@gmail.com>
---
 drivers/staging/comedi/drivers/cb_pcidas64.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index cb9c269..946c580 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
 		if (ao_cmd_is_supported(board)) {
 			devpriv->ao_buffer[i] =
 				dma_alloc_coherent(&pcidev->dev,
-						   DMA_BUFFER_SIZE,
-						   &devpriv->
-						   ao_buffer_bus_addr[i],
-						   GFP_KERNEL);
+				   DMA_BUFFER_SIZE,
+				   &devpriv->ao_buffer_bus_addr[i],
+				   GFP_KERNEL);
 			if (!devpriv->ao_buffer[i])
 				return -ENOMEM;
 		}
@@ -2476,18 +2475,15 @@ static int setup_channel_queue(struct comedi_device *dev,
 			for (i = 0; i < cmd->chanlist_len; i++) {
 				bits = 0;
 				/* set channel */
-				bits |= adc_chan_bits(CR_CHAN(cmd->
-							      chanlist[i]));
+				bits |= adc_chan_bits(
+				CR_CHAN(cmd->chanlist[i]));
 				/* set gain */
 				bits |= ai_range_bits_6xxx(dev,
-							   CR_RANGE(cmd->
-								    chanlist
-								    [i]));
+				   CR_RANGE(cmd->chanlist[i]));
 				/* set single-ended / differential */
 				bits |= se_diff_bit_6xxx(dev,
-							 CR_AREF(cmd->
-								 chanlist[i]) ==
-							 AREF_DIFF);
+					 CR_AREF(cmd->chanlist[i]) ==
+					 AREF_DIFF);
 				if (CR_AREF(cmd->chanlist[i]) == AREF_COMMON)
 					bits |= ADC_COMMON_BIT;
 				/* mark end of queue */
-- 
2.7.4

[toc] | [next] | [standalone]

#1544113

On Sun, 2016-12-18 at 15:06 +0530, Devendra Sharma wrote:
> From: devendra sharma <devendra.sharma9091@gmail.com>
[]
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
[]
> @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
>  		if (ao_cmd_is_supported(board)) {
>  			devpriv->ao_buffer[i] =
>  				dma_alloc_coherent(&pcidev->dev,
> -						   DMA_BUFFER_SIZE,
> -						   &devpriv->
> -						   ao_buffer_bus_addr[i],
> -						   GFP_KERNEL);
> +				   DMA_BUFFER_SIZE,
> +				   &devpriv->ao_buffer_bus_addr[i],
> +				   GFP_KERNEL);
>  			if (!devpriv->ao_buffer[i])
>  				return -ENOMEM;
>  		}

Please just exceed 80 columns instead.

				dma_alloc_coherent(&pcidev->dev,
						   DMA_BUFFER_SIZE,
						   &devpriv->ao_buffer_bus_addr[i],
						   GFP_KERNEL);

etc...

[toc] | [prev] | [next] | [standalone]

#1544115

On Sun, Dec 18, 2016 at 03:06:18PM +0530, Devendra Sharma wrote:
> From: devendra sharma <devendra.sharma9091@gmail.com>
> 
> Signed-off-by Devendra Sharma <devendra.sharma9091@gmail.com>

I can't take patches without any changelog text :(

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web