Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544068 > unrolled thread

[PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

Back to article view | Back to linux.kernel

Contents

  [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c Scott Matheina <scott@matheina.com> - 2016-12-18 03:50 +0100
    Re: [PATCH] fix code alignment with open parenthesis in  drivers/staging/fbtft/fb_agm1264k-fl.c Greg KH <gregkh@linuxfoundation.org> - 2016-12-18 09:00 +0100
      Re: [PATCH] fix code alignment with open parenthesis in  drivers/staging/fbtft/fb_agm1264k-fl.c Scott Matheina <scott@matheina.com> - 2016-12-18 18:50 +0100
        Re: [PATCH] fix code alignment with open parenthesis in  drivers/staging/fbtft/fb_agm1264k-fl.c Scott Matheina <scott@matheina.com> - 2016-12-18 20:40 +0100
        Re: [PATCH] fix code alignment with open parenthesis in  drivers/staging/fbtft/fb_agm1264k-fl.c Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-19 12:50 +0100

#1544068 — [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

Signed-off-by: Scott Matheina <scott@matheina.com>
---
 drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index a6e3af7..4e371ed 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)

 		va_end(args);
 		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
-			par->info->device, u8, buf, len, "%s: ", __func__);
-	}
+				  par->info->device, u8, buf, len,
+				  "%s: ", __func__);
+}

 	va_start(args, len);

@@ -246,7 +247,7 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)

 static void
 construct_line_bitmap(struct fbtft_par *par, u8 *dest, signed short *src,
-						int xs, int xe, int y)
+		      int xs, int xe, int y)
 {
 	int x, i;

@@ -361,7 +362,8 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 		/* left half of display */
 		if (addr_win.xs < par->info->var.xres / 2) {
 			construct_line_bitmap(par, buf, convert_buf,
-				addr_win.xs, par->info->var.xres / 2, y);
+					      addr_win.xs,
+					      par->info->var.xres / 2, y);

 			len = par->info->var.xres / 2 - addr_win.xs;

@@ -382,8 +384,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 		/* right half of display */
 		if (addr_win.xe >= par->info->var.xres / 2) {
 			construct_line_bitmap(par, buf,
-				convert_buf, par->info->var.xres / 2,
-				addr_win.xe + 1, y);
+					      convert_buf,
+					      par->info->var.xres / 2,
+					      addr_win.xe + 1, y);

 			len = addr_win.xe + 1 - par->info->var.xres / 2;

@@ -413,7 +416,7 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 static int write(struct fbtft_par *par, void *buf, size_t len)
 {
 	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
-		"%s(len=%d): ", __func__, len);
+			  "%s(len=%d): ", __func__, len);

 	gpio_set_value(par->RW, 0); /* set write mode */

--
2.7.4

[toc] | [next] | [standalone]

#1544103 — Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
> Signed-off-by: Scott Matheina <scott@matheina.com>

I can't take patches without any changelog text :(

> ---
>  drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index a6e3af7..4e371ed 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
> 
>  		va_end(args);
>  		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
> -			par->info->device, u8, buf, len, "%s: ", __func__);
> -	}
> +				  par->info->device, u8, buf, len,
> +				  "%s: ", __func__);
> +}

I don't think you did this correctly, do you?

[toc] | [prev] | [next] | [standalone]

#1544181 — Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

On 12/18/2016 01:46 AM, Greg KH wrote:
> On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
>> Signed-off-by: Scott Matheina <scott@matheina.com>
> I can't take patches without any changelog text :(
Yah. Forgot to add the description. Added for v2.
>> ---
>>   drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
>>   1 file changed, 10 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
>> index a6e3af7..4e371ed 100644
>> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
>> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
>> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
>>
>>   		va_end(args);
>>   		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
>> -			par->info->device, u8, buf, len, "%s: ", __func__);
>> -	}
>> +				  par->info->device, u8, buf, len,
>> +				  "%s: ", __func__);
>> +}
> I don't think you did this correctly, do you?
I looked at this, and made a change to the line break, but if you're 
talking about
the code itself then I'll have to dig into the books to figure that out. 
Starting small
and learn from reading the code and making some small changes while I figure
it out.

[toc] | [prev] | [next] | [standalone]

#1544192 — Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

I just read an email from Linus saying keep the line length shorter than 
100, so my patch isn't necessary. I sent the v2 out today, but wasn't 
aware of 100 being the new limit checkpatch.pl still has 80 as the 
limit. Sorry to bother. Please disregard my patch.

On 12/18/2016 11:43 AM, Scott Matheina wrote:
>
>
> On 12/18/2016 01:46 AM, Greg KH wrote:
>> On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
>>> Signed-off-by: Scott Matheina <scott@matheina.com>
>> I can't take patches without any changelog text :(
> Yah. Forgot to add the description. Added for v2.
>>> ---
>>>   drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
>>>   1 file changed, 10 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c 
>>> b/drivers/staging/fbtft/fb_agm1264k-fl.c
>>> index a6e3af7..4e371ed 100644
>>> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
>>> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
>>> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par 
>>> *par, int len, ...)
>>>
>>>           va_end(args);
>>>           fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
>>> -            par->info->device, u8, buf, len, "%s: ", __func__);
>>> -    }
>>> +                  par->info->device, u8, buf, len,
>>> +                  "%s: ", __func__);
>>> +}
>> I don't think you did this correctly, do you?
> I looked at this, and made a change to the line break, but if you're 
> talking about
> the code itself then I'll have to dig into the books to figure that 
> out. Starting small
> and learn from reading the code and making some small changes while I 
> figure
> it out.
>

[toc] | [prev] | [next] | [standalone]

#1544482 — Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

He's talking about the final close curly brace }.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web