Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1543359 > unrolled thread

[PATCH 12/13] KVM: arm: avoid binary number literals for gcc-4.2

Started byArnd Bergmann <arnd@arndb.de>
First post2016-12-16 12:00 +0100
Last post2016-12-16 12:00 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 12/13] KVM: arm: avoid binary number literals for gcc-4.2 Arnd Bergmann <arnd@arndb.de> - 2016-12-16 12:00 +0100

#1543359 — [PATCH 12/13] KVM: arm: avoid binary number literals for gcc-4.2

FromArnd Bergmann <arnd@arndb.de>
Date2016-12-16 12:00 +0100
Subject[PATCH 12/13] KVM: arm: avoid binary number literals for gcc-4.2
Message-ID<sOYp4-2rU-19@gated-at.bofh.it>
Old gcc versions prior to 4.3 don't understand the 0b... syntax for
numbers, and this seems to be the only instance in the kernel, so better
use hexadecimal instead.

arch/arm/include/asm/kvm_mmu.h:127:38: error: invalid suffix "b101" on integer constant

Fixes: 159793001d7d ("ARM: KVM: force cache clean on page fault when caches are off")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/include/asm/kvm_mmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/include/asm/kvm_mmu.h
index 74a44727f8e1..61121300174f 100644
--- a/arch/arm/include/asm/kvm_mmu.h
+++ b/arch/arm/include/asm/kvm_mmu.h
@@ -124,7 +124,7 @@ struct kvm;
 
 static inline bool vcpu_has_cache_enabled(struct kvm_vcpu *vcpu)
 {
-	return (vcpu_cp15(vcpu, c1_SCTLR) & 0b101) == 0b101;
+	return (vcpu_cp15(vcpu, c1_SCTLR) & 0x5) == 0x5;
 }
 
 static inline void __coherent_cache_guest_page(struct kvm_vcpu *vcpu,
-- 
2.9.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web