Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543285 > unrolled thread

[PATCH] ARM: imx: remove unused device definitions

Started byArnd Bergmann <arnd@arndb.de>
First post2016-12-16 10:20 +0100
Last post2017-01-02 08:30 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: imx: remove unused device definitions Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:20 +0100
    Re: [PATCH] ARM: imx: remove unused device definitions Marc Kleine-Budde <mkl@pengutronix.de> - 2016-12-16 10:20 +0100
      Re: [PATCH] ARM: imx: remove unused device definitions Marc Kleine-Budde <mkl@pengutronix.de> - 2016-12-16 10:30 +0100
      Re: [PATCH] ARM: imx: remove unused device definitions Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:30 +0100
    Re: [PATCH] ARM: imx: remove unused device definitions Shawn Guo <shawnguo@kernel.org> - 2017-01-02 08:30 +0100

#1543285 — [PATCH] ARM: imx: remove unused device definitions

FromArnd Bergmann <arnd@arndb.de>
Date2016-12-16 10:20 +0100
Subject[PATCH] ARM: imx: remove unused device definitions
Message-ID<sOWQi-1zp-9@gated-at.bofh.it>
I stumbled over these during build testing, they are evidently
not referenced anywhere any more.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-imx/devices/platform-flexcan.c         |  9 ---------
 arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
 2 files changed, 19 deletions(-)

diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
index 55d61eaf63c6..8a1a2fc4ce10 100644
--- a/arch/arm/mach-imx/devices/platform-flexcan.c
+++ b/arch/arm/mach-imx/devices/platform-flexcan.c
@@ -19,15 +19,6 @@
 #define imx_flexcan_data_entry(soc, _id, _hwid, _size)			\
 	[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
 
-#ifdef CONFIG_SOC_IMX25
-const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
-#define imx25_flexcan_data_entry(_id, _hwid)				\
-	imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
-	imx25_flexcan_data_entry(0, 1),
-	imx25_flexcan_data_entry(1, 2),
-};
-#endif /* ifdef CONFIG_SOC_IMX25 */
-
 #ifdef CONFIG_SOC_IMX35
 const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
 #define imx35_flexcan_data_entry(_id, _hwid)				\
diff --git a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
index 3d039ef021e0..466c9ccc6675 100644
--- a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
+++ b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
@@ -22,16 +22,6 @@
 #define imx_sdhci_esdhc_imx_data_entry(soc, devid, id, hwid)	\
 	[id] = imx_sdhci_esdhc_imx_data_entry_single(soc, devid, id, hwid)
 
-#ifdef CONFIG_SOC_IMX25
-const struct imx_sdhci_esdhc_imx_data
-imx25_sdhci_esdhc_imx_data[] __initconst = {
-#define imx25_sdhci_esdhc_imx_data_entry(_id, _hwid)			\
-	imx_sdhci_esdhc_imx_data_entry(MX25, "sdhci-esdhc-imx25", _id, _hwid)
-	imx25_sdhci_esdhc_imx_data_entry(0, 1),
-	imx25_sdhci_esdhc_imx_data_entry(1, 2),
-};
-#endif /* ifdef CONFIG_SOC_IMX25 */
-
 #ifdef CONFIG_SOC_IMX35
 const struct imx_sdhci_esdhc_imx_data
 imx35_sdhci_esdhc_imx_data[] __initconst = {
-- 
2.9.0

[toc] | [next] | [standalone]

#1543288

FromMarc Kleine-Budde <mkl@pengutronix.de>
Date2016-12-16 10:20 +0100
Message-ID<sOWQi-1zp-7@gated-at.bofh.it>
In reply to#1543285

[Multipart message — attachments visible in raw view] — view raw

On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
> I stumbled over these during build testing, they are evidently
> not referenced anywhere any more.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/mach-imx/devices/platform-flexcan.c         |  9 ---------
>  arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
>  2 files changed, 19 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
> index 55d61eaf63c6..8a1a2fc4ce10 100644
> --- a/arch/arm/mach-imx/devices/platform-flexcan.c
> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
> @@ -19,15 +19,6 @@
>  #define imx_flexcan_data_entry(soc, _id, _hwid, _size)			\
>  	[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
>  
> -#ifdef CONFIG_SOC_IMX25
> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
> -#define imx25_flexcan_data_entry(_id, _hwid)				\
> -	imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
> -	imx25_flexcan_data_entry(0, 1),
> -	imx25_flexcan_data_entry(1, 2),
> -};
> -#endif /* ifdef CONFIG_SOC_IMX25 */
> -
>  #ifdef CONFIG_SOC_IMX35
>  const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
>  #define imx35_flexcan_data_entry(_id, _hwid)				\

What about the imx35 variant?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

[toc] | [prev] | [next] | [standalone]

#1543301

FromMarc Kleine-Budde <mkl@pengutronix.de>
Date2016-12-16 10:30 +0100
Message-ID<sOWZY-1DO-21@gated-at.bofh.it>
In reply to#1543288

[Multipart message — attachments visible in raw view] — view raw

On 12/16/2016 10:23 AM, Arnd Bergmann wrote:
> On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote:
>> On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
>>> I stumbled over these during build testing, they are evidently
>>> not referenced anywhere any more.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>  arch/arm/mach-imx/devices/platform-flexcan.c         |  9 ---------
>>>  arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
>>>  2 files changed, 19 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> index 55d61eaf63c6..8a1a2fc4ce10 100644
>>> --- a/arch/arm/mach-imx/devices/platform-flexcan.c
>>> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> @@ -19,15 +19,6 @@
>>>  #define imx_flexcan_data_entry(soc, _id, _hwid, _size)			\
>>>  	[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
>>>  
>>> -#ifdef CONFIG_SOC_IMX25
>>> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
>>> -#define imx25_flexcan_data_entry(_id, _hwid)				\
>>> -	imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
>>> -	imx25_flexcan_data_entry(0, 1),
>>> -	imx25_flexcan_data_entry(1, 2),
>>> -};
>>> -#endif /* ifdef CONFIG_SOC_IMX25 */
>>> -
>>>  #ifdef CONFIG_SOC_IMX35
>>>  const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
>>>  #define imx35_flexcan_data_entry(_id, _hwid)				\
>>
>> What about the imx35 variant?
>>
> 
> It's used from here:
> 
> arch/arm/mach-imx/mach-pcm043.c:        imx35_add_flexcan1();

Yes, you're right. Sorry, I searched before my 2nd tee.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

[toc] | [prev] | [next] | [standalone]

#1543308

FromArnd Bergmann <arnd@arndb.de>
Date2016-12-16 10:30 +0100
Message-ID<sOWZY-1DO-23@gated-at.bofh.it>
In reply to#1543288
On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote:
> On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
> > I stumbled over these during build testing, they are evidently
> > not referenced anywhere any more.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  arch/arm/mach-imx/devices/platform-flexcan.c         |  9 ---------
> >  arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
> >  2 files changed, 19 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
> > index 55d61eaf63c6..8a1a2fc4ce10 100644
> > --- a/arch/arm/mach-imx/devices/platform-flexcan.c
> > +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
> > @@ -19,15 +19,6 @@
> >  #define imx_flexcan_data_entry(soc, _id, _hwid, _size)			\
> >  	[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
> >  
> > -#ifdef CONFIG_SOC_IMX25
> > -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
> > -#define imx25_flexcan_data_entry(_id, _hwid)				\
> > -	imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
> > -	imx25_flexcan_data_entry(0, 1),
> > -	imx25_flexcan_data_entry(1, 2),
> > -};
> > -#endif /* ifdef CONFIG_SOC_IMX25 */
> > -
> >  #ifdef CONFIG_SOC_IMX35
> >  const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
> >  #define imx35_flexcan_data_entry(_id, _hwid)				\
> 
> What about the imx35 variant?
> 

It's used from here:

arch/arm/mach-imx/mach-pcm043.c:        imx35_add_flexcan1();

	Arnd

[toc] | [prev] | [next] | [standalone]

#1548986

FromShawn Guo <shawnguo@kernel.org>
Date2017-01-02 08:30 +0100
Message-ID<sV5e9-3o6-5@gated-at.bofh.it>
In reply to#1543285
On Fri, Dec 16, 2016 at 10:05:08AM +0100, Arnd Bergmann wrote:
> I stumbled over these during build testing, they are evidently
> not referenced anywhere any more.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web