Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1542828 > unrolled thread

[PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2016-12-15 16:30 +0100
Last post2016-12-19 11:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-12-15 16:30 +0100
    Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h  include Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-12-15 17:30 +0100
    Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h  include Jiri Kosina <jikos@kernel.org> - 2016-12-19 11:20 +0100

#1542828 — [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2016-12-15 16:30 +0100
Subject[PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
Message-ID<sOG8O-7rb-35@gated-at.bofh.it>
hid/intel-ish-hid does not use any miscdevice so this patch remove
this unnecessary inclusion.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
 drivers/hid/intel-ish-hid/ishtp/hbm.c   | 1 -
 drivers/hid/intel-ish-hid/ishtp/init.c  | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index 20d647d..d20da39 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -24,7 +24,6 @@
 #include <linux/sched.h>
 #include <linux/interrupt.h>
 #include <linux/workqueue.h>
-#include <linux/miscdevice.h>
 #define CREATE_TRACE_POINTS
 #include <trace/events/intel_ish.h>
 #include "ishtp-dev.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c
index 59460b6..b721360 100644
--- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
+++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
@@ -19,7 +19,6 @@
 #include <linux/sched.h>
 #include <linux/wait.h>
 #include <linux/spinlock.h>
-#include <linux/miscdevice.h>
 #include "ishtp-dev.h"
 #include "hbm.h"
 #include "client.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c b/drivers/hid/intel-ish-hid/ishtp/init.c
index ac36441..d27e035 100644
--- a/drivers/hid/intel-ish-hid/ishtp/init.c
+++ b/drivers/hid/intel-ish-hid/ishtp/init.c
@@ -16,7 +16,6 @@
 #include <linux/export.h>
 #include <linux/slab.h>
 #include <linux/sched.h>
-#include <linux/miscdevice.h>
 #include "ishtp-dev.h"
 #include "hbm.h"
 #include "client.h"
-- 
2.10.2

[toc] | [next] | [standalone]


#1542865 — Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2016-12-15 17:30 +0100
SubjectRe: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
Message-ID<sOH4S-80J-7@gated-at.bofh.it>
In reply to#1542828
On Thu, 2016-12-15 at 16:27 +0100, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
>  drivers/hid/intel-ish-hid/ishtp/hbm.c   | 1 -
>  drivers/hid/intel-ish-hid/ishtp/init.c  | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 20d647d..d20da39 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -24,7 +24,6 @@
>  #include <linux/sched.h>
>  #include <linux/interrupt.h>
>  #include <linux/workqueue.h>
> -#include <linux/miscdevice.h>
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/intel_ish.h>
>  #include "ishtp-dev.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> index 59460b6..b721360 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> @@ -19,7 +19,6 @@
>  #include <linux/sched.h>
>  #include <linux/wait.h>
>  #include <linux/spinlock.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c
> b/drivers/hid/intel-ish-hid/ishtp/init.c
> index ac36441..d27e035 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/init.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/init.c
> @@ -16,7 +16,6 @@
>  #include <linux/export.h>
>  #include <linux/slab.h>
>  #include <linux/sched.h>
> -#include <linux/miscdevice.h>
>  #include "ishtp-dev.h"
>  #include "hbm.h"
>  #include "client.h"

[toc] | [prev] | [next] | [standalone]


#1544423 — Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include

FromJiri Kosina <jikos@kernel.org>
Date2016-12-19 11:20 +0100
SubjectRe: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
Message-ID<sQ3d0-6pH-3@gated-at.bofh.it>
In reply to#1542828
On Thu, 15 Dec 2016, Corentin Labbe wrote:

> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web