Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541078 > unrolled thread

[PATCH] selftest: sync: improve assert() failure message

Started byGustavo Padovan <gustavo@padovan.org>
First post2016-12-13 14:50 +0100
Last post2016-12-13 15:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] selftest: sync: improve assert() failure message Gustavo Padovan <gustavo@padovan.org> - 2016-12-13 14:50 +0100
    Re: [PATCH] selftest: sync: improve assert() failure message Shuah Khan <shuah@kernel.org> - 2016-12-13 15:40 +0100

#1541078 — [PATCH] selftest: sync: improve assert() failure message

FromGustavo Padovan <gustavo@padovan.org>
Date2016-12-13 14:50 +0100
Subject[PATCH] selftest: sync: improve assert() failure message
Message-ID<sNVCW-1NI-21@gated-at.bofh.it>
From: Gustavo Padovan <gustavo.padovan@collabora.com>

Print "ERROR" on all messages instead of using the not well defined terms
like "BAD".

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
 tools/testing/selftests/sync/synctest.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
index 4e0e59f..e7d1d57 100644
--- a/tools/testing/selftests/sync/synctest.h
+++ b/tools/testing/selftests/sync/synctest.h
@@ -32,7 +32,7 @@
 
 #define ASSERT(cond, msg) do { \
 	if (!(cond)) { \
-		printf("[BAD]\t%s", (msg)); \
+		printf("[ERROR]\t%s", (msg)); \
 		return 1; \
 	} \
 } while (0)
-- 
2.5.5

[toc] | [next] | [standalone]


#1541122

FromShuah Khan <shuah@kernel.org>
Date2016-12-13 15:40 +0100
Message-ID<sNWpj-2jB-9@gated-at.bofh.it>
In reply to#1541078
On 12/13/2016 06:48 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> Print "ERROR" on all messages instead of using the not well defined terms
> like "BAD".
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> ---
>  tools/testing/selftests/sync/synctest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
> index 4e0e59f..e7d1d57 100644
> --- a/tools/testing/selftests/sync/synctest.h
> +++ b/tools/testing/selftests/sync/synctest.h
> @@ -32,7 +32,7 @@
>  
>  #define ASSERT(cond, msg) do { \
>  	if (!(cond)) { \
> -		printf("[BAD]\t%s", (msg)); \
> +		printf("[ERROR]\t%s", (msg)); \
>  		return 1; \
>  	} \
>  } while (0)
> 

Thanks, Applied to linux-kselftest next for 4.10-rc1

-- Shuah

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web