Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540396 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2016-12-12 16:40 +0100 |
| Last post | 2016-12-13 13:40 +0100 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Rob Herring <robh@kernel.org> - 2016-12-12 16:40 +0100
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Andrew Jeffery <andrew@aj.id.au> - 2016-12-13 06:00 +0100
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Lee Jones <lee.jones@linaro.org> - 2016-12-13 12:10 +0100
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Andrew Jeffery <andrew@aj.id.au> - 2016-12-13 13:20 +0100
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Arnd Bergmann <arnd@arndb.de> - 2016-12-13 13:30 +0100
Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Andrew Jeffery <andrew@aj.id.au> - 2016-12-13 13:40 +0100
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-12 16:40 +0100 |
| Subject | Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory |
| Message-ID | <sNARQ-64o-17@gated-at.bofh.it> |
On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote:
> The use of syscons is growing, lets collate them in their own part of
> the bindings tree.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0
> Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0
> Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0
> Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0
> Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0
> Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0
> .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0
> 7 files changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%)
> rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)
I'm not so sure this is the right direction. syscon usage is pretty much
spread throughout the tree.
Rob
[toc] | [next] | [standalone]
| From | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| Date | 2016-12-13 06:00 +0100 |
| Message-ID | <sNNm2-59d-7@gated-at.bofh.it> |
| In reply to | #1540396 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote:
> On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote:
> > The use of syscons is growing, lets collate them in their own part of
> > the bindings tree.
> >
> > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0
> > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0
> > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0
> > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0
> > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0
> > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0
> > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0
> > 7 files changed, 0 insertions(+), 0 deletions(-)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%)
> > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)
>
> I'm not so sure this is the right direction. syscon usage is pretty much
> spread throughout the tree.
This patch was created based on my interpretation of Lee's feedback
here:
https://lkml.org/lkml/2016/11/18/650
Lee's next email in the chain poked Arnd for an opinion, but Arnd
didn't reply.
I don't mind. I moved these bindings separately so we could just drop
the patch if there was push-back. If we drop the whole idea I'll need
to apply a small fix to patch 5/6 to avoid creating the syscon
subdirectory.
Andrew
>
> Rob
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-12-13 12:10 +0100 |
| Message-ID | <sNT86-tf-25@gated-at.bofh.it> |
| In reply to | #1540846 |
On Tue, 13 Dec 2016, Andrew Jeffery wrote:
> On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote:
> > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote:
> > > The use of syscons is growing, lets collate them in their own part of
> > > the bindings tree.
> > >
> > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > ---
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0
> > > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0
> > > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0
> > > 7 files changed, 0 insertions(+), 0 deletions(-)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%)
> > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)
> >
> > I'm not so sure this is the right direction. syscon usage is pretty much
> > spread throughout the tree.
>
> This patch was created based on my interpretation of Lee's feedback
> here:
>
> https://lkml.org/lkml/2016/11/18/650
>
> Lee's next email in the chain poked Arnd for an opinion, but Arnd
> didn't reply.
>
> I don't mind. I moved these bindings separately so we could just drop
> the patch if there was push-back. If we drop the whole idea I'll need
> to apply a small fix to patch 5/6 to avoid creating the syscon
> subdirectory.
The sub-directory is a good idea for drivers who are *solely* syscon
based.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| Date | 2016-12-13 13:20 +0100 |
| Message-ID | <sNUdP-14R-9@gated-at.bofh.it> |
| In reply to | #1541003 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote:
> On Tue, 13 Dec 2016, Andrew Jeffery wrote:
>
> > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote:
> > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote:
> > > > The use of syscons is growing, lets collate them in their own part of
> > > > the bindings tree.
> > > >
> > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > >
> > > > ---
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0
> > > > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0
> > > > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0
> > > > 7 files changed, 0 insertions(+), 0 deletions(-)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%)
> > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)
> > >
> > > I'm not so sure this is the right direction. syscon usage is pretty much
> > > spread throughout the tree.
> >
> > This patch was created based on my interpretation of Lee's feedback
> > here:
> >
> > https://lkml.org/lkml/2016/11/18/650
> >
> > Lee's next email in the chain poked Arnd for an opinion, but Arnd
> > didn't reply.
> >
> > I don't mind. I moved these bindings separately so we could just drop
> > the patch if there was push-back. If we drop the whole idea I'll need
> > to apply a small fix to patch 5/6 to avoid creating the syscon
> > subdirectory.
>
> The sub-directory is a good idea for drivers who are *solely* syscon
> based.
>
Yes, I wasn't saying otherwise, just commenting on my motivation and
approach.
As far as I can tell all of the bindings I move here describe solely
syscon-based devices.
Cheers,
Andrew
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-12-13 13:30 +0100 |
| Subject | Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory |
| Message-ID | <sNUnw-18c-25@gated-at.bofh.it> |
| In reply to | #1541030 |
On Tuesday, December 13, 2016 10:35:34 PM CET Andrew Jeffery wrote: > On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote: > > On Tue, 13 Dec 2016, Andrew Jeffery wrote: > > > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > > > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > > > didn't reply. > > > > > > I don't mind. I moved these bindings separately so we could just drop > > > the patch if there was push-back. If we drop the whole idea I'll need > > > to apply a small fix to patch 5/6 to avoid creating the syscon > > > subdirectory. > > > > The sub-directory is a good idea for drivers who are *solely* syscon > > based. > > > > Yes, I wasn't saying otherwise, just commenting on my motivation and > approach. > > As far as I can tell all of the bindings I move here describe solely > syscon-based devices. > But do we know which ones they are? In principle, any syscon device node can have a specialized driver exporting an interface, the bindings always allow it to be done one way or the other, and we may change the driver or run a different OS that has decided differently. Arnd
[toc] | [prev] | [next] | [standalone]
| From | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| Date | 2016-12-13 13:40 +0100 |
| Message-ID | <sNUxc-1bk-33@gated-at.bofh.it> |
| In reply to | #1541038 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 2016-12-13 at 13:17 +0100, Arnd Bergmann wrote: > On Tuesday, December 13, 2016 10:35:34 PM CET Andrew Jeffery wrote: > > On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote: > > > On Tue, 13 Dec 2016, Andrew Jeffery wrote: > > > > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > > > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > > > > > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > > > > didn't reply. > > > > > > > > I don't mind. I moved these bindings separately so we could just drop > > > > the patch if there was push-back. If we drop the whole idea I'll need > > > > to apply a small fix to patch 5/6 to avoid creating the syscon > > > > subdirectory. > > > > > > The sub-directory is a good idea for drivers who are *solely* syscon > > > based. > > > > > > > Yes, I wasn't saying otherwise, just commenting on my motivation and > > approach. > > > > As far as I can tell all of the bindings I move here describe solely > > syscon-based devices. > > > > But do we know which ones they are? > > In principle, any syscon device node can have a specialized driver > exporting an interface, the bindings always allow it to be done > one way or the other, and we may change the driver or run a different > OS that has decided differently. > Right; for the Linux case there are currently no driver implementations that match on the compatible strings in the documents I moved (save for qcom,tcsr, except that it's the qcom,gsbi compatible driver parsing a phandle to the qcom,tcsr syscon node). However, I can't guarantee the solely-syscon property for other operating systems. Given that, it now looks to me like we shouldn't have such a directory at all. Cheers, Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web