Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540816 > unrolled thread

Re: [PATCH] selftests: ftrace: Shift down default message verbosity

Started byMasami Hiramatsu <masami.hiramatsu@gmail.com>
First post2016-12-13 04:30 +0100
Last post2016-12-15 09:10 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] selftests: ftrace: Shift down default message verbosity Masami Hiramatsu <masami.hiramatsu@gmail.com> - 2016-12-13 04:30 +0100
    Re: [PATCH] selftests: ftrace: Shift down default message verbosity Shuah Khan <shuah@kernel.org> - 2016-12-13 15:10 +0100
      Re: [PATCH] selftests: ftrace: Shift down default message verbosity Steven Rostedt <rostedt@goodmis.org> - 2016-12-13 16:40 +0100
        Re: [PATCH] selftests: ftrace: Shift down default message verbosity Shuah Khan <shuah@kernel.org> - 2016-12-13 17:10 +0100
          Re: [PATCH] selftests: ftrace: Shift down default message verbosity Steven Rostedt <rostedt@goodmis.org> - 2016-12-13 17:40 +0100
          Re: [PATCH] selftests: ftrace: Shift down default message verbosity Masami Hiramatsu <mhiramat@kernel.org> - 2016-12-15 09:10 +0100

#1540816 — Re: [PATCH] selftests: ftrace: Shift down default message verbosity

FromMasami Hiramatsu <masami.hiramatsu@gmail.com>
Date2016-12-13 04:30 +0100
SubjectRe: [PATCH] selftests: ftrace: Shift down default message verbosity
Message-ID<sNLWV-4rn-1@gated-at.bofh.it>
Ping?

On Fri, 25 Nov 2016 21:58:48 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Shift down default message verbosity, so that do not show
> error results in stdout by default. Since that behavior
> is same as giving --quiet option, this patch removes
> --quiet and make --verbose increasing verbosity.
> 
> In other words, this changes verbosity options as below.
> ftracetest -q -> ftracetest
> ftracetest    -> ftracetest -v
> ftracetest -v -> ftracetest -v -v (or -vv)
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  tools/testing/selftests/ftrace/ftracetest |   18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 685376b4..52e3c4d 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -13,8 +13,8 @@ echo "Usage: ftracetest [options] [testcase(s)] [testcase-directory(s)]"
>  echo " Options:"
>  echo "		-h|--help  Show help message"
>  echo "		-k|--keep  Keep passed test logs"
> -echo "		-v|--verbose Show all stdout messages in testcases"
> -echo "		-q|--quiet Do not show error log on stdout"
> +echo "		-v|--verbose Increase verbosity of test messages"
> +echo "		-vv        Alias of -v -v (Show all results in stdout)"
>  echo "		-d|--debug Debug mode (trace all shell commands)"
>  exit $1
>  }
> @@ -55,12 +55,9 @@ parse_opts() { # opts
>        KEEP_LOG=1
>        shift 1
>      ;;
> -    --verbose|-v)
> -      VERBOSE=1
> -      shift 1
> -    ;;
> -    --quiet|-q)
> -      BE_QUIET=1
> +    --verbose|-v|-vv)
> +      VERBOSE=$((VERBOSE + 1))
> +      [ $1 == '-vv' ] && VERBOSE=$((VERBOSE + 1))
>        shift 1
>      ;;
>      --debug|-d)
> @@ -106,7 +103,6 @@ LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
>  KEEP_LOG=0
>  DEBUG=0
>  VERBOSE=0
> -BE_QUIET=0
>  # Parse command-line options
>  parse_opts $*
>  
> @@ -246,7 +242,7 @@ run_test() { # testfile
>    testcase $1
>    echo "execute: "$1 > $testlog
>    SIG_RESULT=0
> -  if [ $VERBOSE -ne 0 ]; then
> +  if [ $VERBOSE -ge 2 ]; then
>      __run_test $1 2>> $testlog | tee -a $testlog
>    else
>      __run_test $1 >> $testlog 2>&1
> @@ -256,7 +252,7 @@ run_test() { # testfile
>      # Remove test log if the test was done as it was expected.
>      [ $KEEP_LOG -eq 0 ] && rm $testlog
>    else
> -    [ $BE_QUIET -eq 0 ] && catlog $testlog
> +    [ $VERBOSE -ge 1 ] && catlog $testlog
>      TOTAL_RESULT=1
>    fi
>    rm -rf $TMPDIR
> 


-- 
Masami Hiramatsu

[toc] | [next] | [standalone]

#1541095

FromShuah Khan <shuah@kernel.org>
Date2016-12-13 15:10 +0100
Message-ID<sNVWi-29W-13@gated-at.bofh.it>
In reply to#1540816
On 12/12/2016 08:23 PM, Masami Hiramatsu wrote:
> Ping?
> 
> On Fri, 25 Nov 2016 21:58:48 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
>> Shift down default message verbosity, so that do not show
>> error results in stdout by default. Since that behavior
>> is same as giving --quiet option, this patch removes
>> --quiet and make --verbose increasing verbosity.
>>
>> In other words, this changes verbosity options as below.
>> ftracetest -q -> ftracetest
>> ftracetest    -> ftracetest -v
>> ftracetest -v -> ftracetest -v -v (or -vv)
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Hi Steve,

Are you taking this through yours? Or Should I include in my
pull request? Please give me Ack if you want me to.

thanks,
-- Shuah
>> ---
>>  tools/testing/selftests/ftrace/ftracetest |   18 +++++++-----------
>>  1 file changed, 7 insertions(+), 11 deletions(-)
>>
>> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
>> index 685376b4..52e3c4d 100755
>> --- a/tools/testing/selftests/ftrace/ftracetest
>> +++ b/tools/testing/selftests/ftrace/ftracetest
>> @@ -13,8 +13,8 @@ echo "Usage: ftracetest [options] [testcase(s)] [testcase-directory(s)]"
>>  echo " Options:"
>>  echo "		-h|--help  Show help message"
>>  echo "		-k|--keep  Keep passed test logs"
>> -echo "		-v|--verbose Show all stdout messages in testcases"
>> -echo "		-q|--quiet Do not show error log on stdout"
>> +echo "		-v|--verbose Increase verbosity of test messages"
>> +echo "		-vv        Alias of -v -v (Show all results in stdout)"
>>  echo "		-d|--debug Debug mode (trace all shell commands)"
>>  exit $1
>>  }
>> @@ -55,12 +55,9 @@ parse_opts() { # opts
>>        KEEP_LOG=1
>>        shift 1
>>      ;;
>> -    --verbose|-v)
>> -      VERBOSE=1
>> -      shift 1
>> -    ;;
>> -    --quiet|-q)
>> -      BE_QUIET=1
>> +    --verbose|-v|-vv)
>> +      VERBOSE=$((VERBOSE + 1))
>> +      [ $1 == '-vv' ] && VERBOSE=$((VERBOSE + 1))
>>        shift 1
>>      ;;
>>      --debug|-d)
>> @@ -106,7 +103,6 @@ LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`/
>>  KEEP_LOG=0
>>  DEBUG=0
>>  VERBOSE=0
>> -BE_QUIET=0
>>  # Parse command-line options
>>  parse_opts $*
>>  
>> @@ -246,7 +242,7 @@ run_test() { # testfile
>>    testcase $1
>>    echo "execute: "$1 > $testlog
>>    SIG_RESULT=0
>> -  if [ $VERBOSE -ne 0 ]; then
>> +  if [ $VERBOSE -ge 2 ]; then
>>      __run_test $1 2>> $testlog | tee -a $testlog
>>    else
>>      __run_test $1 >> $testlog 2>&1
>> @@ -256,7 +252,7 @@ run_test() { # testfile
>>      # Remove test log if the test was done as it was expected.
>>      [ $KEEP_LOG -eq 0 ] && rm $testlog
>>    else
>> -    [ $BE_QUIET -eq 0 ] && catlog $testlog
>> +    [ $VERBOSE -ge 1 ] && catlog $testlog
>>      TOTAL_RESULT=1
>>    fi
>>    rm -rf $TMPDIR
>>
> 
>

[toc] | [prev] | [next] | [standalone]

#1541195

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-12-13 16:40 +0100
Message-ID<sNXln-2Sz-3@gated-at.bofh.it>
In reply to#1541095
On Tue, 13 Dec 2016 07:06:18 -0700
Shuah Khan <shuah@kernel.org> wrote:

> On 12/12/2016 08:23 PM, Masami Hiramatsu wrote:
> > Ping?
> > 
> > On Fri, 25 Nov 2016 21:58:48 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >   
> >> Shift down default message verbosity, so that do not show
> >> error results in stdout by default. Since that behavior
> >> is same as giving --quiet option, this patch removes
> >> --quiet and make --verbose increasing verbosity.
> >>
> >> In other words, this changes verbosity options as below.
> >> ftracetest -q -> ftracetest
> >> ftracetest    -> ftracetest -v
> >> ftracetest -v -> ftracetest -v -v (or -vv)
> >>
> >> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>  
> 
> Hi Steve,
> 
> Are you taking this through yours? Or Should I include in my
> pull request? Please give me Ack if you want me to.
> 

I'll take it. I believe it may be built on top of other patches I took.
I'm getting ready for a push anyway. Since this only touches the self
test code, I don't need to run my full test suite on it.

Thanks!

-- Steve

[toc] | [prev] | [next] | [standalone]

#1541216

FromShuah Khan <shuah@kernel.org>
Date2016-12-13 17:10 +0100
Message-ID<sNXOq-3i2-21@gated-at.bofh.it>
In reply to#1541195
On 12/13/2016 08:25 AM, Steven Rostedt wrote:
> On Tue, 13 Dec 2016 07:06:18 -0700
> Shuah Khan <shuah@kernel.org> wrote:
> 
>> On 12/12/2016 08:23 PM, Masami Hiramatsu wrote:
>>> Ping?
>>>
>>> On Fri, 25 Nov 2016 21:58:48 +0900
>>> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>>>   
>>>> Shift down default message verbosity, so that do not show
>>>> error results in stdout by default. Since that behavior
>>>> is same as giving --quiet option, this patch removes
>>>> --quiet and make --verbose increasing verbosity.
>>>>
>>>> In other words, this changes verbosity options as below.
>>>> ftracetest -q -> ftracetest
>>>> ftracetest    -> ftracetest -v
>>>> ftracetest -v -> ftracetest -v -v (or -vv)
>>>>
>>>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>  
>>
>> Hi Steve,
>>
>> Are you taking this through yours? Or Should I include in my
>> pull request? Please give me Ack if you want me to.
>>
> 
> I'll take it. I believe it may be built on top of other patches I took.
> I'm getting ready for a push anyway. Since this only touches the self
> test code, I don't need to run my full test suite on it.
> 
> Thanks!
> 
> -- Steve
> 
> 

Yes. I tried applying to my tree and I think it is dependent on other
patches in your tree. Here is my:

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1541236

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-12-13 17:40 +0100
Message-ID<sNYhr-3rV-11@gated-at.bofh.it>
In reply to#1541216
On Tue, 13 Dec 2016 09:03:19 -0700
Shuah Khan <shuah@kernel.org> wrote:

> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks!

-- Steve

[toc] | [prev] | [next] | [standalone]

#1542540

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2016-12-15 09:10 +0100
Message-ID<sOzgZ-3nX-3@gated-at.bofh.it>
In reply to#1541216
On Tue, 13 Dec 2016 09:03:19 -0700
Shuah Khan <shuah@kernel.org> wrote:

> On 12/13/2016 08:25 AM, Steven Rostedt wrote:
> > On Tue, 13 Dec 2016 07:06:18 -0700
> > Shuah Khan <shuah@kernel.org> wrote:
> > 
> >> On 12/12/2016 08:23 PM, Masami Hiramatsu wrote:
> >>> Ping?
> >>>
> >>> On Fri, 25 Nov 2016 21:58:48 +0900
> >>> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >>>   
> >>>> Shift down default message verbosity, so that do not show
> >>>> error results in stdout by default. Since that behavior
> >>>> is same as giving --quiet option, this patch removes
> >>>> --quiet and make --verbose increasing verbosity.
> >>>>
> >>>> In other words, this changes verbosity options as below.
> >>>> ftracetest -q -> ftracetest
> >>>> ftracetest    -> ftracetest -v
> >>>> ftracetest -v -> ftracetest -v -v (or -vv)
> >>>>
> >>>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>  
> >>
> >> Hi Steve,
> >>
> >> Are you taking this through yours? Or Should I include in my
> >> pull request? Please give me Ack if you want me to.
> >>
> > 
> > I'll take it. I believe it may be built on top of other patches I took.
> > I'm getting ready for a push anyway. Since this only touches the self
> > test code, I don't need to run my full test suite on it.
> > 
> > Thanks!
> > 
> > -- Steve
> > 
> > 
> 
> Yes. I tried applying to my tree and I think it is dependent on other
> patches in your tree. Here is my:
> 
> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

Thank you Shuah and Steve! :)


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web